SRL Archive - Reflection Development

After fixing a couple of more bugs and suggestions, I believe we are ready for a full release! The include is much more capable than reflection 1 and much more up-to-date. That being said, all owners of reflection 1 scripts are going to need to update their scripts, as a takeover is imminent! Once reflection 2 is uploaded to the SRL repository and the extension in Simba then we will no longer be supporting reflection 1 (though we will not be removing it completely from GitHub or anything).

Any comments or concerns let me know! We will be changing over within the next 1-2 days, giving a little bit of time for the reflection 1 scripts to move on over.

Today's changelog:

*Changed the way we get animations and removed the Characters.simba file.
*Added R_ClickTab(1) to each withdraw function so it always searches the first tab.
*Added an additional wait in R_ScrollToIndex in hopes of fixing issues when withdrawing during lag.
*Editted PathMaker.simba to print properly with reflection 2.
*Removed R_InvertTileArray, just use InvertTPA built into Simba.
*Added more waits to R_WalkPath to hopefully help with accuracy and CPU usage.

I did add some waits and stuff into R_WalkPath but I can't tell if it helps CPU performance because mine never fluctuated beyond 1-2% usage. If someone who was having issues with that before or has a crappy computer can test, that would be great! Also ggzz, test out the withdrawing now and see if it works for you. Let me know if you guys need anything else!

Awesome news. I'm gonna get the latest in the morning. CBA to stop my scripts at this moment in time. ;) Great job Reflection team!

IMO you should change title, made me think this was the full ready release… but great work.

From: Harry
IMO you should change title, made me think this was the full ready release… but great work.

It is the full ready release, the only thing is Wizzup would like a grace period for those who have not switched their scripts to reflection 2 :P So technically what we have now is the full release but we just haven't switched the extension yet :P

EDIT: Changed the name a bit :P

Well done :) happy happy joy joy haha. I will test it out now ;)

Thanks :) I'll be home around 6PM US Central time tonight, going to work now. If you have any problems let me know!

Ok well I'm off out for the night. From what I've seen which ain't been for long, its good so far. I will check it with the another script later which had high cpu before and see the outcome of that.

"*Added R_ClickTab(1) to each withdraw function so it always searches the first tab."

:< I don't like that. Any way you can have withdraw functions that don't call R_ClickTab(1)?

From: i luffs yeww
"*Added R_ClickTab(1) to each withdraw function so it always searches the first tab."

:< I don't like that. Any way you can have withdraw functions that don't call R_ClickTab(1)?

Why? If you don't start on the right tab, withdrawing won't work correctly.(I'm curious to know why you want it, I may put in the old FirstTab:boolean).

Because there may be times when you know what tab it's in, which would make searching for it much easier. I'd rather me be able to tell it to search in the first tab if I want it to. I very rarely ever search through the first tab myself, it's just all my general stuff and is very messy.

And I don't like when functions/procedures do too much extra. I want InPin to input my bank pin, I want OpenBank to open my bank, and I want Withdraw functions to search and withdraw. I'll tell it to go to the first tab if I want it to.

The current withrawing procedures don't search specific tabs, instead they start at the first tab and scroll to the item.

I don't like that. ;< It's disallowing me to be able to use the function to suit my needs. At the very least I'd prefer for there to be a R_WithdrawEx or something that doesn't change the tab, and then R_Withdraw is simply R_ClickTab(1); R_WithdrawEx(whatever);. That way I at least have the option to search the current tab.

From: i luffs yeww
I don't like that. ;< It's disallowing me to be able to use the function to suit my needs. At the very least I'd prefer for there to be a R_WithdrawEx or something that doesn't change the tab, and then R_Withdraw is simply R_ClickTab(1); R_WithdrawEx(whatever);. That way I at least have the option to search the current tab.

Ok that's fine. I'll add that in.

Would love for someone to quickly convert MSI to R2 and send a pull request. I don't have time now and may not for a couple days.

I'm committing a better fix…

Naice.

It's great that you guys got this all working so quickly and efficiently, I'm sorry that I didn't have enough time to help out as much as I thought I would.

From: i luffs yeww
I don't like that. ;< It's disallowing me to be able to use the function to suit my needs. At the very least I'd prefer for there to be a R_WithdrawEx or something that doesn't change the tab, and then R_Withdraw is simply R_ClickTab(1); R_WithdrawEx(whatever);. That way I at least have the option to search the current tab.

It's all good, I committed a fix to allow you to do this. You switch to whatever tab you want, and if the item isn't in your current tab then it switches to the main tab by default. Mormonman almost hit it on the head but this works.

EDIT: @Coh3n: All MSI uses is walking right?

From: Drakan
EDIT: @Coh3n: All MSI uses is walking right?

Yep. Pretty sure all you'd need to do is try to compile MSI with R2 and fix the compiling errors. There really should only be a few.

From: Drakan
It's all good, I committed a fix to allow you to do this. You switch to whatever tab you want, and if the item isn't in your current tab then it switches to the main tab by default.

Thank Gawd! This behavior in Reflection1 drives me nuts! You get it all lined up to exactly where you want it in the bank, then the withdraw function changes the tab and breaks itself.

From: Bixby Sayz
Thank Gawd! This behavior in Reflection1 drives me nuts! You get it all lined up to exactly where you want it in the bank, then the withdraw function changes the tab and breaks itself.

;) This is exactly what mormonman and I talked about on MSN.

Yes, for most cases, that will be just fine. But I want library functions to do simply as they say they do. Withdraw will withdraw, banking will bank, and clicking will click. If I want it to change tabs, click a certain way, or the like, I'll give it that functionality (probably with other library features).

jQuery is a good example of this. .hide() hides, .show() shows, and .width() returns the width. Just as it should. :)

theres nothing wrong with scrolling to the item or changing tabs as a failsafe. Besides more people want that functionality than dont :p

From: Drakan
theres nothing wrong with scrolling to the item or changing tabs as a failsafe. Besides more people want that functionality than dont :p

Yep. Before this was added I put BankTab(1) (or whatever it is) before I search the bank for an item, so it always starts at the top. Glad this is added now.

From: Drakan
theres nothing wrong with scrolling to the item or changing tabs as a failsafe. Besides more people want that functionality than dont :p

There is nothing wrong with this behavior, but in my own scripts where I know the bank is already positioned to the correct tab (ie the 2nd time banking) always clicking back to tab 1 looks anything but human (which you have to do because the calculate item slot fails miserably if tab <> 1) [At least in reflection 1, haven't done any banking with reflection2 yet].

Having the option to not do this is a good thing.

From: Bixby Sayz
There is nothing wrong with this behavior, but in my own scripts where I know the bank is already positioned to the correct tab (ie the 2nd time banking) always clicking back to tab 1 looks anything but human (which you have to do because the calculate item slot fails miserably if tab <> 1) [At least in reflection 1, haven't done any banking with reflection2 yet].

Having the option to not do this is a good thing.

reflection 2's banking is completely different than reflection 1. But yes I understand that, and it works like stated now :)

:c The Item withdrawing works fine now.. Only problem is that no matter what, it never clicks tab 1 if the item isn't on screen.. I'd prefer if it went directly to the item's tab rather than tab 1 though. I also dunno what changed but the banking now waits a whole 4-5 seconds before withdrawing an item after depositing. Also waits the same length of time between withdrawing two items..

Also another bug is that if the withdrawing fails, and your already at the bankbooth, it will walk away from it then walk back :S Might be a bug in my script but Iunno I'll check again cuz it only happens at castlewars.

Reflection 1 banking was based around a different bank interface that no longer works.