SRL Archive - General

Today I started doing some maintenance on the include. As I did one thing, I noticed another and another and so on. I ended up making quite a few changes, all for the better in my opinion. I've pushed all the changes to a "maintenance" branch on my repository and will continue to change things/test for another day or so.

I'm posting here to make sure everyone agrees with the changes + to point out anything that should be changed. The branch can be found here. Also, as you can imagine, making these changes has let me to find a couple bugs. I wish I had fixed them on the main branch rather than this one, but it'll all get merged later.

All the changes so far:

Objects: removed MSI_FilterTPADist as it's now in Simba
Manipulation: Removed MSI_RemovePointsInBox as it isn't used
Manipulation: Removed MSI_DeletePointInTPA as it's in SRL
Skills: RandomizeArray, ChooseObject, & RearrangeArray moved to Manipulation.simba
Skills: MSI_CB_DoAllScreen moved to Materials.simba
Materials: MSI_CB_DoAllScreen changed to MSI_MaterialScreen
Manipulation: ChooseObject renamed to ChooseInteger
Manipulation: Removed IntToStrArr and StrToIntArr as they're unused
Manipulation: Added documentation for tile conversion methods
Manipulation: Removed SumTIA as there is SumIntegerArray in Simba
Banking: Will withdraw X amount if option already exists
Fishing: Got rid of the stupid forceFail parameter that wasn't necessary
Skills: Applied changes from Fishing.simba to MSI_AutoInvFull
Skills: SetSkillLevels exits if the script's skill equals SKILL_NONE
Fishing: Fixed waitWhileFishing to work with new MSI_MakeBox
Skills: Fixed access violation
Fishing: Fixed compiling error
Mainloop: Powerskilling doesn't always return true anymore
Objects: Updated Rocks/FishSpots w/h to compensate for new makeBox
Obstacles: Fixed CG_DOOR_IN MirObjArea
Setup: Removed reflection debugging define

Also, you'll notice how I made my commits: short and separated. Ideally, everyone will commit like this, so try to make a mental note to do it this way. Yes, I copied it from Simba. :p

And yes, I realize that NCDS is probably the only one that this will effect, but oh well.

Cheers,
Cohen

From: Coh3n

And yes, I realize that NCDS is probably the only one that this will effect, but oh well.

:p

Everything looks good!

Are you planing to continue the 'maintenance' in a separate branch or just begin to make changes to the main branch like normal? If so, I'll just fork your maintenance branch.

Nice find with the Access violation errors too. :)

From: NCDS
Are you planing to continue the 'maintenance' in a separate branch or just begin to make changes to the main branch like normal? If so, I'll just fork your maintenance branch.

I'm going to continue in the maintenance branch. I don't think you can fork just the branch. You have to create your own branch, then pull from my maintenance branch.

From: NCDS

Nice find with the Access violation errors too. :)

It was actually something I created while making the maintenance changes. :p

The Crafting Guild Miner has been running great today, plus the few loads I did with Fishing went well. So everything looks good so far.

E: I'm actually probably going to move Skills.simba to Core/Skills and rename it Common.simba, and MSI_SetSkillLevels to Mainloop.simba. After that I'll just push to the main repository.

E: http://villavu.com/forum/showthread.php?p=825351#post825351