SRL Archive - MSI Bugs

I have used the clay softener for awhile, and the main problem appears to be that it can't find the clay in the bank sometimes. I let it run, and sometimes it runs well over an hour without this error, sometimes it occurs on the 4th trip. This is pretty annoying because I have to check it a lot.

Another minor thing is that I think it lacks failsafes. For example, it sometimes doesn't manage to withdraw clay on the first try because I expanded SMART. It doesn't try to withdraw clay again after that, and shuts itself down.

From: litoris
I have used the clay softener for awhile, and the main problem appears to be that it can't find the clay in the bank sometimes. I let it run, and sometimes it runs well over an hour without this error, sometimes it occurs on the 4th trip. This is pretty annoying because I have to check it a lot.

Can you post some debug of this? I'm not sure why it would only find it sometimes, it's not like the text overlaps the item.

From: litoris

Another minor thing is that I think it lacks failsafes. For example, it sometimes doesn't manage to withdraw clay on the first try because I expanded SMART. It doesn't try to withdraw clay again after that, and shuts itself down.

Didn't realize until you just told me that there's no "tries" counter or timer for banking. For most things in MSI we use a loop to retry for a certain amount of time, and apparently this is excluded in banking. I'll fix this this afternoon, but if you could find some debug on your first problem, that would be great. :)

E: This failsafe has been added to my fork and is working great. It'll be added in the next update.

Sorry for the late response, my acc was banned :P

Status: /~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\
Status: |     SRL Randoms Report       |
Status: |       [url]www.villavu.com[/url]        |
Status: |~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~|
Status: \~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~/
{----------------------------------------------------------------}
{                    MSI Phoenix Short Report                    }
{----------------------------------------------------------------}
{     Time Running: 4 Minutes and 24 Seconds                     }
{----------------------------------------------------------------}
{                                                                }
{        Totals:                                                 }
{         - Players:           2                                 }
{         - Player Time:       59s                               }
{         - Randoms Solved:    0                                 }
{         - Randoms Failed:    0                                 }
{         - Loads:             2                                 }
{         - Clay Softened:     56                                }
{                                                                }
{----------------------------------------------------------------}
{----------------------------------------------------------------}

{----------------------------------------------------------------}
{                    MSI Phoenix Player Report                   }
{----------------------------------------------------------------}
{     Time Running: 4 Minutes and 24 Seconds                     }
{----------------------------------------------------------------}
{                                                                }
{     Player 0: *****                                       }
{     Location: Edgeville bank                                   }
{     Time:     59s                                              }
{     Active:   False                                            }
{       Reason: Ran out of supplies                              }
{                                                                }
{     Script: Edgeville Clay Softener                            }
{       Time:  59s                                               }
{       Loads: 2                                                 }
{         Item:   Soft Clay                                      }
{         Amount: 56                                             }
{                                                                }
{----------------------------------------------------------------}
{----------------------------------------------------------------}
[00:04:30]: [ **** ] ------ All players inactive
[00:04:30]: Thank-you for using MSI Phoenix scripts!
[00:04:30]: Successfully executed.

I have seen it try to bank again when it didn't manage to open the bank screen(so your edit works), but this happened with over 24k clay in my bank, at the very top.

Edit: I also saw that it clicks right to the middle of the soft clay sign when making it, should try mousebox or something there.

From: litoris
Sorry for the late response, my acc was banned :P

From using MSI? :(

From: litoris

I have seen it try to bank again when it didn't manage to open the bank screen(so your edit works), but this happened with over 24k clay in my bank, at the very top.

DTM may be being covered by text, could you try with a different amount in your bank?

From: litoris

Edit: I also saw that it clicks right to the middle of the soft clay sign when making it, should try mousebox or something there.

It doesn't click the exact middle, and there is randomness to it, but I suppose more could be added.

From: Coh3n
From using MSI? :(

Nah, some other mining script. I got a lot more xp than a human could even though I made lots of breaks, and simba lagged sometimes and made me say my username and pass as if I was logging in 2-3 times. It also logged out after about 5 randoms in a row, so yeah.

From: Coh3n
DTM may be being covered by text, could you try with a different amount in your bank?

I tried it with 100. When I was doing it with 20k, sometimes the script worked for more than an hour, sometimes half an hour before the error came up. With 100, it stopped at the 3rd load once(I did 100 like 10 times).

From: Coh3n
It doesn't click the exact middle, and there is randomness to it, but I suppose more could be added.

The mouse hovers to a random location in the box and then clicks the middle, as far as I have seen.

From: litoris
Nah, some other mining script. I got a lot more xp than a human could even though I made lots of breaks, and simba lagged sometimes and made me say my username and pass as if I was logging in 2-3 times. It also logged out after about 5 randoms in a row, so yeah.


I tried it with 100. When I was doing it with 20k, sometimes the script worked for more than an hour, sometimes half an hour before the error came up. With 100, it stopped at the 3rd load once(I did 100 like 10 times).

Alright, I'll remake the DTM, hopefully that will help. :) E: Actually, the text doesn't even touch the item, so that shouldn't be the problem. Could you post the debug?

From: litoris

The mouse hovers to a random location in the box and then clicks the middle, as far as I have seen.

I'll check it out. E: Fixed in the latest version.

http://pastebin.com/UmAgVHgg
^The one I gave you on the IRC
http://pastebin.com/nN1BrBei
^This one just happened, first time I got an error like this.

From: litoris
http://pastebin.com/UmAgVHgg
^The one I gave you on the IRC
http://pastebin.com/nN1BrBei
^This one just happened, first time I got an error like this.

Both are resulting from the same error, unfortunately, I have absolutely no idea why it's happening. Could you do me a favour and rerun it after adding this line to MSI_Withdraw?

MSI_Debug('Found '+toStr(length(p)));

Open Banking.simba (Includes/MSI/MSI/Core/Banking.simba) and add it after line 467 (filterTPADist(p, 20);).

This is a really weird bug, but please post the debug when it happens again. Hopefully that will help.

Did what you said and got the debug:
http://pastebin.com/v9JjkFcx

From: litoris
Did what you said and got the debug:
http://pastebin.com/v9JjkFcx

I'm not sure you did it right. The line I added should be written no matter what, and it wasn't written. Did you save the file after you changed it?

E: I have an idea of how to recreate the issue, hopefully it works. I have about 150k clay to soften on my army so let's hope I can find the issue. :p

E2: Mine's been running for 2 hours and no problems yet. Do you have the latest version of Simba? I don't think this would matter, but you never know.

E3: Stopped manually, all players still active.

{----------------------------------------------------------------}
{                    MSI Phoenix Short Report                    }
{----------------------------------------------------------------}
{     Time Running: 3 Hours, 31 Minutes and 34 Seconds           }
{----------------------------------------------------------------}
{                                                                }
{        Totals:                                                 }
{         - Players:           8                                 }
{         - Player Time:       03h 23m 59s                       }
{         - Randoms Solved:    0                                 }
{         - Randoms Failed:    0                                 }
{         - Loads:             172                               }
{         - Clay Softened:     4,816                             }
{                                                                }
{----------------------------------------------------------------}
{----------------------------------------------------------------}

O.O
…I updated MSI when I opened the script, and that deleted the line. I don't get why this doesn't happen to you though.

I thought it could be a problem on my side, that's why I told you to test it yourself, lol.
Getting another debug now.

From: litoris
O.O
…I updated MSI when I opened the script, and that deleted the line. I don't get why this doesn't happen to you though.

I thought it could be a problem on my side, that's why I told you to test it yourself, lol.
Getting another debug now.

According to the debugs you've posted so far, it's finding the Clay in the bank, but for whatever reason it's not moving the mouse to it. That's why I asked you to add that debug line to see if there was a bug in filterTPADist. I was thinking it was removing the only point if there was only one found.

But yeah, I'm not sure why it doesn't work for you. Have you tried multiplayer as well? I don't see why that would make a difference but you never know.

Can't you just make it so that it checks again if it can't find clay in bank? Make it close bank screen and open again and such?

I'm sure more people would have this problem, it's just that I happen to be the only person using this :P

From: litoris
Can't you just make it so that it checks again if it can't find clay in bank? Make it close bank screen and open again and such?

I'm sure more people would have this problem, it's just that I happen to be the only person using this :P

If you look at the stats, you haven't been the only one to use it. ;) I'm not going to make it close and re-open the bank because that's really unnecessary. I'm going to commit an update with more debugging, so wait for that and then post the debug when it happens again. I can't for the life of me figure out why this is happening.

E: I've added a failsafe, but I don't think it will fix your issue. As I have two instances of this running on 8 players each and they're both still going string after 28 hours each, I'm marking this as resolved until I hear otherwise.

I seem to have the same problem, after a random amount of time it no longer finds the items in the bank.

I added some code to reopen the bank but from the debug it seems that it still failed after reopening over 3 times in a row even though it had just done 18 loads. Straaange. My friend tried it out and had exactly the same problem (I have had the problem in Varrock east and falador west bank).

Edit: I remade the DTM for vials and it seems to work fine now.

From: thekilar
I seem to have the same problem, after a random amount of time it no longer finds the items in the bank.

I added some code to reopen the bank but from the debug it seems that it still failed after reopening over 3 times in a row even though it had just done 18 loads. Straaange. My friend tried it out and had exactly the same problem (I have had the problem in Varrock east and falador west bank).

Edit: I remade the DTM for vials and it seems to work fine now.

Can you post your new DTM or send a pull request?

Don't know how to send a pull request (never been into git) so here's the DTM :

VIAL_EMPTY:
      Result := [
                  Point(580, 234),
                  Point(580, 243),
                  Point(585, 232),
                  Point(569, 239),
                  Point(586, 240)
                ];
//Color:

VIAL_EMPTY  : Result := 5788756; 

I had to seperate VIAL_EMPTY and VIAL_WATER since I didn't use the same center point as you (silly me).

Thanks, this should be fixed in the latest version.