SRL Archive - Reflection

Mr. Smith is a Varrock West anvil everything smither. I don't believe there is a functioning everything smither available to junior members so I decided to make one. This script is mostly color, I only used reflection for a couple procedures. Have your player in the Varrock West Bank with nothing in his inventory unless its a hammer(have hammers and bars in visible areas of your bankscreen, not in a tab)

Pros
- Anti-Randoms(Color and Reflection).
- Reflection Walking(between bank and anvil).
- Fail safes.
- Item finding using DTMs.
- Accurate anvil clicking(reflection).
- Stable(Ran it before bed and smithed over 5k hatchets).
- basic progress report.
- straightforward setup.
- Supports All bars.

Cons
- Currently no Anti-Ban (Soon to be changed, Auto-talker, level checker .ETC.)
- Only supports certain items at the moment(Soon to be everything).
- Not a lot of randomness on the mini map clicking.

Smith-able Items
*Daggers
*Mace's
*Med Helmets
*Short Swords
*Scimitars
*Sq Shields
*Full Helmets
*Hatchets
*Battle Axes
*War Hammers

I have been busy lately so it has been hard for me to get everything I want in this script done (AntiBan, More randomness, Faster item finding, more failsafes .ETC.) but I will be updating it when I get the time. What I give to you right now is a stable script that works pretty efficiently.





Thanks,

-Insane

I will try this out as soon as you get anti-ban implemented. Especially since I have been looking for one of these, this would be used on my main, so I need to be extra safe. But thanks for your contribution to Public scripts =)

Skimming through the code..just wondering why this is reflection if your script is mainly color, it seems as the only thing you used reflection was for the Anvil[which could be done with FindObjCustom, FindObjTPA, Findcolor, etc.], and the walking which is understandable..I guess. Also, in you're DeclareMetal/bar/smith functions, you don't need all those if..then statement…..

Example:

procedure DeclareMetalColors;
begin
  if TypeOfMetal = ('Bronze') then MetalColor := 1649465;
  if TypeOfMetal = ('Iron') then MetalColor := 2302756;
  if TypeOfMetal = ('Steel') then MetalColor := 7566457;
  if TypeOfMetal = ('Mithril') then MetalColor := 6373696;
  if TypeOfMetal = ('Adamant') then MetalColor := 2040863;
  if TypeOfMetal = ('Rune') then MetalColor := 6774607;
end;  

could be

Procedure DeclareMetalColors;
begin
  case TypeOfMetal of
   'Bronze': MetalColor := 1649465; //and so forth for the rest of the metals,etc.
//could be shortened even more if you use a Function with an integer result

Also..

function HammerInventory: boolean;//    *** Checks if Hammer is in your inventory ***
begin
  Result := false;
  if FindDtm(HammerDtm, x, y, MIX1, MIY1, MIX2, MIY2) then Result := True;
end; 

could be easily shortened to:

function HammerInventory: boolean;//    *** Checks if Hammer is in your inventory ***
begin
  Result := FindDtm(HammerDtm, x, y, MIX1, MIY1, MIX2, MIY2);
end; 

Also, you should know something like this isn't required:

function CheckAnvil: boolean; //    *** Checks too see if smith screen is open ***
begin
  if FindColorTolerance(x, y, 459604, 162, 33, 197, 58, 5) then
  Result := True;
  if not FindColorTolerance(x, y, 459604, 162, 33, 197, 58, 5) then
  Result := False;
end;  

And can be easily turned into:

function CheckAnvil: boolean; //    *** Checks too see if smith screen is open ***
begin
  Result := FindColorTolerance(x, y, 459604, 162, 33, 197, 58, 5);
end;  

I also see that in a lot of the functions in your script you use:

 if HammerInventory = false then  

That's okay, but it doesn't show much knowledge of the various statements within Simba, but if you didn't know it can be easily

if not HammerInventory then //same thing as if HammerInventory = false

or

 if HammerInventory then //means if HammerInventory = true

Any ways, there's a bit more I could highlight[such as standards[although it is not necessary]], however I'd just like to say congratz on this nice and simple script, it is good see more people actively scripting! :)

E- Don't forget to put anti ban, it isn't very hard to do. :

First I suggest adding support for these:

http://runescape.wikia.com/wiki/Golden_hammer

http://runescape.wikia.com/wiki/Sacred_clay_hammer

mostly just the first one.. but it shouldn't be too hard to add both

Definitely add an anti-ban in there

[banana]** Smithed around 405 Bars into Mithril full helms
** Ran for 17 Minutes and 2 Seconds[/banana]

counter is incorrect, it looks like it counted bars that it didn't smith which were left over in the inventory, could be fixed by counting how many of the item that was made * the number of bars it takes to make it

script looks promising though, keep going with it

could you turn this into 100% color now please?

Looks awsome!

I will update this to color once I get some time, the only thing I have to change is the anvil finding, and the walking, shouldn't be to difficult

From: insanomano
I will update this to color once I get some time, the only thing I have to change is the anvil finding, and the walking, shouldn't be to difficult

That would be awesome, there are too many bar makers out there. :S At least feels like it. I might go for smithing 99 is this gets updated and I find it smooth. :)