SRL Archive - SRL Bugs

Flag.scar


noidea

2011-06-06 23:48:06

Yea, so flag wasnt working, so I tried findcolor(flagcolor….etc) and apparently flagcolor isnt there anymore?

Any one else having this issue? I havent heard anyone else complain about it and everyone's scripts seem to work?

jerryt

2011-06-06 23:53:09

Use the function FlagPresent: Boolean;. That will tell you if the flag is present on the map.

noidea

2011-06-07 00:01:45

I already did and it does the exact same thing as what I did, Result := FindColor(x, y, FlagColor, MMX1, MMY1, MMX2, MMY2);

And of course, that isnt going to work, unless it finds the colour flagcolor.

Edit: it looks like colour 217 is a constant colour on the flag. Idk if its on anything else in rs, but for flagging, it seems to work.

jerryt

2011-06-07 08:28:01

Are saying that most of the colors on the flag are (217, 0, 0)? I'll take a look at the include and see if there needs to be a quick change.

Nava2

2011-06-07 08:41:14

From: noidea
I already did and it does the exact same thing as what I did, Result := FindColor(x, y, FlagColor, MMX1, MMY1, MMX2, MMY2);

And of course, that isnt going to work, unless it finds the colour flagcolor.

Edit: it looks like colour 217 is a constant colour on the flag. Idk if its on anything else in rs, but for flagging, it seems to work.


The only thing that really needs to be checked is the Red drop dots. :)

Otherwise, we can just change the constant and move on. Thanks for the help noidea and jerryt

noidea

2011-06-08 14:26:09

Just as a heads up, this affects functions like mff which iirc radialwalk and related functions use. This could break a lot of scripts if not fixed.

Coh3n

2011-06-08 16:50:00

From: noidea
Just as a heads up, this affects functions like mff which iirc radialwalk and related functions use. This could break a lot of scripts if not fixed.

I'll commit a fix as soon as I can. No one has complained because there are hardly any color scripts anymore.

WT-Fakawi

2011-06-08 16:53:37

I can tell you first hand that HLR has no issues with either Flag, Flagpresent or FFlag?? Works as expected.

Coh3n

2011-06-08 17:00:51

Hm, noidea, where were you testing?

noidea

2011-06-08 17:02:55

From: WT-Fakawi
I can tell you first hand that HLR has no issues with either Flag, Flagpresent or FFlag?? Works as expected.


I have had a slew of problems. FlagColor no longer exists on the flag. I changed the colour to 217 and it seems to work nicely now.

Flag relies on FFlag, FFlag relies on Flagpresent, and Flagpresent is just a findcolor() of FlagColor. So idk how it hasnt been affecting you.

Can anyone else confirm my problem or is it working for you guys like fakawi?

Coh3n

2011-06-08 17:08:08

From: noidea
I have had a slew of problems. FlagColor no longer exists on the flag. I changed the colour to 217 and it seems to work nicely now.

Flag relies on FFlag, FFlag relies on Flagpresent, and Flagpresent is just a findcolor() of FlagColor. So idk how it hasnt been affecting you.

Can anyone else confirm my problem or is it working for you guys like fakawi?

I've used MSI a lot (and so have many others), and flag is used in more than just the walking, and it seems to be working fine. Nothing's been reported anyway. Are you sure you graphics are set properly?

noidea

2011-06-08 17:22:29

Yea I think so. I ran fixgraphics() and that didnt do anything to the settings.

edit wait a sec need to fix image.
http://i.imgur.com/jjXyX.jpg

MylesMadness

2011-06-08 17:27:29

From: noidea
Yea I think so. I ran fixgraphics() and that didnt do anything to the settings.

edit wait a sec need to fix image.
http://i.imgur.com/jjXyX.jpg
That's not safemode. Not sure if thats the issue, but I've always ran in safemode

noidea

2011-06-08 17:29:19

From: MylesMadness
That's not safemode. Not sure if thats the issue, but I've always ran in safemode


heh, then thats probably the issue. smart forces it into safe mode right?

Shuttleu

2011-06-08 17:33:31

From: noidea
heh, then thats probably the issue. smart forces it into safe mode right?


yup, and there are other color differences in safe mode, for example the mm is lighter

~shut

noidea

2011-06-08 17:50:19

From: Shuttleu
yup, and there are other color differences in safe mode, for example the mm is lighter

~shut


Thanks guys. Everything works perfectly. Just that damn safemode…

Coh3n

2011-06-08 19:06:19

May not be a bad idea to have a check for that in FixGraphics..

MylesMadness

2011-06-08 19:24:09

From: noidea
Thanks guys. Everything works perfectly. Just that damn safemode…
If you hit "s" while runescape is loading, safemode will load. Just a FYI

noidea

2011-06-08 21:01:05

From: MylesMadness
If you hit "s" while runescape is loading, safemode will load. Just a FYI


Thanks.