SRL Archive - Simba Tasks

[DONE] [Medium] Fix colour picker bug


Wizzup?

2011-06-02 09:09:37

In Simba, we have a function for the colour picker. If you press the colour picker button it will bring a fullscreen window with a copy of the current screen. On Linux (and perhaps on Windows too) you can alt+tab out of this ``fullscreen'' window and press the button again. This will bring up another fullscreen window. If you then pick a colour, Simba will crash.

This can easily be prevented by not allowing the pick action to be executed when there is already a ``pick'' active.

Additionally, it may be cool to add a ``Pick Colour'' option to the Simba tray icon.

https://github.com/MerlijnWajer/Simba/blob/master/Projects/Simba/simbaunit.pas#L2826

You'll probably just have to add a Boolean PickingColour := True; and the check If PickingColour then exit; or something like that.
Or you could turn it into a TAction and make it a bit more pretty.

Dgby714

2011-06-02 11:12:53

From: Wizzup?
You'll probably just have to add a Boolean PickingColour := True; and the check If PickingColour then exit; or something like that.
Or you could turn it into a TAction and make it a bit more pretty.


Check, if true, Focus old full screen and Exit.

We could also go the route of removing the old color pick and starting another one.

Wizzup?

2011-06-02 13:13:38

I think it's better to just not start an other picker. Closing the old one may be a bit messy.

Daniel

2011-06-03 01:45:36

Or why not when the person tries to get back into Simba, then the colour picking window will remain on top, disabling the user from clicking/hot-keying the button again? :S

Wizzup?

2011-06-05 07:06:16

From: Daniel
Or why not when the person tries to get back into Simba, then the colour picking window will remain on top, disabling the user from clicking/hot-keying the button again? :S


You forget that there is also Ctrl+Alt+P. Plus, there simply is no way to ensure the user cannot access the Simba form unless we completely disable the form until the colour picking is done. I'm pretty sure that will lead to other issues.

Waddo

2011-07-20 15:42:33

I assume CTRL+p just runs the same function as pressing the button,
at the start of the function just make it check whether the colour picker window is already open, and if so bring to the front else do what it normally does.

Wizzup?

2011-07-22 07:55:11

I've fixed this in 297ea2a, it'll be in simba-0.97-rc4.

Home

2011-07-22 08:07:58

From: Wizzup?
I've fixed this in 297ea2a, it'll be in simba-0.97-rc4.


I thought that was fixed already?
Was there some kind of similar bug in the past?


~Home

Wizzup?

2011-07-23 08:08:20

From: Home
I thought that was fixed already?
Was there some kind of similar bug in the past?


~Home


There was another bug, but that would bring up ``black screens'', this is simple about creating another picking whilst the previous wasn't finished ``picking'' yet. This caused a crash. :)