Coh3n
2011-05-25 15:03:21
Just committed the fix for logging in, was wondering if anyone knows of anything else that was broken from today's update.
Cheers,
The SRL Dev Team
Cheers,
The SRL Dev Team
SRL Archive - SRL Bugs
Login as of May 25th, 2011
Floor66
2011-05-25 15:53:15
Banking in draynor.
Coh3n
2011-05-25 15:55:49
From: Floor66
Banking in draynor.
Oh right, forgot SRL had bank opening methods. I'll get to that as soon as possible if no one else does.
NCDS
2011-05-25 16:09:56
From: Coh3n
Oh right, forgot SRL had bank opening methods. I'll get to that as soon as possible if no one else does.
I can help out with that, I just got home from work so give me a little while and I'll get on it.
What function does it not work with? OpenBankFast/Glass/etc.? I can fix it quick, but I don't have time atm to go through everything, though I can later on.
Coh3n
2011-05-25 16:30:17
From: NCDS
I can help out with that, I just got home from work so give me a little while and I'll get on it.
What function does it not work with? OpenBankFast/Glass/etc.? I can fix it quick, but I don't have time atm to go through everything, though I can later on.
From the pictures I've seen, there are no longer bank booths, but bank tables. So, Glass wouldn't work since there is no class. I'm not sure about Fast. Using the banker may still work, but I'm guessing the colors will need updating.
mika
2011-05-25 17:02:51
Drayanor looks pretty nice now but as said no more bank booths there are counters now and options are use counter and use counter quickly
Coh3n
2011-05-25 17:06:08
From: mika
Drayanor looks pretty nice now but as said no more bank booths there are counters now and options are use counter and use counter quickly
Were all the trees updated like the ones around Rimmington?
NCDS
2011-05-25 17:15:14
From: Coh3n
From the pictures I've seen, there are no longer bank booths, but bank tables. So, Glass wouldn't work since there is no class. I'm not sure about Fast. Using the banker may still work, but I'm guessing the colors will need updating.
OpenBankFast is just a color search so I can change it to search for the tables. I'm pretty sure it searches for only the UpText 'ooth' right now, but I can add a conditional for Bank_DB to accommodate that.
Coh3n
2011-05-25 17:40:16
From: NCDS
OpenBankFast is just a color search so I can change it to search for the tables. I'm pretty sure it searches for only the UpText 'ooth' right now, but I can add a conditional for Bank_DB to accommodate that.
That may be the only option, yeah.
NCDS
2011-05-25 19:15:48
Index: bank.scar
===================================================================
--- bank.scar (revision 748)
+++ bank.scar (working copy)
@@ -1,6 +1,6 @@
-//-----------------------------------------------------------------//
+ //-----------------------------------------------------------------//
//-- Scar Standard Resource Library --//
-//-- » Bank Routines --//
+//-- ? Bank Routines --//
//-----------------------------------------------------------------//
// * function BankScreen: Boolean; // * by SRL Dev Team
// * function DepositScreen: Boolean; // * by Shuttleu
@@ -495,7 +495,7 @@
end;
if (SlotFrom = 1) and (SlotTo = 28) and (All = true) then
if DepositAll then
- exit;
+ exit;
for I := SlotFrom to SlotTo do
begin
if (BScreen) then
@@ -972,7 +972,9 @@
'vwb', 'varrock west': Info := [MSCX, MSCY, 3037545, 5, 0.41, 1.32, 100, False, 10, 10]; // Fixed 12/7, #40
'feb', 'falador east': Info := [MSCX, MSCY + 50, 5008519, 10, 0.22, 0.67, 100, False, 10, 10]; // Fixed 12/7, #40
'fwb', 'falador west': Info := [MSCX, MSCY + 50, 5074569, 15, 0.22, 0.67, 50, False, 10, 10]; // Fixed 12/7, #40
- 'db', 'draynor': Info := [MSCX - 50, MSCY, 5527389, 7, 0.20, 0.20, 10, False, 5, 10]; // Fixed 12/7, #40
+ 'db', 'draynor': begin {$Define Dray}
+ Info := [MSCX - 50, MSCY, 5136741, 5, 0.73, 0.49, 15, False, 10, 10]; // Fixed 12/7, #40
+ end;
'eb', 'edgeville bank': Info := [MSCX + 20, MSCY, 3561835, 20, 0.32, 0.61, 50, False, 10, 10]; // Fixed 12/7, #40
'ctb', 'catherby bank': Info := [MSCX, MSCY, 3239049, 8, 0.20, 0.20, 100, False, 10, 10];
'clt', 'camelot bank': Info := [MSCX, MSCY, 7636882, 5, 0.20, 0.20, 100, False, 10, 10];
@@ -1019,21 +1021,25 @@
B := GetTPABounds(ABooths[i]);
If ((B.X2 - B.X1) < Info[8]) Or ((B.Y2 - B.Y1) < Info[9]) Then
Continue;
-
+
Inc(bo);
SetArrayLength(Booths, bo);
Booths[bo-1] := MiddleTPA(ABooths[i]);
-
+
end;
-
+
SortTPAFrom(Booths, Point(Info[0], Info[1]));
-
+
l := GetArrayLength(Booths) -1;
for i := 0 to l do
begin
-
+
MMouse(Booths[i].X, Booths[i].Y, 3, 3);
- if WaitUpTextMulti(['ooth', 'Bo', 'ot'], 1000) Then
+ {$IfDef Dray}
+ if WaitUpTextMulti(['ount', 'unte', 'oun', 'unter'], 1000) then
+ {$Else}
+ if WaitUpTextMulti(['ooth', 'Bo', 'ot'], 1000) Then
+ {$EndIf}
begin
GetMousePos(Booths[i].X, Booths[i].Y);
Mouse(Booths[i].X, Booths[i].Y, 0, 0, False);
@@ -1120,7 +1126,7 @@
Result := True;
Exit;
end;
-
+
for I := 0 to 3 do
begin
case I of
@@ -1129,7 +1135,7 @@
2: Result := OpenBankQuiet(WhichBank);
3: Result := OpenBankNPC;
end;
-
+
if Result then
Exit;
end;
There's the patch for the OpenBankFast fix. As you can see I just used a define to handle the different UpText's. After gather colors I tested on 3 different worlds from different areas of the bank and it worked each time, so we should be set.
Coh3n
2011-05-25 21:02:52
I'm pretty sure defines don't work that way. They're compiler derivatives meaning they're looked for when the script compiles. You can't do a a define in an if statement. Why don't you just do if (bank = 'db') then?
Harry
2011-05-25 21:19:37
Your login fix works, but clicks inaccurately (when it logs in it clicks the username/password box), but now it clicks a bit too low.
Flight
2011-05-25 21:37:34
Ok well this part won't work for Draynor: "if WaitUpTextMulti(['ooth', 'Bo', 'ot'], 1000) Then"
Take a look at this:
Take a look at this:
NCDS
2011-05-25 22:59:16
From: Coh3n
I'm pretty sure defines don't work that way. They're compiler derivatives meaning they're looked for when the script compiles. You can't do a a define in an if statement. Why don't you just do if (bank = 'db') then?
But it did work. :confused:
You could just do an if..then, but it's going to be sloppier code is all.
@Flight, check the code…
Edit: Nvm, thought of a way to do it and keep things clean, give me just a minute.
E2:
Index: bank.scar
===================================================================
--- bank.scar (revision 748)
+++ bank.scar (working copy)
@@ -1,6 +1,6 @@
-//-----------------------------------------------------------------//
+ //-----------------------------------------------------------------//
//-- Scar Standard Resource Library --//
-//-- » Bank Routines --//
+//-- ? Bank Routines --//
//-----------------------------------------------------------------//
// * function BankScreen: Boolean; // * by SRL Dev Team
// * function DepositScreen: Boolean; // * by Shuttleu
@@ -495,7 +495,7 @@
end;
if (SlotFrom = 1) and (SlotTo = 28) and (All = true) then
if DepositAll then
- exit;
+ exit;
for I := SlotFrom to SlotTo do
begin
if (BScreen) then
@@ -954,6 +954,7 @@
Info: TVariantArray;
Booths: TPointArray;
ABooths: T2DPointArray;
+ UpText: TStringArray;
B: TBox;
begin
result := false;
@@ -964,6 +965,7 @@
Result := True;
Exit;
end;
+ UpText := ['ooth', 'Bo', 'ot'];
case LowerCase(Location) of { Sort X Sort Y Color Tol Hue Sat Count SplitTPA? W H }
'akb', 'al kharid': Info := [MSCX - 50, MSCY, 11196157, 20, 0.20, 1.15, 100, False, 10, 10]; // Fixed 12/7, #40
@@ -972,7 +974,9 @@
'vwb', 'varrock west': Info := [MSCX, MSCY, 3037545, 5, 0.41, 1.32, 100, False, 10, 10]; // Fixed 12/7, #40
'feb', 'falador east': Info := [MSCX, MSCY + 50, 5008519, 10, 0.22, 0.67, 100, False, 10, 10]; // Fixed 12/7, #40
'fwb', 'falador west': Info := [MSCX, MSCY + 50, 5074569, 15, 0.22, 0.67, 50, False, 10, 10]; // Fixed 12/7, #40
- 'db', 'draynor': Info := [MSCX - 50, MSCY, 5527389, 7, 0.20, 0.20, 10, False, 5, 10]; // Fixed 12/7, #40
+ 'db', 'draynor': begin UpText := ['ount', 'unte', 'oun', 'unter'];
+ Info := [MSCX - 50, MSCY, 5136741, 5, 0.73, 0.49, 15, False, 10, 10]; // Fixed 12/7, #40
+ end;
'eb', 'edgeville bank': Info := [MSCX + 20, MSCY, 3561835, 20, 0.32, 0.61, 50, False, 10, 10]; // Fixed 12/7, #40
'ctb', 'catherby bank': Info := [MSCX, MSCY, 3239049, 8, 0.20, 0.20, 100, False, 10, 10];
'clt', 'camelot bank': Info := [MSCX, MSCY, 7636882, 5, 0.20, 0.20, 100, False, 10, 10];
@@ -1019,21 +1023,21 @@
B := GetTPABounds(ABooths[i]);
If ((B.X2 - B.X1) < Info[8]) Or ((B.Y2 - B.Y1) < Info[9]) Then
Continue;
-
+
Inc(bo);
SetArrayLength(Booths, bo);
Booths[bo-1] := MiddleTPA(ABooths[i]);
-
+
end;
-
+
SortTPAFrom(Booths, Point(Info[0], Info[1]));
-
+
l := GetArrayLength(Booths) -1;
for i := 0 to l do
begin
-
+
MMouse(Booths[i].X, Booths[i].Y, 3, 3);
- if WaitUpTextMulti(['ooth', 'Bo', 'ot'], 1000) Then
+ if WaitUpTextMulti(UpText, 1000) Then
begin
GetMousePos(Booths[i].X, Booths[i].Y);
Mouse(Booths[i].X, Booths[i].Y, 0, 0, False);
@@ -1120,7 +1124,7 @@
Result := True;
Exit;
end;
-
+
for I := 0 to 3 do
begin
case I of
@@ -1129,7 +1133,7 @@
2: Result := OpenBankQuiet(WhichBank);
3: Result := OpenBankNPC;
end;
-
+
if Result then
Exit;
end;
Coh3n
2011-05-26 00:29:34
Thanks NCDS, I'll update now. And Harry, that may be because of the randomness; although I think it calls MouseBox. I'll see what I can do anyway, thanks.
E: Committed.
E: Committed.
NCDS
2011-05-26 11:49:35
MSI is all updated now as well.
tom99
2011-05-26 12:07:49
if you have already logged in, and you start another bot it will run the suggested server and give "to many connections from you're ip" then do nothing.
Coh3n
2011-05-26 12:13:16
From: tom99
if you have already logged in, and you start another bot it will run the suggested server and give "to many connections from you're ip" then do nothing.
I didn't change anything to do with that part. =\
Is this just recent because I've seen this happen several times and it goes and switches worlds.
Alaska
2011-05-27 22:21:28
From: tom99
if you have already logged in, and you start another bot it will run the suggested server and give "to many connections from you're ip" then do nothing.
Ever since the update I have been getting tons of errors even when only having one account logged on trying to play legit. If I try to switch worlds and login before the timer is done it will log me out completely of the lobby & I'll get "error connecting to server" or "account is already logged in", or the "too many connections from this IP". I have to reload the client if I want to log in again.
I even get those two errors when trying to log in the 1st time a lot as well. It's getting really fucking annoying. Messing up my botting and just normal playing. I never had these issues until Jagex added the Facebook log in update so I'm guessing it's something they've got to fix.