SRL Archive - Archive

<!– BEGIN TEMPLATE: formanswers –>
legendaryhero90 - SRL Member Application Form
legendaryhero90

What is the meaning to life?


Where you Referred to SRL? If yes, by whom?
no


Programming Knowledge
HTML, CSS, a little of PHP

Other Communitys
Sythe

How Long have You Played Runescape
4 or months

Are you affilated in anyway with Jagex LTD?
No
—————————————————–
Please write down a paragraph about Yourself.

I've been doing HTML and CSS for about a year now and have created a few sites using my knowledge in web programming. I'm not affilated with Jagex and I'm not an inside person. I've learned a lot using SRL and hope to use similar knowledge in my future careers. I've been on SRL for a while now trying to learn as much as i can. I am interested in Auto-fishing mainly on karamja island and wrote a script on it with a lot of my knowledge in SRL.

——————————————————
Please Post a Sample of your Work. Only SCAR Scripts Accepted

program legendaryfisher;
{.include srl/srl.scar}
{.include srl/srl/skill/Fishing.scar}

//Instructions//
{Make sure you have a lobster pot in the FIRST SLOT of your inventory
and/or money in your second slot if you wish.}



//vvvvvvvvvvvvvvvvvv-----------setup----------vvvvvvvvvvvvvvvvvvvv//
const

Loads = 3; //max load to be done
publicChat= 'On'; //if you want the auto-chat and responder...
privateChat= 'Off';
WaitTime= 5; //time to wait till it finds another spot to fish

var
Lobsters,LoadsToBeFished,FishingSpots,x1,y1: integer;

procedure Declareplayers;
  Begin
  
   HowManyPlayers :=2;
   NumberOfPlayers(HowManyPlayers);
   CurrentPlayer:=0;
   
   Players[0].Name :='';
   Players[0].Pass :='';
   Players[0].Nick :='';
   Players[0].Active:=True;

   Players[1].Name :='';
   Players[1].Pass :='';
   Players[1].Nick :='';
   Players[1].Active:=True;
   
   NickNameBMP := CreateBitmapMaskFromText(Players[CurrentPlayer].Nick, UpChars);
 end;

//^^^^^^^----------setup----------^^^^^^^//
  
procedure TheSetup;
Begin
clearDebug;
MouseSpeed:= 10;
if(Not(LoggedIn)) then
LoginPlayer;
SetRun(True) ;
Setchat (PublicChat,1);
Setchat (PrivateChat,2);
HighestAngle;
end;


Procedure CustomAntiban;
 var
 ProtectFromBannage:Integer;
  begin
   ProtectFromBannage:= Random(4);
   case ProtectFromBannage of
   1: RandomRClickEvery(1 + Random(2));
   2: RotateEvery(1 + Random(3));
   3: BoredEvery(1 + Random(2));
   4: GameTab(2 + Random (10));
  end;
end;


//-------------credits to Dankness for the DTM----------------//
Procedure DeclareDTMs;
  begin
    FishingSpots:=DTMFromString('78DA63FCC4C0C070910105CC38F086410E483' +
    '342F98C1F31D5E4B52C4255F399083520BB2E10A1E6127E3500EE' +
    '831204')
  end;


Procedure FindFishingSpots;
  begin
    if FindDtmIn(x1,y1,FishingSpots,10,10,MSX2,MSY2)then
      begin
        MMouse(x1,y1,2,2)
        wait(1000+(200))
        if(IsUpText('age')) or (IsUpText('et')) then
          Mouse(x1,y1,2,2,false)
          wait(500 + random(300))
          ChooseOption(x,y,'Cage')
          Wait(WaitTime*1000+random(500))
          CustomAntiban;
            if(IsUpText('et')) then
              Mouse(x1,y1,2,2,false)
              wait(500 + random(300))
              ChooseOption(x,y,'Cancel')
              CustomAntiban;
      end;
end;


Procedure FindRandoms;
begin

 If(Not(Loggedin)) then
 LoginPlayer;
  FindNormalRandoms;
  HandleWhirlPool;
  FindFishingEquipment;
  SolveBox;
  FindDead;
 if(FindFight) then
  begin
  RunAwayDirection('S')
  wait(5000+random(2000));
  RunBack;
 end;
end;



Procedure LobsterDrop;
 begin
  if (invfull) then
  DropTo(3,28)
 end;
 
Procedure AutoTalking;
var
autotalk, L: integer;
 begin
  autotalk :=random(5)
   if (L = 1) then
    begin
     autotalk :=random(10);
      Case autotalk of
      1:TypeSend('i am a noob...');
      2:TypeSend('...');
      3:TypeSend('*sigh*');
      4:TypeSend('zzz');
      5:TypeSend('this beats mining any day!');
      6:TypeSend('konichiwa');
      7:TypeSend('*yawn*');
      8:TypeSend('im bored');
      9:TypeSend('hello everyone');
      10:TypeSend('ni huo');
   end;
  end;
 end;
 
Procedure AutoResponder;

 begin
 SetChat ('On',1);
  if(InChat('Fishin lvls?') or
     InChat('Fishing lvls') or
     InChat('Fishing lvls?')) then

   begin
    Typesend('45 i think')
   end;

  if(InChat('Hi' + (Players[CurrentPlayer].Name))or
     InChat('Hello' + (Players[CurrentPlayer].Name))or
     InChat('Whats up' + (Players[CurrentPlayer].Name)))then
    
    begin
     Typesend('oh... hi')
    end;
     
  if(InChat('your a loser') or
     InChat('your a noob') or
     InChat('your a froob')) then
   begin
    Typesend('you are too!')
   end;
end;

      
procedure Authorofscript;
 begin
 cleardebug;
 writeln('You are using LegendaryFisher');
 wait(300);
 writeln('written by Legendaryhero90') ;
 wait(200);
 writeln('please post bugs and advice at villu-reborn.com');
 wait(300);
 writeln('on how to make this a better script');
 wait(300);
 writeln('enjoy!');
 wait(1000)
 end;
 
Procedure LegendaryReport;
begin
SRLRandomsReport;
writeln (intToStr(Loads)+ ' loads were fished...maybe');
writeln ('you''ve fished for '+ TimeRunning ) ;
end;
 



//---------------MAIN LOOP----------------//


begin
SetupSRL;
SetupSRLFishing;
DeclarePlayers;
NickNameBMP := CreateBitmapMaskFromText(Players[CurrentPlayer].Nick, UpChars);
Authorofscript;
wait(2000+random(100));
Activateclient;
If(Not(Loggedin)) then
LoginPlayer;
TheSetup;
repeat
repeat
DeclareDTMs;
FindFishingSpots;
AutoTalking;
FindRandoms;
until(invfull)
LobsterDrop;
FindRandoms;
LegendaryReport;
AutoTalking;
until ( Loads = LoadsToBeFished )
Logout;
wait(1000+random(20000))
NextPlayer(True);

end.

——————————————————
<!– END TEMPLATE: formanswers –>

FishSpotDTM := DTMFromstring('78DA63FCC4C0C070910105CC38F086410E483' +
'342F98C1F31D5E4B52C4255F399083520BB2E10A1E6127E3500EE' +
'831204');

Thats from suig include/ dankness' netter. Please credit.

Also, the script is just way too simple and there inst a good use of scripting standards.

I highly doubt this works

repeat
    RunAwayDirection('S')
    wait(2000 + random(100))
    RunAwayDirection('W')
    wait(2000 + random(100))
      until
      FindSymbol(x,y,'store')
      Mouse(x,y,10,10,true)

And there is no failsafe, meaning this will repeat only until if finds store symbol, but what if it takes a wrong step and never finds store symbol, it would continue to walk like a maniac.

Change it to

MarkTime(StoreWalk)
repeat
    RunAwayDirection('S')
    wait(2000 + random(100))
    RunAwayDirection('W')
    wait(2000 + random(100))
      until FindSymbol(x,y,'store') or TimeFromMark(StoreWalk)>30000
      Mouse(x,y,10,10,true)

This would repeat until store is frond OR the procedure took longer than 30 seconds, in which case you can tell it what to do next.


repeat
ChooseOption (x,y,'10')
wait(2500 + random(400))
until (InventoryCount=2)

This would also not always work, because all users have different amounts of items in their inventory!
What if i had 1 harpoon 1 tinderbox and 4 gems from randoms.
It would continue to try to sell the lobsters (which i dont have) forever, because my invencount will NEVER be 2.

This also doesn't work at all -.-

        Runback;

Runback doesn't trace your path for an extended time and remember were you came from! It will DEFINITELY not take you back to the dock.
You have to make another walking procedure in order to get back to the dock.
Runback is just used to runback 1 step after running from a random/fight.

You still have many things to fix, many things to lean, and you obviously didnt test this script because its just not functional.

Please try harder and test your scripts and make sure they are functional before applying.

dude yohojo.. this guy is active though (very) so you got to give him credits for that.

its not like he can become an expert scriptter by just staying on nub forums all the time.

Im not expecting him to become an expert,
but the script doesn't even work.
I at least want a working script.
And im not expecting an expert, im giving him constructive criticism on what to fix.

The reason i voted no was not because of the simpleness, it was because the script doesn't work.

And yes you cane become an expert from staying in noob forums
Asking to become and SRL member for the sake of learning more is just BS.
They have help forums and access to peoples MSN's though free area.

All im asking is for a functional script, with simi-good coding. Which this script isn't, which is why i voted no.

He needs to change the selling procedure because it repets until InvCount=2
Which is different for all people, so the script would die right there.

And also
Runback is used to run from general store to the dock again -.-
That wouldnt work either.

Thats like saying

WalkToMine;
MineRocks('Iron');
Runback;

a word of question please

when will this topic die out?

or rather when do i know if im an SRL member or not??

and can i change my script so that i can qualify myself?

if not… then ok… i guess ill wait until spring break or so

I would just leave this alone until a mod closes it, because some people have already voted.
Just work on it for a while until this one get locked, then apply again.

well I like legendary, I think he's a good guy. he's very active in the forums, and I think he will continue to be. but you can't put somebody in just because they are active (sorry to say :() so I'm going to have to vote no also. keep trying though, you may get in next month if you apply then.

From: JAD
well I like legendary, I think he's a good guy. he's very active in the forums, and I think he will continue to be. but you can't put somebody in just because they are active (sorry to say :() so I'm going to have to vote no also. keep trying though, you may get in next month if you apply then.

i wont be having time next month… SATs and all you know…

but i am going to redo my current script so please people dont vote yet unless you truly believe that i am not worthy of becoming SRL mem