SRL Archive - Archive

<!– BEGIN TEMPLATE: formanswers –>
opcon - SRL Member Application Form
opcon

What is the meaning to life?


Where you Referred to SRL? If yes, by whom?
no


Programming Knowledge
Game Maker programming language:P,

Other Communitys
Curse-x, Gamecheetah, Cheatengine, Gamerzplanet

How Long have You Played Runescape
3 years

Are you affilated in anyway with Jagex LTD?
No
—————————————————–
Please write down a paragraph about Yourself.

I really like using computers and are on them most of the time. I started using computers when I was in grade 1. By grade 3 I was about as good as the people in grade 6 at my school.( I skipped grade 2 cause I'm smart lol)
In grade 6 I Did a gamemaker course making games. I used script to create a game in the gamemaker enviroment. That got boring so I started to try to learn c++. Then I started thinking about how to cheat for runescape. First I had a look at nexus6.0 but I had to learn java and I couldn't find any good tutorials on that(also it was a bit to much):P. Then I heard about scar. It seemed the perfect thing for me and I started looking into it. I later heard about srl and I came here. This forum has everything I want. A friendly community, good scripters who can help me, active members and some good scripts. So I stayed. Then I started to try to write my own script. It's a powerminer. It has multiplayer, antirandoms and I hope to add antiban and a banker. Then I thought I might submit my script to see if I got member statues. You will probably reject me because of my low post count. Oh well I will try again in a few months:P.

——————————————————
Please Post a Sample of your Work. Only SCAR Scripts Accepted

{=========================================================================]
[                   Opcon's Powerminer                                    ]
[                                                                         ]
[           NAME        : Opcon's Powerminer                              ]
[           WRITER      : Opcon                                           ]
[           CATEGORY    : PowerMiner                                      ]
[           DESCRIPTION : It powermines for you?                          ]
[           USAGE       : Powerminer                                      ]
[           AUTOCOLOR   : No                                              ]
[           NOTES       : My first Release.                               ]
[           CONTACT     : [email]frozen_dinosaur@hotmail.com[/email]
           RELEASE NOTES: v0.01:First Attempt at scripting.
                          v0.4:Skipped ahead in the versions. This now has antirandom, multiplayer and better colour picking funtions.
                          Future releases will include an optional banker(Dwarven Mines) and antiban and autocolor?                     ]
[                                                                         ]
[                                                                         ]
[=========================================================================]
[         This is a Powerminer                                            ]
[=========================================================================]
[                           Instructions.                                 ]
[=========================================================================]
[ 1. USE Runescape with Low Detail, Very Bright.                          ]
[ 2. Set your Screen to 32 bit TRUE color.                                ]                                                                            ]
[=========================================================================}

program PowerMiner;

{.include SRL/SRL.scar}
{.include SRL/SRL/Skill/Mining.scar}


//******************** Set These Constants if Needed  *******************//
const loads = 1; // Number of loads to mine.
const StartPlayer = 0; // Determines who will play first
const pick = true; //Is your pick equipped?
const rocktime = 7000; //How long to wait before clicking on the rock again.
const randomtime = 500; //Random time to be added to rocktime.
const rundir = 'N'; //Dir to run(N,S,E,W)

//**********************RuneScape Constants*******************************//
//If your mining new rocks you might need to set your own color.
const
  CopperColor = 3168617;
  TinColor = 7829375;
  ClayColor = 4553880;
  IronColor = 2569045;
  SilverColor = 12434885;
  CoalColor = 2834753;
  GoldColor = 1881051;
  MithrilColor = 7359564;
  AdamantColor = 6322272;
  RuniteColor = 0;

//************************************************************************//
const VersionNumber = '0.4';
//************************************************************************//

var loadsdone: integer;
var rockcolor: integer;
//************************************************************************//

procedure DeclarePlayers;
begin

  HowManyPlayers := 4;
  NumberOfPlayers(HowManyPlayers);
  CurrentPlayer := StartPlayer;

  Players[0].Name := '';
  Players[0].Pass := '';
  Players[0].Nick := '';
  Players[0].Active := True;
  Players[0].string1 := 'tin';

  Players[1].Name := '';
  Players[1].Pass := '';
  Players[1].Nick := '';
  Players[1].Active := True;
  Players[1].string1 := 'tin';

  Players[2].Name := 'Username';
  Players[2].Pass := 'Password';
  Players[2].Nick := 'Nickname';
  Players[2].Active := True;
  Players[2].string1 := 'Coal';

  Players[3].Name := 'Username';
  Players[3].Pass := 'Password';
  Players[3].Nick := 'Nickname';
  Players[3].Active := True;
  Players[3].string1 := 'Coal';


end;

//************************************************************************//

procedure FindRandoms; //Find randoms?
begin
 begin
  FindNormalRandoms;
 end;
 
 begin
  if Findname then FindTalk;
 end;

  if FindGas(x,y) then
   begin
    RunAwayDirection(RunDir);
    Wait(500 + random(2500));
    Runback;
   end;

  begin
   if (FindFight = true) then
   begin
    RunAwayDirection(RunDir)
    Wait(12000 + random (3000))
    RunBack;
    end;
  end;
end;

//************************************************************************//

procedure SetUp;
begin
  SetupSRL;
  DeclarePlayers;
  LoginPlayer;
end;

//************************************************************************//
procedure dropal; //Drops everything

begin
  if pick = true then
    dropall else
    dropto(2, 28)
end;


//************************************************************************//



procedure settingup;
begin
  case LowerCase(Players[CurrentPlayer].string1) of
    'copper'  :  rockcolor := CopperColor;
    'tin'     :  rockcolor := TinColor;
    'clay'    :  rockcolor := ClayColor;
    'iron'    :  rockcolor := IronColor;
    'silver'  :  rockcolor := SilverColor;
    'coal'    :  rockcolor := CoalColor;
    'gold'    :  rockcolor := GoldColor;
    'mithril' :  rockcolor := MithrilColor;
    'adamant' :  rockcolor := AdamantColor;
    'runite'  :  rockcolor := RuniteColor;
end;

//************************************************************************//

end;
procedure miner; //The bit that mines.
begin
  repeat
    settingup;
    if (not (LoggedIn)) then
    Nextplayer(false)
    if findcolorspiral(x, y, rockcolor, 3, 3, 510, 332) then
      mmouse(x, y, 3, 3)
        isuptext('ine')
        mouse(x, y, 2, 2, true)
        wait(rocktime + random(randomtime));
    begin
      FindRandoms;
    end;
  until (invfull)
    if (invfull = true) then
    loadsdone := loadsdone + 1;
  dropal;
end;
//*************************************************************************//
//
//                               Main EventLoop
//
//*************************************************************************//
begin
  Setup;
  activateclient;
  if (not(LoggedIn) then
  login;
  repeat
    miner;
    dropal;
  until (loadsdone = loads);
  if (loadsdone = loads) then
    NextPlayer(true)
end.

——————————————————
<!– END TEMPLATE: formanswers –>

Too simple
Too many stereoscopic procs like

procedure dropal; //Drops everything
 
begin
  if pick = true then
    dropall else
    dropto(2, 28)
end;

What if user has gp, or extra pics, or gems, or other items he doesnt want dropped?
This would still drop then.
Try dropping the ores by bitmap or dtm

procedure settingup;
begin
  case LowerCase(Players[CurrentPlayer].string1) of
    'copper'  :  rockcolor := CopperColor;
    'tin'     :  rockcolor := TinColor;
    'clay'    :  rockcolor := ClayColor;
    'iron'    :  rockcolor := IronColor;
    'silver'  :  rockcolor := SilverColor;
    'coal'    :  rockcolor := CoalColor;
    'gold'    :  rockcolor := GoldColor;
    'mithril' :  rockcolor := MithrilColor;
    'adamant' :  rockcolor := AdamantColor;
    'runite'  :  rockcolor := RuniteColor;
end;

iv also seen this in way too many scripts also.

You show some poor knowledge like:

procedure FindRandoms; //Find randoms?
begin
 begin
  FindNormalRandoms;
 end;
 
 begin
  if Findname then FindTalk;
 end;
 
  if FindGas(x,y) then
   begin
    RunAwayDirection(RunDir);
    Wait(500 + random(2500));
    Runback;
   end;
 
  begin
   if (FindFight = true) then
   begin
    RunAwayDirection(RunDir)
    Wait(12000 + random (3000))
    RunBack;
    end;
  end;
end;

and

 wait(rocktime + random(randomtime));
    begin
      FindRandoms;
    end;
  until (invfull)

(Unnecessary begins and ends)
Also poor standards.

Also it doesnt even compile -.-

Line 193: [Error] (18820:19): Close round expected in script
if (not(LoggedIn) then

Line 194: [Error] (18821:1): Unknown identifier 'login' in script
login;

Thers a random "end" on line 165

And your loops need failsafes
Example:

procedure miner; //The bit that mines.
begin
  repeat
    settingup;
    if (not (LoggedIn)) then
    Nextplayer(false)
    if findcolorspiral(x, y, rockcolor, 3, 3, 510, 332) then
      mmouse(x, y, 3, 3)
        isuptext('ine')
        mouse(x, y, 2, 2, true)
        wait(rocktime + random(randomtime));
    begin
      FindRandoms;
    end;
  until (invfull)
    if (invfull = true) then
    loadsdone := loadsdone + 1;
  dropal;
end;

That repeats moving to a color and clicking if isuptext
but, what if it sprails over wrong color over and over,
or the rock inst in sight
This would repeat forever without stopping if anything went wrong.
Why not add something like

MarkTime(Mine)
repeat
stuff
Until(invenfull) or TimeFromMark(Time)>30000

This would repeat until inventory was full OR if it didnt find a rock within 30 seconds. Then you can tell it to move the compass or logout or whatever you feel.

Overall its too simple and you still have a lot more to learn.
Dont see this as a rude post, im like this to everyone.
Its constructive criticism.

Be happy that some members take the time to pinpoint exactly what you can improve, it really helps a lot.

GoodLcuk,
Yohojo

Ok thanks for the post. I admit that I didn't really expect to get in but I thought it might be worth a try:P. Just two things: When i put the comment //Finds Randoms?

I do know what that does.

Also I forgot to check it before I posted it. Sorry.

Anyway I think this app is probably denied. I will probably wait about a month before trying again.

its a definate no from me dude. I helped ocpon with this script and he didn't even give me any credits.. :( also a lot of other people helped him too. you need to give credit to those who helped you.

What did you help me with JAD?

well, I thought I helped you out more then I did :p my bad. I only helped you with an error in the dropping procedure, nothing big. but still, if people help you like jason2gs did a lot in the thread for your miner, you should give them credits.

Yea ok I will be more careful with credits next time.

I'm with JAD

Ok. I don't think I will get in :(. lol. BUT I will try again once in a month or so.

good idea, just learn as much as you can before you join, no point in becoming a member then learning the basics you know? :p

Very good idea thats what we like, consistency :p