SRL Archive - SRL Archives

Delete this (Simba.simba)

function IntToPoint(x,y : integer) : TPoint;
begin
  result := Point(x,y);
end;     

I mean…really?

It was probably there for SCAR compatibility. Aren't you happy we didn't just include it in Simba but did it like this? ;)
Does the include (SRL) use it at all?

Haha yes very happy it can be deleted :P
Not used as far as I could find.

ian@ubuntu:~/mahsheet/mySimba/srl-opendev$ grep -ri IntToPoint *
SRL/misc/users.scar:        MousePosPoint := srlpf_PlayerPageControl[ArmyIndex].ClientToScreen(IntToPoint(x, y));
SRL/misc/users.scar:        MousePosPoint := srlpf_ArmyPageControl.ClientToScreen(IntToPoint(x, y));
SRL/misc/.svn/text-base/users.scar.svn-base:        MousePosPoint := srlpf_PlayerPageControl[ArmyIndex].ClientToScreen(IntToPoint(x, y));
SRL/misc/.svn/text-base/users.scar.svn-base:        MousePosPoint := srlpf_ArmyPageControl.ClientToScreen(IntToPoint(x, y));
SRL/core/simba.simba:function IntToPoint(x,y : integer) : TPoint;
SRL/core/.svn/text-base/simba.simba.svn-base:function IntToPoint(x,y : integer) : TPoint;
ian@ubuntu:~/mahsheet/mySimba/srl-opendev$ 

Grep is amazing.
Ok, so its used twice in users.scar. No problem, just delete for next SRL version :)

g/re/p is quite amazing.

By the way, a quick search for IntToPoint in SRL5 showed no use of IntToPoint. ;)

To use of it is quite lazy in my mind :p

hm iv seen similar things such as point; and tile; whats the difference imo tile should be deleted?

From: pur3b100d
hm iv seen similar things such as point; and tile; whats the difference imo tile should be deleted?

It can be better for readability to define something as a tile rather than a point, since although they store the same thing are conceptually different.

Quite useful function actually
FunctionWhichWantsTPoint(IntToPoint(x, y));
Saves a few lines and a variable.

From: Markus
Quite useful function actually
FunctionWhichWantsTPoint(IntToPoint(x, y));
Saves a few lines and a variable.

Point() does the same thing, shorter function name (less typing pl0x), and IntToPoint is pretty much unused.

Request:

Box(x1, y1, x2, y2): TBox rather than IntToBox()?