SRL Archive - MSI Updates & Announcements

Quite a few updates today. :)

$ git shortlog ea1aa13df1ab62afe74c..a95dcbb143021c17fa92|cat
Cohen Adair (5):
      Rewrote Animating.simba to use AveragePixelShift (much more accurate now); Added a 'Track' attribute to TMSObject: now if WaitToMove is true, will call flag else MSI_TrackObject, if both are true will call MSI_TrackObject; Removed MSI_Animations global array (will eventually do with all global arrays);  Added CLAY_SOFT item.
      Users can now set a max skill level for each script.
      Merge branch 'master' of github.com:PxlBuzzard/MSI; TREE_NEW_WILLOW --> TREE_WILLOW_NEW; Got rid of MSI_Files global array, added DebugFile global variable, added SETUP_SAVE_REPORT constant; MSI_AutoInvFull will now move the camera angle slightly if objects aren't found.
      Fixed a runtime error that would happen when you didn't save the progress report.
      Fixed an out of range error with the alcher (not sure how this didn't come up earlier), and updated the high alch animation.

PxlBuzzard (7):
      Fixed dates in new Fishing documentation.
      Added Falador West Miner, works fine except for obstacle handling.
      Added a rest to the walking if the player is below 20 energy (only at the beginning of the walk, not in the middle of it).
      Added camera move support to obstacles. Also updated the color for the Falador west wall, and changed the rest value to rest a little long (40-60 instead of 20-30).
      Added a camera reset after changing it for an obstacle, and moved the run/rest code into MSI_WalkPath so that it is used on every walk, not just the first one.
      Added the new willow tree object and updated the Port Sarim Willows script to match.
      Added the new willow tree to Globals.simba and changed its colors to stop accidently picking up ground colors.

https://github.com/SRL/MSI/commits/master

" Added a rest to the walking if the player is below 20 energy (only at the beginning of the walk, not in the middle of it)."

That should be handled by MSI_WaitWhileResting which if I remember correctly used to be called in MSI_PerformWalk. However, I look now and there is a simple RunEnergy(20) there instead.

If no one else changes that I will when I commit all my changes.

From: NCDS
" Added a rest to the walking if the player is below 20 energy (only at the beginning of the walk, not in the middle of it)."

That should be handled by MSI_WaitWhileResting which if I remember correctly used to be called in MSI_PerformWalk. However, I look now and there is a simple RunEnergy(20) there instead.

If no one else changes that I will when I commit all my changes.

Feel free to overwrite it, I only added the resting because there was already a SetEnergy(20) in MSI_PerformWalk when I was looking to make MSI run instead of walk more often.

Talked to IPwnz about this briefly. It seems to be another situation like we had with clicking the inventory tab. I always see MSI walking with 100% energy, and it never sets the run, even though a RunEnergy is called pretty often, and when tested by itself it works fine. We may have to try our own function, like with MSI_ClickInvTab.

Argh! Why is it so that SRL's functions wont work in some cases?!
It just doesn't make any sense! :(

From: Zyt3x
Argh! Why is it so that SRL's functions wont work in some cases?!
It just doesn't make any sense! :(

Because we rely on the include just changing to work with our scripts, rather than getting our scripts to work with the library as best as possible.

/rant about the silly ideology people have who develop srl + simba.

From: i luffs yeww
Because we rely on the include just changing to work with our scripts, rather than getting our scripts to work with the library as best as possible.

/rant about the silly ideology people have who develop srl + simba.

What?

It's much better to change the function in the include to work in all cases, than having to make my own version of the function.

From: Zyt3x
What?

It's much better to change the function in the include to work in all cases, than having to make my own version of the function.

This. However, my guess as to why running/resting isn't working properly is that it isn't being called in the right procedure. I moved it to MSI_PerformWalk to see if that would make a difference and it didn't seem to (except on occasion, it's fairly random). I would suggest that we make some kind of a run/rest function and then throw it into a couple different procedures to see if we can fix this thing.

From: IPwnz
This. However, my guess as to why running/resting isn't working properly is that it isn't being called in the right procedure. I moved it to MSI_PerformWalk to see if that would make a difference and it didn't seem to (except on occasion, it's fairly random). I would suggest that we make some kind of a run/rest function and then throw it into a couple different procedures to see if we can fix this thing.

The issue with clicking the inventory tab, I added this in a lot of places:

if (gameTab(TAB_INV)) then
  writeln('clicking inventory');

"Clicking inventory" would always be written, but the tab was never clicked, so I don't think it's a matter of calling it in the right place.

@Ian, everyone's entitled to their own opinion, so I'm going to completely disagree with your idea of what SRL + Simba/all libraries should be. The more methods available the better. I do, however, agree that not all methods should be included when they're not used (i.e. how java's library works (I'm unfamiliar with other languages)).

From: IPwnz
This. However, my guess as to why running/resting isn't working properly is that it isn't being called in the right procedure. I moved it to MSI_PerformWalk to see if that would make a difference and it didn't seem to (except on occasion, it's fairly random). I would suggest that we make some kind of a run/rest function and then throw it into a couple different procedures to see if we can fix this thing.

I wrote and committed MSI_WaitWhileResting quite some time ago, and IIRC that should handle all resting and setting run to true.

From: NCDS
I wrote and committed MSI_WaitWhileResting quite some time ago, and IIRC that should handle all resting and setting run to true.

Yeah, should. Just like GameTab(tab_Inv) should always click the inventory tab.

From: Coh3n
Yeah, should. Just like GameTab(tab_Inv) should always click the inventory tab.

I'll have a look at this again… :/

Somebody get proper debugging into SRL already…

~RM

From: Sir R. M8gic1an
Somebody get proper debugging into SRL already…

~RM

Current Dev's work on other things or aren't active at all anymore, and they certainly don't seem overly eager to bring on any help.

From: Sir R. M8gic1an
Somebody get proper debugging into SRL already…

~RM

I've tried debugging gameTab, but since I couldn't reproduce the issue, it didn't help.

From: NCDS
Current Dev's work on other things or aren't active at all anymore, and they certainly don't seem overly eager to bring on any help.

Yeah you're right.

I think the whole gametab system is a bunch of messy code… Instead of doing the maths in each and every function, we should have one function named TabBox (similar to InvBox) that returned the x1, y1, x2 and y2 of the game tab

From: NCDS
Current Dev's work on other things or aren't active at all anymore, and they certainly don't seem overly eager to bring on any help.

Agree. The spotlight is now on Simba, something Icefire (the only person really commiting to the include) was saying a very long time ago.

From: MadClabXIII
Agree. The spotlight is now on Simba, something Icefire (the only person really commiting to the include) was saying a very long time ago.

The spotlight is on our own lives, mainly. Icefire the only one committing? https://git.villavu.com/?p=srl-opendev/.git;a=summary

From: Wizzup?
The spotlight is on our own lives, mainly. Icefire the only one committing? https://git.villavu.com/?p=srl-opendev/.git;a=summary

Simply an observation. Still, an important member for the include who has now become inactive.

http://villavu.com/forum/showthread.php?t=63798

Tabs need fixing, RS update

~RM

From: Sir R. M8gic1an
http://villavu.com/forum/showthread.php?t=63798

Tabs need fixing, RS update

~RM

Looks like the constants just might need to be edited for naming. The color used hasn't changed, and it doesn't look like the spacing has, but I'll have to check that I guess.

Committed NCDS's fixes. :)

Guys, I've been watching a willow cutter on MSI for a while and the setting the run seems to be working great. It always sets it to true when it gets to 20. So whatever it was seems to be fixed. =\

From: Coh3n
Guys, I've been watching a willow cutter on MSI for a while and the setting the run seems to be working great. It always sets it to true when it gets to 20. So whatever it was seems to be fixed. =\

Well I did move the SetEnergy code, so maybe just putting it somewhere else helped.

From: IPwnz
Well I did move the SetEnergy code, so maybe just putting it somewhere else helped.

I didn't see it actually rest, it would just set run to True.

From: Coh3n
I didn't see it actually rest, it would just set run to True.

rofl whatever works. :D