SRL Archive - MSI Bugs

When you read the report, know that my player had a rune pickaxe equipped, MSI never checked for my level on the stats tab, then when it opened the bank, it saw that I had both an iron and a bronze pickaxe available, but it didn't withdraw either of them.

[0:00:37]: [ player ] ------ Mining level hasn't changed
[0:00:37]: [ player ] ---- MSI_SetSkillLevels: Finished
[0:00:37]: [ player ] ---- MSI_SetupWC/Mining
[0:00:37]: [ player ] ------ Best tool for Mining is Iron pickaxe
[0:00:37]: [ player ] ------ MSI_FindTool
[0:00:37]: [ player ] -------- Searching Inventory tab
[0:00:37]: [ player ] -------- Failed to find DTM of Iron pickaxe
[0:00:37]: [ player ] ------ MSI_FindTool: False
[0:00:37]: [ player ] ------ MSI_FindTool
[0:00:37]: [ player ] -------- Searching Inventory tab
[0:00:37]: [ player ] -------- Failed to find DTM of Bronze pickaxe
[0:00:37]: [ player ] ------ MSI_FindTool: False
[0:00:37]: [ player ] ------ Best tool for Mining is Iron pickaxe
[0:00:38]: [ player ] ------ MSI_FindTool
[0:00:38]: [ player ] -------- Searching Equipment tab
[0:00:38]: [ player ] -------- Failed to find DTM of Iron pickaxe
[0:00:38]: [ player ] ------ MSI_FindTool: False
[0:00:38]: [ player ] ------ MSI_FindTool
[0:00:38]: [ player ] -------- Searching Equipment tab
[0:00:38]: [ player ] -------- Failed to find DTM of Bronze pickaxe
[0:00:38]: [ player ] ------ MSI_FindTool: False
[0:00:38]: [ player ] ------ MSI_OpenBank
[0:00:38]: [ player ] ---------- Current GameTab: 26
[0:00:38]: [ player ] -------- MSI_FindObjectsIn [39]
[0:00:39]: [ player ] ------------ Not enough points: 7
[0:00:39]: [ player ] ------------ Not enough points: 15
[0:00:39]: [ player ] ------------ Not enough points: 4
[0:00:39]: [ player ] ------------ Not enough points: 19
[0:00:39]: [ player ] ------------ Not enough points: 1
[0:00:39]: [ player ] ------------ Not enough points: 3
[0:00:39]: [ player ] ------------ Not enough points: 14
[0:00:39]: [ player ] ------------ Not enough points: 6
[0:00:39]: [ player ] ------------ Not enough points: 10
[0:00:39]: [ player ] ------------ Not enough points: 3
[0:00:39]: [ player ] ------------ Not enough points: 5
[0:00:39]: [ player ] ---------- 24 objects found!
[0:00:39]: [ player ] ---------- Uptext found!
[0:00:40]: [ player ] -------- MSI_FindObjectsIn: True
[0:00:41]: [ player ] ------ MSI_OpenBank: True(Falador west bank)
[0:00:42]: [ player ] ------ Best tool for Mining is Iron pickaxe
[0:00:42]: [ player ] ------ MSI_Withdraw
[0:00:42]: [ player ] ------ MSI_Withdraw: False (Iron pickaxe)
[0:00:42]: [ player ] ------ MSI_Withdraw
[0:00:42]: [ player ] ------ MSI_Withdraw: False (Bronze pickaxe)
[0:00:42]: [ player ] ------ Couldn't withdraw best tool
[0:00:42]: [ player ] ---- MSI_SetupWC/Mining: False
[0:00:42]: [ player ] -- MSI_SetupPlayer: False

And your using the latest version from the main repos?

I'm about to set up my little army so I'll see what I can figure out.

From: NCDS
And your using the latest version from the main repos?

I'm about to set up my little army so I'll see what I can figure out.

I'm using the newest version plus a couple additions (Falador west bank for one). None of the additions change anything that I mentioned in the first post though.

Everything seems to be working just fine for me. :confused:

Ipwnz look in your globals and tell us what object 39 is please.
Also I dint understan the problem, if you have a rune pick equipped why would you want the script to worry about a bronze or iron one? Can you reexplain what the problem is?

From: YoHoJo
Ipwnz look in your globals and tell us what object 39 is please.

39 is Falador West Bank, I have it in my local repo and it'll get pushed up to the main repo shortly. It handled the opening of the bank fine in my run though, so that's not an issue.

From: YoHoJo
Also I dint understan the problem, if you have a rune pick equipped why would you want the script to worry about a bronze or iron one? Can you reexplain what the problem is?

MSI didn't even bother to look for a rune pickaxe because it never checked my player's level, which may well be the root cause of everything else (except the withdrawing).

Does this happen every time or was it a single occurrence?

Check the procedure that's supposed to get the player skill level. ;)

When you added the defines for checking the players still level, you had it use the reflection one if reflection was defined (i.e. included), meaning if the hooks are outdated, it will still call the reflection skill level, and probably return 0 or -1. You'll probably need to updated GetSkillLevels with something like this:

{$IFDEF REFLECTION}
if (not ReflectionBroken) then
  curLev := R_GetSkillLevel(MSI_Scripts[Scripts[i].Name].SkillName)
else
  curLev := GetSkillLevel(MSI_Scripts[Scripts[i].Name].SkillName);  
{$ELSE}
curLev := GetSkillLevel(MSI_Scripts[Scripts[i].Name].SkillName);
{$ENDIF}

Bingo! ^
Hooks are outdated right now, and I assume level checking uses ref so It doesn't need to switch to the tab to check your level, that's probably why it's happening.

Geez you all beat me to posting :P. Thanks for finding the problem Coh3n, I can't believe (well, yeah I can :P) I didn't realize that when I added the reflection level check a couple weeks ago. :redface:

No problem. :) I didn't realize it either. I'm the one who pulled from you. ;)

Cohen, is the GetSkillLevels in your repo working properly like the coed you posted above?

From: YoHoJo
Cohen, is the GetSkillLevels in your repo working properly like the coed you posted above?

Nope. I do remember having this problem the last time the hooks went out dated, though. Sounds like something I would have fixed, but I just checked my repo and it wasn't fixed.

This has been taken care of in my repository. :) Will be pushed to main eventually.