SRL Archive - Outdated / Broken

Trying to get this out as a quick release, to combat the falling berry price.
It's not finished, nor is it flawless, but it's getting a lot better.

I've uploaded it to this thread, but you can always find the most updated version here (it might no be working though, as it's the direct file that I use, as it's on my web server).

Start in Edgville Bank, with preferably 10+ Amulets of glory (4), and it would be advised to only be wearing a Glory ammy, and Anti-Dragon shield.

If you want anything changing/adding, I will do it (Just make sure it's not in the TODO list, which is at the top of the script!


Please sell for market price and above, NO LESS!

Updates:
4/4/11 - Added stats

Hey thanks for releasing this. I think? I saw you asking if profitability would go down with the script? I'd say definitely not not super many of us here are members and I doubt just us alone would have any effect on the price. Also advise people to sell at mid-above mid and everything will be just fine!
(Won't be using it, not a member, but good idea for a script)

From: HarryJames
Trying to get this out as a quick release, to combat the falling berry price.

How do you figure releasing a script for this will make the prices raise?

Hehe, I was anxiously awaiting this release. I will promptly be testing it, expect some suggestions and criticism by tomorrow :)

I edited that in :)
Either way if people from here sell for less, the price of berry's are going down anyway :(

From: NCDS
How do you figure releasing a script for this will make the prices raise?

Well, I will be one of the few people selling for a decent price. Those Java Botters are idiots don't give a shit. If enough people sell for a decent price, then it won't drop (or as quickly).

From: PatDuffy
Hehe, I was anxiously awaiting this release. I will promptly be testing it, expect some suggestions and criticism by tomorrow :)

Awesome :D
There's still some experimental stuff, and I've got two sets of time in cause I was checking it. It's not perfect, but it works.

{$i /home/harrytorry/Desktop/LoginDetails.simba} 

Exception in Script: Unable to find file '/home/harrytorry/Desktop/LoginDetails.simba' used from ''
Might want to remove that

EDIT: I had a lobster pot in my bank and it withdrew that lol, i guess it was looking for lobsters?

Ohh sorry, I need to turn that into an ifdef. Just comment it out :)

I had to do it this way, since it's going to be availably 24/7 (as it's gonna be changed a lot). I didn't really want to put my login details online ^^

Prices are off of supply and demand anyways, selling for higher won't do anything when there's more supply than demand and everyone else is selling lower.

Ohh, I thought it was based off what they are currently selling for ;(

Either way, it's good money ;D

Ok, ran the script for 40 minutes and I have a few suggestions, some of which aren't as needed as others. I'll list them by the urgency of fixing.

1. The script stopped after 40 minutes(actually got stuck) trying to cross the wilderness wall. I have a feeling that the camera positioning made it unable to find and cross the wall, the debug box spammed "Didn't move for 10 seconds, exiting" which for some reason I think is associated with banking? Anyway there needs to be an extra fail-safe or two for the journey between the bank and crossing the wall.

2. The ability to carry a piece of food or two in case of any attack. Certainly a lobster isn't going to protect you from a pker, but it might save you from an un-needed death by red dragon.

3. Randomization and alteration of paths. The current pathway to the berries leads the bot through BH-Alley, a popular pk'ing and lure spot. This is probably the fastest way there, but it could become dangerous if repeatedly passed through, so perhaps create another path or two, and randomize which path the bot will take.

4. Currently, when White Berries spawn, the script will spam click the berries until they are picked up. I know I certainly don't click 4-5 times just to pick up an item, it just kind of screams "I'm a bot!" to me :p

5. Painted Progress Report? or make the current one a little bit more appealing :p
Not really needed but I always do like a visually appealing script.

Other than that I really like it, and in 40 minutes it collected 140 berries, around 280k(I don't remember exactly) profit. I'm not sure how long the bot was stuck, but it still worked decently.

1) I've never had that problem, and I've ran it for something like 30 hours throughout/during the development cycle.
2) It's actually supposed to withdraw two lobsters, and it was doing this erliar. I'll check and find out why it isn't :)
3) It will be easy to add lots of extra paths for everything, but i'll have to do it tomorrow as I just don't have the effort to do it now :)
(It's easy to do as i have my MakePath procedure).
4) I'll just add a longer wait to it, and that will fix it. (I'll do that after finishing this post).
5) I'll read into that now, and see what I can do :)


It averages out a load every 7 to 8 minutes, so 40/8 = 5. This multiplied by 28 is 140. So you didn't actually waste any time :D
Thanks for the helpful reply :)

This is what i've gotten tonight :)

|--------- HarryJames ---------|
|--------BerryCollecter--------|
|==============================|
|                              |
|  Running Time: 01h 47m 33s   |
|  Collected 364/800 berries.  |
|  Profit  0 GP!.              |
|  Used 3 Glorys.              |
|  Died 0 times.               |
|  Eaten 0 times.              |
|                              |
|------------------------------|

I did have some cooked lobsters in my bank, so idk why the withdraw didn't work

Yeah, I just realised this whole run that I hadn't been withdrawing food.
I changed the following, I don't know if it will work though.

Procedure getFood;
Begin
R_WithdrawItem('lobster', 2);
if BankScreen then CloseBank;
End;

Procedure getFood;
Begin
R_WithdrawItem('Lobster', 2);
if BankScreen then CloseBank;
End;

I'll fix it tomorrow anyway :)


Edit: I've tried editing this twice so far, and I watched it. It found the lobster, but was unable to withdraw them for some reason. I can try changing it to withdraw 1, and that might work.

|--------- HarryJames ---------|
|--------BerryCollecter--------|
|==============================|
|                              |
|  Running Time: 02h 46m 11s   |
|  Running Time: 2 Hours, 46 Minutes and 11 Seconds|
|  Collected 560/800 berries.  |
|  Profit  0 GP!.              |
|  Used 5 Glorys.              |
|  Died 0 times.               |
|  Eaten 0 times.              |
|                              |
|------------------------------|

I died, and the WeDied procedure wasn't working properly. It successfully changed worlds though!
I've set it running again, and i'm going to sleep in 15 minutes, G'night :)

Found another issue that resulted in the character becoming stuck. The character made a full run normally, picked up berries fine, but when it went to teleport back to Edge I saw it didn't have a glory equipped. Somehow during a banking transition, the script deposited my un-charged glory and failed to withdraw a new one.

I see 2 possible fixes for this, you may see more. First, incorporate a system where you dont 'need' glories, and if a glory is not equipped it will run back to Edge bank. Second, add a failsafe right before it leaves the bank checking to see if it has a glory available.
Back to the first idea, possibly add a method that will continue to run without glories if the character runs out in their bank. Like if the script works and uses up all 5 of the glories in the player's bank, it will continue to manually walk to and from the berries, at the cost of reduced Cash/Hour.

Just some more suggestions :p

Okay thanks, I've not had any of these issues. I can quite easily make it run straight to the bank, and not tele.

I think it would also make less money if it wasn't teleporting, as each Glory teleport costs about 500gp, and it cuts about 30 seconds. Every 14 runs, another one could have been done, which is nearly 60k. So based on time, running costs you 1.5k more than using a glory teleport!
I will still add it anyway, just in case.

I wasn't intending on releasing this when I first started writing it, which is why it's glory based (I have 100 glories :P).

I also intend to be adding failsafes all around :)

Found a new error :p

When starting the script, it wasnt waiting for SMART to load before checking for a Glory. When I start this script with SMART loaded, the script will detect a glory in the inventory, equip it, then fail because it couldn't find a glory. It refused to find a glory if it was equipped, I suggest making it check equipped items for the glory.

The way I would do it would be a DTM, check the inv for it, then if false check the equipped items. I know you like reflection a bit more than I do, so you might want to use that :p

Just throwing out some more suggestions

Anyone confirm the GP Per Hour?. Are they actually selling or do you have to wait weeks? Lol

I do use reflection for it!
I'll add a small wait at the start of the script, just in case :)
Things like this will happen when Simba thinks the client is ready, or it's currently disabled.

if ((GetEquippedIDAt(2) = 1704) or (GetEquippedIDAt(2) = -1)) then

From: rogeruk
Anyone confirm the GP Per Hour?. Are they actually selling or do you have to wait weeks? Lol

I have confirmed it! :)
It's usually instant, but I had to wait about 30 minutes yesterday, so it's as good as.
I've made roughly 4m from this so far, and I've not ran it outside of development, which is a shame really.

4M Over how many hours?

It's unfair to say, as I was stopping and starting, testing procedures as I made them :)

I ran it for 3 hours (This post) and it seemed to do pretty well.

It only takes up to 8 minutes (9 at a push) per load, while Glory teleporting.

That's not 400k/h.. :p

The price of Berries were slightly (only a tiny bit) under 2k when I made the thread.

60 minutes = 7.5 loads
7.5 loads = 210 Berries
210 * 1853 (current GE price) = 389,130.

Am i right in thinking you only need 2 glories per hour then?

Without dieing.
If you download it from the link, i've updated it a lot (mainly from PatDuffy's input). I've not tested it since updating it, but I've made sure that it compiles!

Kinda Buggy, but it worked….

Lagging connection….

|——— HarryJames ———|
|——–BerryCollecter——–|
|==============================|
| |
| Running Time: 13m 39s |
| Collected 0/800 berries. |
| Profit 0 GP! |
| Used 0 Glorys. |
| Died 0 times. |
| Eaten 0 times. |
| |
|——————————|

Recommendations same as you have planned…Good Job :)

RAM, how far did your character actually get?
Walking there, picking up, walking back or banking?

Thanks ;)

I put 86 berries in for 1700 each and got 150,586, that means they currently sell instantly for 1751 gp. They don't sell at market. So your profit p/h should be lower than what you said a few posts before this. It works alright, it sometimes miss-clicks the berries, and if another person is standing where we are, I think it tries to attack them and doesn't right click then choose the option for picking up berries.

lol@baked's sell price compared to his sig.
Haven't used this script yet, I will run it tonight and see how she goes :).

From: HarryJames
RAM, how far did your character actually get?
Walking there, picking up, walking back or banking?

Thanks ;)

|——–BerryCollecter——–|
|==============================|
| |
| Running Time: 49m 43s |
| Collected 28/800 berries. |
| Profit 0 GP! |
| Used 1 Glorys. |
| Died 0 times. |
| |
|——————————|

OK, here's the breakdown….had some problems with SRLStats, so I had to comment it out to get to work….after that, I commented out the "getFood"(should be an option, as over X-combat, 2 lobbies isn't an issue)as that is 2 extra berries….had a problem with "CrossWildernessWall" several times(had to help over)…lagged connection, but not terribly bad, walking was fine(but needs to be randomized)…had a problem with "OpenGate" to berries(check/rotate camera?)…Spam Clicking on berries as addressed earlier….didn't deposit berries before checking glory, so it didn't change glory after 4th use, sooooo…it got stuck in a loop walking from berries(with full inventory) to wall to "Teleport"(check for charged Glory, if not walk back to E-ville,((or HomeTelly/Bank/Telly E-villie))…..

other than that…..:D

~RAM

From: cause
lol@baked's sell price compared to his sig.
:).

Fucking hilarious.

HarryJames. Did you got everything solved. Talk me in MSN if problems :)
Gz for releasing!

~Home

From: Baked0420
I put 86 berries in for 1700 each and got 150,586, that means they currently sell instantly for 1751 gp. They don't sell at market. So your profit p/h should be lower than what you said a few posts before this. It works alright, it sometimes miss-clicks the berries, and if another person is standing where we are, I think it tries to attack them and doesn't right click then choose the option for picking up berries.

Yeah, your sig -.-
And just becuase they don't always sell instantly, doesn't mean that they don't sell..

From: RAM
OK, here's the breakdown….had some problems with SRLStats, so I had to comment it out to get to work….after that, I commented out the "getFood"(should be an option, as over X-combat, 2 lobbies isn't an issue)as that is 2 extra berries….had a problem with "CrossWildernessWall" several times(had to help over)…lagged connection, but not terribly bad, walking was fine(but needs to be randomized)…had a problem with "OpenGate" to berries(check/rotate camera?)…Spam Clicking on berries as addressed earlier….didn't deposit berries before checking glory, so it didn't change glory after 4th use, sooooo…it got stuck in a loop walking from berries(with full inventory) to wall to "Teleport"(check for charged Glory, if not walk back to E-ville,((or HomeTelly/Bank/Telly E-villie))…..

other than that…..:D

~RAM

I still need to make the CrossWildWall a bit better, and some failsafes on it (which I just added to the todo list), I will add a few TileArray's for each walk, it should've deposited the Berries though, I've not had a problem with that.

From: Home
HarryJames. Did you goe everything solved. Talk me in MSN if problems :)
Gz for releasing!

~Home

I should be on tonight, there's just the odd problem (other than bugs) that I can't fix.

Thanks for all the feedback guys :D <3<3

Hope you don't mind some competition, gonna finish my existing version i think.

//Edit.

There was like 6 people picking them up today lol :S.