SRL Archive - Bugs

begin
  WriteLn(StrToInt('hi'));
end.

Compiled succesfully in 15 ms.
-1
Successfully executed.

AFAIK, "hi" is not a number, but Simba says it is the same as "-1"… Why doesn't it result in an error???

No reason….if there is anything in the string that is not a number it returns -1…

Well I don't know. Whatever :p. I think it doesn't matter anyways.

It should not return a number when the input is not a number (of course)

-1 doesn't mean it failed, -1 is just a number.

StrToInt('anystring'); should crash simba

-1 sometimes means false. As does 0. This is a different situation as you are expecting a number, any number (which could, of course, be -1 itself). I see what you mean. But I don't think I'd want it to crash. You can create your own handler for this if you really want to.

If you don't want it to crash, use StrToIntDef().

StrToInt() should imo crash if the input is not a number.

Its just a wrapper around FreePascals StrToInt, Tho it should throw an exception.

Ah, I'd find myself to agree with you now.

 StrToBool('') -> Error: Exception: "" is not a valid boolean. at line 3

Therefore StrToInt('hi') should throw Error: Exception: "hi" is not a valid integer. at line 3

I agree with this. The same should be done for all the conversion methods.

It did throw an error before iirc… Wonder what changed :confused:

From: Zyt3x
It did throw an error before iirc… Wonder what changed :confused:

It threw an error in Simba? As long as I can remember, Simba always returned -1.

function StrToInt(str: string; var value): bool

Perhaps this would be a better format?

Ew, I don't like that. =\

Most conversion methods are used to Writeln and are already a pain. Throwing an exception just makes more sense IMO.

In those cases, you would use StrToIntDef

From: Smartzkid
In those cases, you would use StrToIntDef

Touche.

I think it should raise an exception. Please file a bug. :)

From: Wizzup?
I think it should raise an exception. Please file a bug. :)

Thanks, and done.

Well, apparently PascalScript changed this. From their source code:

function StrToInt(const S: TbtString): LongInt;
var
  e: Integer;
  Res: LongInt;
begin
  Val(string(S), Res, e);
  if e <> 0 then
    StrToInt := -1
  else
    StrToInt := Res;
end;

Well tell them to change it back!

But if not.. couldn't some form of wrapper function be made to overwrite the PS version? If absolutely necessary of course.

From: Coh3n
Well tell them to change it back!

But if not.. couldn't some form of wrapper function be made to overwrite the PS version? If absolutely necessary of course.

Yeah, we can surely just change it. I was just trying to find out why it didn't work in Simba at first. Then we'll have to make a decision.

I already added a note to bugs.villavu.com, but I'll post here too..

We can change it to

if e <> 0 then
  ThrowError(); //
else
  StrToInt := Res;

From: Zyt3x
I already added a note to bugs.villavu.com, but I'll post here too..

We can change it to

if e <> 0 then
  ThrowError(); //
else
  StrToInt := Res;

<> -1, you mean? What if the string is actually '-1'?

raise Exception.Create('Some Error….');

We should just use the StrToInt from FPC/Lazarus.

From: nielsie95
We should just use the StrToInt from FPC/Lazarus.

That was what I was going suggest. :)

From: Coh3n
<> -1, you mean? What if the string is actually '-1'?

nope, e is <> 0 when there is an error :)

From: nielsie95
We should just use the StrToInt from FPC/Lazarus.

:D

http://lazarus-ccr.sourceforge.net/docs/rtl/sysutils/strtoint.html

Resolved in master. Will be in 0.97 rc2.

Great! Thanks :)