SRL Archive - MSI Bugs

I'm currently running the RIM script and the MSI_Antiban procedure seems to stop/break the script.

[0:09:28]: [ *** ] ------ MSI_TrackObject: True
[0:09:28]: [ *** ] ---- MSI_FindObjectsIn: True
[0:09:29]: [ *** ] ---- MSI_WaitWhileMining
[0:09:29]: [ *** ] ------ InvCount: 1
[0:09:29]: [ *** ] ------ Entering loop
[0:09:29]: [ *** ] ---------- Scanning for randoms...
[0:09:29]: [ *** ] ---------- MSI_AntiBan
[0:09:29]: [ *** ] ---------- 0..2000 (3)

So the "0..2000 (3)" is what i put it in to find what was causing the problem and it turned out to be this

        2 : Begin
              MSI_SubDebug('0..2000 (3)');
              RandomRClick;
            End;

Just wondering if anyone else ran into this?

I haven never heard of this before, and RandomRClick can't possibly mess anything up unless it possibly pulls up a menu that covers what the script is looking for.

Was there a Menu open when this happened?

Imho the antiban is really not good enough. Antiban should be in each and every procedure that interacts with runescape rather than in one single procedure. This way we get a better antiban and will look more human

From: Zyt3x
Imho the antiban is really not good enough. Antiban should be in each and every procedure that interacts with runescape rather than in one single procedure. This way we get a better antiban and will look more human

MSI_AntiBan is called in numerous proc's?

From: NCDS
I haven never heard of this before, and RandomRClick can't possibly mess anything up unless it possibly pulls up a menu that covers what the script is looking for.

Was there a Menu open when this happened?

I removed RandomRClick; and have been running the script for ~3 hours now without fault.

No menu was open when it stopped. It happened when walking back to the mine the most and once while mining. I checked it several times before making this thread, Ran CCleaner, and restarted my computer.

From: NCDS
MSI_AntiBan is called in numerous proc's?

Nevermind.. it's just an idea I'm throwing out there, but I'm talking about not having a procedure for antiban, but having it so that we call mouse movement/camera movement/tab clicking inside the functions.
This way we wont have antiban that random right clicks/checking random tabs while (I.E) walking..

Specified antiban for each specific action/task

From: Zyt3x
Nevermind.. it's just an idea I'm throwing out there, but I'm talking about not having a procedure for antiban, but having it so that we call mouse movement/camera movement/tab clicking inside the functions.
This way we wont have antiban that random right clicks/checking random tabs while (I.E) walking..

Specified antiban for each specific action/task

It's not a bad idea as far as functionality goes, it could just get messy/repetitive.

From: NCDS
It's not a bad idea as far as functionality goes, it could just get messy/repetitive.

Yeah, that's the downside :/

From: Zyt3x
Nevermind.. it's just an idea I'm throwing out there, but I'm talking about not having a procedure for antiban, but having it so that we call mouse movement/camera movement/tab clicking inside the functions.
This way we wont have antiban that random right clicks/checking random tabs while (I.E) walking..

Specified antiban for each specific action/task

I actually really, really like that idea. I think if done properly, it could revolutionize scripts (take a look at RiD scripts if you haven't already). On the note about it being repetitive - that's easily solved. Have several custom antiban procedures and call certain ones where a human is more likely to do something.

procedure MSI_SpamClickTabs();

procedure MSI_SpamCameraAngle();

procedure MSI_FunnyMouseMovement();

procedure MSI_SpamTabsAndCamera();

I'm sure we could incorporate many many different antiban methods.

@england: You never really stated what your problem was exactly? Like it literally just idles and does nothing? If so that's weird. Like I've said in other threads, I've had no problems running MSI for the past few weeks; I actually have a 38 hour report still running.

From: Coh3n
I actually really, really like that idea. I think if done properly, it could revolutionize scripts (take a look at RiD scripts if you haven't already). On the note about it being repetitive - that's easily solved. Have several custom antiban procedures and call certain ones where a human is more likely to do something.

procedure MSI_SpamClickTabs();

procedure MSI_SpamCameraAngle();

procedure MSI_FunnyMouseMovement();

procedure MSI_SpamTabsAndCamera();

I'm sure we could incorporate many many different antiban methods.

Agreed. I figured no one would support changing this to that extent, but I'm all for that.

All functions to be included in AntiBan.Simba I would imagine, right?


Looks like a good opportunity for some public contributions. ;)

From: NCDS
Agreed. I figured no one would support changing this to that extent, but I'm all for that.

All functions to be included in AntiBan.Simba I would imagine, right?

Yes.

From: NCDS

Looks like a good opportunity for some public contributions. ;)

And yes.

This would be an opportunity for people to use their imaginations.

This is the current MSI_NoMouseFindRandoms;

function MSI_NoMouseFindRandoms: Boolean;
var
  I: Byte;
  Cont : boolean;
begin
  if (not LoggedIn) then
    Exit;

  if (LevelUp) then
  begin
    MSI_SubDebug('MSI_FindRandoms: Player has leveled up!');
    stats_IncVariable('Total Levels Gained', 1);
  end;

  if (NextRandCheck > GetSystemTime) then
    Exit;

  MSI_SubDebug('Scanning for randoms...');
  {$IFDEF REFLECTION}
    Result := R_SolveNonTalkingRandoms;
  {$ELSE}
    begin {Taken from SRL's FindNormalRandoms (mouse movements removed)}
      if (SRL_OnFindRandomCall <> nil) then
      begin;
        Result := SRL_OnFindRandomCall(cont);
        if not Cont then
          exit;
      end;
      for I := 1 to 6 do
      begin
        case I of
          1: Result := SolveTeleportRandoms;
          2: Respond;
          3: Result := FindDead;
          4: Result :=  RC;
          5: Result := FindMod;
          6: if (SRL_Procs[srl_OnRandomCall] <> nil) then
               SRL_Procs[srl_OnRandomCall]();

        end;
        if (Result) then
        begin
          if (SRL_Procs[srl_OnFindRandom] <> nil) then
            SRL_Procs[srl_OnFindRandom]();
          Break;
        end;
      end;
    end; //End SRL's Func.
  {$ENDIF}
  if Result then
    MSI_SubDebug('MSI_FindRandoms: Finished Random Event!')
  else
    if (not LoggedIn) then
      MSI_Players[CurrentPlayer].ReportInfo.FalseReason := 'Failed to solve random';

  NextRandCheck := GetSystemTime + MSI_SetupVars[SETUP_RANDOMS_WAIT];
end;                                                    

It's currently used for the Alching script to avoid tab clicking and all other mouse movements. If anyone can come up with a better way to go about this, please feel free to, I just through it together for something to work so I can test. CREDIT WILL BE GIVEN! If no one posts anything about it I will eventually do something about it, but it works for now.

If you want to have a look at all the antiban stuff it's all in /MSI/Antiban.Simba.

I'm not sure if it's been committed to the main repo yet though so you may have to switch to my Git to test it. I'm pretty I may have made a couple small changes since that last commit, but I don't think it's anything that can't wait until I finish cooking and commit everything.

Note: None of this will be committed to the main Git branch until everything is proven to actually be working. Currently my Git branch has the basic bits of what I had done as of a week or so ago. I've made a few changes since then, but I will update when I feel it's necessary.

Edit: Also, I'm open to new names for the function. :redface:

Woah.. didn't think the idea would be supported… it has been the core idea for all my scripts
I'm glad you guys agree :)

From: Zyt3x
Woah.. didn't think the idea would be supported… it has been the core idea for all my scripts
I'm glad you guys agree :)

Care to make a new suggestion thread outlining your idea and how people can contribute?

E: We kind of went away from what the thread was actually about. England, we're sorry, none of us are experiencing this problem, so it's hard to find out exactly what is wrong. :(

From: NCDS
This is the current MSI_NoMouseFindRandoms;

function MSI_NoMouseFindRandoms: Boolean;
var
  I: Byte;
  Cont : boolean;
begin
  if (not LoggedIn) then
    Exit;

  if (LevelUp) then
  begin
    MSI_SubDebug('MSI_FindRandoms: Player has leveled up!');
    stats_IncVariable('Total Levels Gained', 1);
  end;

  if (NextRandCheck > GetSystemTime) then
    Exit;

  MSI_SubDebug('Scanning for randoms...');
  {$IFDEF REFLECTION}
    Result := R_SolveNonTalkingRandoms;
  {$ELSE}
    begin {Taken from SRL's FindNormalRandoms (mouse movements removed)}
      if (SRL_OnFindRandomCall <> nil) then
      begin;
        Result := SRL_OnFindRandomCall(cont);
        if not Cont then
          exit;
      end;
      for I := 1 to 6 do
      begin
        case I of
          1: Result := SolveTeleportRandoms;
          2: Respond;
          3: Result := FindDead;
          4: Result :=  RC;
          5: Result := FindMod;
          6: if (SRL_Procs[srl_OnRandomCall] <> nil) then
               SRL_Procs[srl_OnRandomCall]();

        end;
        if (Result) then
        begin
          if (SRL_Procs[srl_OnFindRandom] <> nil) then
            SRL_Procs[srl_OnFindRandom]();
          Break;
        end;
      end;
    end; //End SRL's Func.
  {$ENDIF}
  if Result then
    MSI_SubDebug('MSI_FindRandoms: Finished Random Event!')
  else
    if (not LoggedIn) then
      MSI_Players[CurrentPlayer].ReportInfo.FalseReason := 'Failed to solve random';

  NextRandCheck := GetSystemTime + MSI_SetupVars[SETUP_RANDOMS_WAIT];
end;                                                    

It's currently used for the Alching script to avoid tab clicking and all other mouse movements. If anyone can come up with a better way to go about this, please feel free to, I just through it together for something to work so I can test. CREDIT WILL BE GIVEN! If no one posts anything about it I will eventually do something about it, but it works for now.

If you want to have a look at all the antiban stuff it's all in /MSI/Antiban.Simba.

Is there anything wrong with this procedure like is there a bug or something?

Anything concerning the topic about more human anti-ban should be posted here: http://villavu.com/forum/showthread.php?t=63219

I re-downloaded MSI and it seems to have fixed itself.

All it did was show the text "MSI_AntiBan" in the debug box of Simba and then nothing. The script wouldn't continue or terminate. I guess this thread can be closed.

From: yago
Is there anything wrong with this procedure like is there a bug or something?

No I just don't like the fact that it's basically SRL's FindNormalRandoms embedded in a few other lines of code. I would much rather go about it a different way (code-wise) but the functionality is exactly what we're looking for.

It's really not a priority of any kind, just an annoyance when looking at the code.

From: england155
I re-downloaded MSI and it seems to have fixed itself.

All it did was show the text "MSI_AntiBan" in the debug box of Simba and then nothing. The script wouldn't continue or terminate. I guess this thread can be closed.

Glad it's working again. :)

I'm having the same issue. The script randomly terminates with MSI_AnitBan as the last line. I've reinstalled everything multiple times to no avail.