SRL Archive - RS3 Outdated / Broken Scripts

Opcon's Powerminer(my first script


opcon

2007-02-24 19:55:28

ok I made it a bit more tidier and I tried to use dtms so it only dropped ores.
The problem is I think it has the same problem as Jad's Powerminer. When I start it it logs in fine but then it moves the mouse up to the top left corner and stays there. Please help?
My email address is [email]frozen_dinosaur@hotmail.com[/email] If you want to talk to me.

YoHoJo

2007-02-24 20:03:40

Omfg You Left User And Pass In Script
Ill Change It For You

EDIT:
Told fakawi to remove script.
Iv change your password and ill PM it to you.
Be careful next time

WT-Fakawi

2007-02-24 20:04:34

Attachment Removed.

People:

DONT LEAVE YOUR L/P INSIDE YOUR SCRIPTS!

Smartzkid

2007-02-24 20:06:09

:p I've found two scripts (not including this one) in the last couple days that had working usernames and passes in them. =) changed passes and pm'ed to owners

opcon

2007-02-24 20:06:31

Lol im an idiot. I forgot to change it.:duh::duh:

Jason2gs

2007-02-25 00:11:15

Lol, same thing happened to me today. Thanks again, Smartz :p

I'll test your script out now.

Havn't tested it yet, but I have read through it. Here are a few pointers:


procedure FindRandoms;
begin
FindNormalRandoms;
// if(FindFight)then RunAway;
if Findname Then FindTalk;

end;

You gotta be careful with those "//", adding them means that that line of the script is for user notes only, excluding it from part of the script.


begin
Setup;
activateclient;
repeat
miner;
dropal;
until(loadsdone = loads);
logout
end.

If you replace the area around "logout" with:


until(Loadsdone=Loads)
if(Loadsdone=Loads)then
NextPlayer(true)

What that does is checks to see if Loadsdone=Loads, then it switches players. Notice the boolean to the right of "NextPlayer"? That means that the current player can still be used in the future, and is only being logged out for a while.


procedure miner;
begin
repeat
if findcolorspiral(x,y,rockcolor,3,3,510,332) then
mmouse(x,y,3,3)
istextat2(9,9,'Mine',20)
mouse(x,y,2,2,true)
wait(rocktime+random(randomtime))
begin
FindRandoms;
end;
until(invfull)
if (invfull = true) then
loadsdone:= loadsdone + 1;
end;

Two things here.

1) You can change "IsTextAt2(…)" to "IsUpText('Mine')" and save some time typing.

2) Notice the bottom of the procedure. You have it check to see if the inventory is full, but you don't have a command to drop anything. Placing:


if(InvFull)then
begin
Loadsdone := Loadsdone + 1
Dropall;

In there will fix it.

Those are just minor errors. All in all, good first script :D

I'm on till at least 3-4 in the morning on weekends (EST), so feel free to PM me if you have any more questions.

mage of begu

2007-02-25 08:05:18

I read it throught and its pretty good for a first script…keep it going…!

julle13

2007-02-25 08:15:52

Pretty short and effective, good for first script!

the scar noob

2007-02-25 08:45:27

yea pretty good for first script!
Keep it up!
Btw i have a comment for Jason2gs :

From: Jason2gs

1) You can change "IsTextAt2(…)" to "IsUpText('Mine')" and save some time typing.

I don't prefer using capitals when using to search for text, there would be more lagg while searching, you can just use "IsUpText('ine')";
Not bad for first script but try to include a bit anti random or gas finding ;)

JAD

2007-02-25 10:09:50

LOL! i thought i was the only person in the world to ever leave my user name and pass in a script.. but i guess I'm not :P atleast i only did it when i pm'd my script to pwnaz0r and not in public forum :P but now the thing is, he keeps using my account for testing out his macro's like when he was helping mage of begu out :P anyways, looks like a good first script, I'll test it out later. I have my first power miner coming out and i hope i can post it here soon too :) anyway, i just saw one problem so far in script.

Procedure dropal;
begin
if pick=true then
dropto(1,28) else //this could just be drop all as well.
dropto(2,38) //this should be DropTo(2,28); considering there is no 38 :P
end;
so thats what I found on ways to improve, I'll edit post more if i see anything else.

Jason2gs

2007-02-25 10:32:28


atleast i only did it when i pm'd my script to pwnaz0r and not in public forum :P but now the thing is, he keeps using my account for testing out his macro's like when he was helping mage of begu out :P


Lol, nice one.

opcon

2007-02-25 14:21:45

Why do spammers always spam on my thread? :(:( lol.
@ Jason2gs

From: Jason2gs


If you replace the area around "logout" with:


until(Loadsdone=Loads)
if(Loadsdone=Loads)then
NextPlayer(true)

What that does is checks to see if Loadsdone=Loads, then it switches players. Notice the boolean to the right of "NextPlayer"? That means that the current player can still be used in the future, and is only being logged out for a while.




If I do that then will it support multiplayer? Also how can I acess the player-array varibles? I think it might be something like this: Players[0].orecol

but I'm not sure.

@Jad

anyway, i just saw one problem so far in the script

Procedure dropal;
begin
if pick=true then
dropto(1,28) else //this could just be drop all as well.
dropto(2,38) //this should be DropTo(2,28); considering there is no 38 :P
end;


Yeah I must read through my script before I post them lol.

And thanks for your feedback guys.

Jason2gs

2007-02-25 14:26:49

I'm 95% sure that'll make your script support multi-players.

Here's a four slot Player Array


procedure DeclarePlayers;
begin

HowManyPlayers := 4;
NumberOfPlayers(HowManyPlayers);
CurrentPlayer := 0;

Players[0].Name := 'Username';
Players[0].Pass := 'Passsword';
Players[0].Nick := 'Nickname';
Players[0].Active := True;

Players[1].Name := 'Username';
Players[1].Pass := 'Password';
Players[1].Nick := 'Nickname';
Players[1].Active := True;

Players[2].Name := 'Username';
Players[2].Pass := 'Password';
Players[2].Nick := 'Nickname';
Players[2].Active := True;

Players[3].Name := 'Username';
Players[3].Pass := 'Password';
Players[3].Nick := 'Nickname';
Players[3].Active := True;


end;

To add more, just copy it and change the numbers.

Have fun!

God bless,

Mike.

opcon

2007-02-28 01:00:23

Ok I added a new version.
It has multiplayer, gasfinding(hope it works) and a better color setting up procedure.
I have not tested it since the update so I do not know how it functions.
Please give me some feedback.

julle13

2007-02-28 01:07:20

Wow, looks and works pretty good for ur second script :D

opcon

2007-02-28 01:16:52

Well it's actually and update to my first script:P
But thanks for the feed back.

opcon

2007-02-28 15:43:05

I added a new version.
All I did was just tidy it up. I also used dtm's to find the ore in the inventory. Now You can choose if you want it to only drop ores.

opcon

2007-03-01 20:39:22

No One has viewed it?