SRL Archive - SRL Bugs

Title says it all :L

Try the number instead.

the constant is a number, it would make no difference. GetCurrentGameTab results in 27 when on the prayer tab, which is the same as tab_Prayer, so it's not detecting it wrong, it's simply not clicking.

Ok just checking if maybe the constant was wrong … I haven't tried the prayer tab myself in a while.

From: TomTuff
the constant is a number, it would make no difference. GetCurrentGameTab results in 27 when on the prayer tab, which is the same as tab_Prayer, so it's not detecting it wrong, it's simply not clicking.

BUMP

just almost started a thread with the same title. decided to search first ;)

GameTab(27);
GameTab(tab_Prayer);
DOESN"T WORK
all other gameTab's work…
Need an SRL fix ;)

If the people that report bugs also includes a fix for it, then the chances of it being fixed quickly increases greatly :)

Just sayin'

From: Zyt3x
If the people that report bugs also includes a fix for it, then the chances of it being fixed quickly increases greatly :)

Just sayin'

Maybe if I knew what "mod" and "div" do :garfield:

5 div 2 = 2
5 mod 2 = 1

div is how many times it's possible to divide 5 by 2
mod gets what's left after you've done "5 div 2"

the bug was in TabExists.

Patch:

function TabExists(Tab: Integer): Boolean;
var
  tP: TPoint;
begin
  Result := false;
  if (not loggedIn) then
    exit;

  if (tab < 20) then
  begin
    SRL_Warn('TabExists', 'Tab ' + IntToStr(Tab) + ' is not using the new constants! Please upgrade your script.', warn_AllVersions);
    Exit;
  end;

  if (not(InRange(Tab, Tab_Combat, Tab_LogOut))) then
  begin
    SRL_Warn('TabExists', 'Tab ' + IntToStr(Tab) + ' is not a valid tab number.', warn_AllVersions);
    Exit;
  end;

  if (Tab = tab_LogOut) then
  begin
    Result := (GetColor(746, 0) = 65536);
    Exit;
  end;

  tP := Point(((Tab - 21) mod 8 * 30) + 536, ((Tab - 21) div 8 * 298) + 187);
  if (Tab <> tab_Prayer) then
    Result := FindColorTolerance(tP.X, tP.Y, 591881, tP.X - 12, tP.Y - 12, tP.X + 12, tP.Y + 12, 15)
  else
    Result := FindColorTolerance(tP.X, tP.Y, 16448761, tP.X - 12, tP.Y - 12, tP.X + 12, tP.Y + 12, 15);
end; 

function TabExists2(Tab: Integer): Boolean;
var
  tP: TPoint;
  srcCol : Integer;
begin
  Result := false;
  if (not loggedIn) then
    exit;

  if (tab < 20) then
  begin
    SRL_Warn('TabExists', 'Tab ' + IntToStr(Tab) + ' is not using the new constants! Please upgrade your script.', warn_AllVersions);
    Exit;
  end;

  if (not(InRange(Tab, Tab_Combat, Tab_LogOut))) then
  begin
    SRL_Warn('TabExists', 'Tab ' + IntToStr(Tab) + ' is not a valid tab number.', warn_AllVersions);
    Exit;
  end;

  if (Tab = tab_LogOut) then
  begin
    Result := (GetColor(746, 0) = 65536);
    Exit;
  end;

  case Tab of
    tab_Prayer: srcCol := 16448761;
  else
    srcCol := 591881;
  end;

  tP := Point(((Tab - 21) mod 8 * 30) + 536, ((Tab - 21) div 8 * 298) + 187);
  Result := FindColorTolerance(tP.X, tP.Y, srcCol, tP.X - 12, tP.Y - 12, tP.X + 12, tP.Y + 12, 15); 
end;

:)

From: Zyt3x
If the people that report bugs also includes a fix for it, then the chances of it being fixed quickly increases greatly :)

Just sayin'

I wish the same happened to me… :(

  if (Tab <> tab_Prayer) then
    Result := FindColorTolerance(tP.X, tP.Y, 591881, tP.X - 12, tP.Y - 12, tP.X + 12, tP.Y + 12, 15)
  else
    Result := FindColorTolerance(tP.X, tP.Y, 16448761, tP.X - 12, tP.Y - 12, tP.X + 12, tP.Y + 12, 15);
end;

  case Tab of
    tab_Prayer: srcCol := 591881;
  else
    srcCol := 16448761;
  end;

Am I the only one that sees something wrong here? o.o

From: Train

  if (Tab <> tab_Prayer) then
    Result := FindColorTolerance(tP.X, tP.Y, 591881, tP.X - 12, tP.Y - 12, tP.X + 12, tP.Y + 12, 15)
  else
    Result := FindColorTolerance(tP.X, tP.Y, 16448761, tP.X - 12, tP.Y - 12, tP.X + 12, tP.Y + 12, 15);
end;

  case Tab of
    tab_Prayer: srcCol := 591881;
  else
    srcCol := 16448761;
  end;

Am I the only one that sees something wrong here? o.o

What? It's just two different ways to do the same thing.

  if (Tab <> tab_Prayer) then
    Result := FindColorTolerance(tP.X, tP.Y, 591881, tP.X - 12, tP.Y - 12, tP.X + 12, tP.Y + 12, 15)
  else
    Result := FindColorTolerance(tP.X, tP.Y, 16448761, tP.X - 12, tP.Y - 12, tP.X + 12, tP.Y + 12, 15);
end;

If Tab is not equal to tab_Prayer, color is 591881.
Else (it's equal), color is 16448761.

  case Tab of
    tab_Prayer: srcCol := 591881;
  else
    srcCol := 16448761;
  end;

If Tab is equal to tab_Prayer, color is 591881.
Else, it's not equal, color is 16448761.

From: Train

  if (Tab <> tab_Prayer) then
    Result := FindColorTolerance(tP.X, tP.Y, 591881, tP.X - 12, tP.Y - 12, tP.X + 12, tP.Y + 12, 15)
  else
    Result := FindColorTolerance(tP.X, tP.Y, 16448761, tP.X - 12, tP.Y - 12, tP.X + 12, tP.Y + 12, 15);
end;

If Tab is not equal to tab_Prayer, color is 591881.
Else (it's equal), color is 16448761.

  case Tab of
    tab_Prayer: srcCol := 591881;
  else
    srcCol := 16448761;
  end;

If Tab is equal to tab_Prayer, color is 591881.
Else, it's not equal, color is 16448761.

I'm right he's wrong neener neener. Someone just commit it? lol

No actually, that was a mistake on my part

Thanks Train :)

Committed.