SRL Archive - Bugs

during a procedure which is almost exclusivly dealing with objects, my memory usage went from 169,000 to 411,000.

Here is procedure

function R_BestYCoordinate(MinY, MaxY: Integer): Integer;
{checks the coordinates between MinY and MaxY to
see which row has the least fires on them.}
var
  I: Integer;
  Possibles, FiresOnLine: TIntegerArray;
  Fires: TRSObjectArray;
begin
  Fires := GetObjectsByID(FireID, 0, 50);
  SetLength(FiresOnLine, MaxY - MinY + 1);
  for I := 0 to High(Fires) do
    if InRange(Fires[I].Tile.y, MinY, MaxY) then
      Inc(FiresOnLine[Fires[i].Tile.y - MinY]);
  for I := 0 to High(FiresOnLine) do
    if (FiresOnLine[i] = TMin(FiresOnLine)) then
      Possibles := CombineIntArray(Possibles, [I]);
  Fires := []; //Im even trying to free them here! no effect
  Result := Possibles[Random(Length(Possibles))] + MinY;
end;   

it doesn't work 100% of the time for me, but it does work sometimes. I do this:

function Example: Boolean;
var
  Ojs: TRSObjectArray;
  i: Integer;
begin
  //Finding npcs
  NPCs := GetAllObjects(333);
  //Do what you need to
  //free them
  for i := 0 to High(Objs) do
    NPCs[i] := NULL_RSOBJECT;
  SetLength(Objs, 0);
end;

Setting the length to 0 seems to work more often than := [];. Wish I knew how to fix it.

Is it possible this is an error within Pascal Script?

From: Bad Boy JH
during a procedure which is almost exclusivly dealing with objects, my memory usage went from 169,000 to 411,000.

Here is procedure

function R_BestYCoordinate(MinY, MaxY: Integer): Integer;
{checks the coordinates between MinY and MaxY to
see which row has the least fires on them.}
var
  I: Integer;
  Possibles, FiresOnLine: TIntegerArray;
  Fires: TRSObjectArray;
begin
  Fires := GetObjectsByID(FireID, 0, 50);
  SetLength(FiresOnLine, MaxY - MinY + 1);
  for I := 0 to High(Fires) do
    if InRange(Fires[I].Tile.y, MinY, MaxY) then
      Inc(FiresOnLine[Fires[i].Tile.y - MinY]);
  for I := 0 to High(FiresOnLine) do
    if (FiresOnLine[i] = TMin(FiresOnLine)) then
      Possibles := CombineIntArray(Possibles, [I]);
  Fires := []; //Im even trying to free them here! no effect
  Result := Possibles[Random(Length(Possibles))] + MinY;
end;   

Don't you have to free all objects with SmartFreeObject?

I wonder if this is where I'm going wrong with my LandScorcher script. I know it's something I must have over-looked with reflection, because it doesn't seem to last but just a matter of minutes before Smart and Simba crash on me. If someone wants to take a look at it or test it and tell me what you think, that'd be wonderful. I'm still very new to reflection, so bare with me. :unsure:

Just a suggestion, but if you're having trouble with objects, you can always use TileToMS and check for uptext of the object. It's what I do and it hasn't failed me yet.

Yep I have the TileToMS and even TileToMM if the tile isn't in view on the main screen.