SRL Archive - Reflection Development

I am no expert with this or anything, but I am pretty sure try/except case will stop R_GetUpText from giving out of range errors. It compiled fine and ran fine for 4 hours without issues (albeit the issue not happening frequently to begin with, but frequently enough to be annoying), and I hope it stays that way.

Try it out:

function R_GetUpText: string;
var
  MenuOptions: TStringArray;
  First: String;
begin
  MenuOptions := GetMenuText;
  try
    First := Trim(MenuOptions[0]);
    Result := First;
    if (Length(MenuOptions) > 1) and (Result <> '') then
      Result := Result+' / '+inttostr(Length(MenuOptions))+' more options';
  except
    WriteLn('R_GetUptext failed!');
    Result := '';
  end;
end;

Might be a good commit if it runs well for you – seems to fix the issue for me.

How is it possible for this function to fail, it'd be GetMenuText.

GetMenuText results nothing at all, and then R_GetUpText tries to use [0], which does not exist, which then gives an out of range error. The try-except will fix R_GetUpText from crashing, and will instead result nothing and exit. It's a cleaner fix than making GetMenuText result something, when it really got nothing.

From: Harry
GetMenuText results nothing at all, and then R_GetUpText tries to use [0], which does not exist, which then gives an out of range error. The try-except will fix R_GetUpText from crashing, and will instead result nothing and exit.

It should re-run the GetMenuText, not just quit.

From: Train
It should re-run the GetMenuText, not just quit.

I don't think so; it would cause the procedure to be rerun instantly which is probably not a good idea (it's a pretty bad error if GetMenuText results nothing, which could mean RS has something wrong with it and it SHOULDN'T be rerun instantly). It's rare enough to begin with, and if it happens the script will still run fine. The point of this fix is to make Simba so it doesn't crash, which is exactly what it does :)

From: Harry
I don't think so; it would cause the procedure to be rerun instantly which is probably not a good idea (it's a pretty bad error if GetMenuText results nothing, which could mean RS has something wrong with it and it SHOULDN'T be rerun instantly). It's rare enough to begin with, and if it happens the script will still run fine. The point of this fix is to make Simba so it doesn't crash, which is exactly what it does :)

I would push it to the repository, but I have yet to gain srl-reflection dev access.

From: Train
I would push it to the repository, but I have yet to gain srl-reflection dev access.

If at all, seeing your reputation here smells…

Harry, why don't you send in patch or just wait for someone with access here to commit it? :)

From: Wizzup?
If at all, seeing your reputation here smells…

Harry, why don't you send in patch or just wait for someone with access here to commit it? :)

Not everyone hates me, and SRL-reflection is at a short-hand of developers. I'm sure a few can vouch for me.

From: Harry
I am no expert with this or anything, but I am pretty sure try/except case will stop R_GetUpText from giving out of range errors. It compiled fine and ran fine for 4 hours without issues (albeit the issue not happening frequently to begin with, but frequently enough to be annoying), and I hope it stays that way.

Try it out:

function R_GetUpText: string;
var
  MenuOptions: TStringArray;
  First: String;
begin
  MenuOptions := GetMenuText;
  try
    First := Trim(MenuOptions[0]);
    Result := First;
    if (Length(MenuOptions) > 1) and (Result <> '') then
      Result := Result+' / '+inttostr(Length(MenuOptions))+' more options';
  except
    WriteLn('R_GetUptext failed!');
    Result := '';
  end;
end;

Might be a good commit if it runs well for you – seems to fix the issue for me.

Try-catch/except is good practice anyways. I don't see why it should ever have an error (unless I'm missing something), but since you have the issue, I've committed your fix :). Hope it fixes it for anyone else who has it.

There are ways to make Walk here not appear, such as having the mouse high on the screen, with angle low, and nothing where your mouse is.
Runescape won't register a tile that far away as something it can walk to, and there are no other options resulting in GetMenuText having a length of 0.

What ever happened to SRL's "GetUpText"? It works like a charm, so why not forget this reflection and use what we've had all along?

From: Flight
What ever happened to SRL's "GetUpText"? It works like a charm

"Lol" is all I have to say. Color GetUpText is far from perfect and this bug has been fixed.