SRL Archive - Bugs

Banking after today's one-click-bank commit


Harry

2011-03-02 00:14:34

https://github.com/SRL/srl-reflection/commit/4600094b911570dd83bd891031d6da85ed9faa0c#L0R861

You call IsUpTextMultiCustom for Bank chests, which, if I recall correctly, will match if ANY string is given. —> it will one-click banks that aren't one-click. Please fix or remove it (maybe something like this would work well:
if IsUpTextMultiCustom(['ank', 'ooth']) then // BEFORE 'ank','hest'
...Double-click bank code here...
else if IsUpTextMultiCustom(['ank', 'hest']) then // AFTER booth
....one-click bank code here.....

The way it is in the commit right now is horribly broken and must be changed. Thanks.

Train

2011-03-02 00:59:52

Submit a pull request and hope for the best? :unsure:

Harry

2011-03-02 02:17:38

I'll wait for a dev to see it, can't be bothered forking on git right now.

pyroryan

2011-03-02 09:55:51

Pushed. Sorry about that D: