SRL Archive - SRL Bugs

Login/World switch fixes


Harry

2011-03-01 01:48:37

1) "Not logged out from last session" does not work ( http://i.imgur.com/Y3SAm.png ). Running CountColor(LOGIN_TEXTCOLOUR, 260, 140, 510, 400) on that screen -> "951" (you'd just need to plug that into the case statement; I am sure you know what to plug in @ line 671).

2) PVP worlds do not exist anymore and are now know as "high risk wilderness" worlds. Won't detect if the error/warning message for them pops up, and won't hit back. Mousebox is also incorrect.
Fixed both: it's now "82" instances of color instead of the former "210". Mousebox is fixed as well (GO LOGIN = 391, 361, 498, 383) (GO BACK = 263, 362, 372, 383, 1).
if (CountColor(clWhite, 415, 336, 476, 356) = 82) then //PVP login button white colour points
begin
if (Length(Players[CurrentPlayer].WorldInfo) > 2) then
begin
if (Players[CurrentPlayer].WorldInfo[2]) then
MouseBox(391, 361, 498, 383, 1) //HRW go login fixed
else
MouseBox(263, 362, 372, 383, 1); //Go back fixed
end
else
if (AllowPVP) then
MouseBox(391, 361, 498, 383, 1)
else
MouseBox(263, 362, 372, 383, 1);
Wait(3000 + Random(2000));
end;

3) Worldswitcher line 362 - Bounty and PVP in the Pos should both be removed and replaced with 'ilderne' (wilderness).
WorldRec.PVP := (Pos('ildern', WorldRec.Activity) > 0);

I think those are the only needed fixes. It should work fine now. Try it out.

Edit: for #2, when it clicks "back", SRL thinks you finished logging in. Don't have time to mess with it right now, but most scripts should handle it properly – at least it doesn't infinite loop now :) It was pre-existing like that, I didn't change anything other than updating the box coords and colorcount.

cycrosism

2011-03-01 03:55:11

I also think the world changer should be set to disabled by default

Just then when I ran an MSI script it selected a world which said "Running - Air Runes" or something and just as the world was loading Simba + Smart crashed.

Should be disabled by default and only people who want it should enable it

Wanted

2011-03-01 14:29:24

From: cycrosism
I also think the world changer should be set to disabled by default

Just then when I ran an MSI script it selected a world which said "Running - Air Runes" or something and just as the world was loading Simba + Smart crashed.

Should be disabled by default and only people who want it should enable it


The switcher is disabled by default. Only WorldInfo overrides it, MSI has always used the world switcher.

NCDS

2011-03-01 14:32:06

From: cycrosism
I also think the world changer should be set to disabled by default

Just then when I ran an MSI script it selected a world which said "Running - Air Runes" or something and just as the world was loading Simba + Smart crashed.

Should be disabled by default and only people who want it should enable it


From: IceFire908
The switcher is disabled by default. Only WorldInfo overrides it, MSI has always used the world switcher.


Just change 'MSI_SetupVars[SETUP_SWITCH_WORLDS] := True;' to False;

Wanted

2011-03-01 14:33:02

Which is completely separate from SRL…

NCDS

2011-03-01 14:41:39

From: IceFire908
Which is completely separate from SRL…


…Clearly. Oops, I read the post I quoted from you wrong.

Anyways..What all broke with todays update as far as login goes and is anyone working on anything yet? I'm about to have a look in just a few minutes if no one else is yet.

Harry

2011-03-01 14:53:59

Jeez Jagex, I go and edit some stuff and you break it the next day :(

I have some stuff I need to do IRL, but I'll try to update it tomorrow if no one else does.

Coh3n

2011-03-01 14:59:25

I'll work on it now. :)

E: All three committed.

Floor66

2011-03-01 15:34:51

I've got a little fix :p
http://villavu.com/forum/showthread.php?p=784397#post784397

NCDS

2011-03-01 16:04:07

From: Floor66
I've got a little fix :p
http://villavu.com/forum/showthread.php?p=784397#post784397


We got them taken care of now ;) Thanks though :)