SRL Archive - MSI Suggestions

So I'm not sure how to give other people direct access to the repository (not sure if I want to either, no offense), so just fork it and send pull requests to help out. We'll discuss what should be included here. Also keep in mind that there's no rush by any means. I don't expect this to be done any time soon. You should focus of fixing any existing bugs before working on this.

MSI Form v2.0

Features

• Player adding/deleting/editing/loading/saving.
• Multiple player file loading/saving.
• Player groups so each member of the group would have the same settings.
• Our standard settings + advanced settings (two tabs in the "Script Settings" panel).

Notes

• Include all rocks/trees, not just default in script setup form.
• "Active" field to TScriptSetup (treat like multiplayer) for multiple script support.
• Dan's alternative TTreeView concept for script selection list.
• A "Apply Settings to All" check box that applies current settings to all players.
• Act as player remote (could use IsFKeyDown with SMART 6.7+)
• Entire form written in extension possibly (should work with only including Globals.simba and Scripts.simba.

Yep. Feel free to throw out your suggestions.

P.S. I'm going to be very strict about standards and documentation. This will keep things neat and organized and make it easier for people to learn from. Here's a guide that will probably help us out a lot during this process.

Updated repository.

Sweet menu! :D

From: Zyt3x
Sweet menu! :D

It's a start. :p Took me forever to figure out how to actually do it. Had to refer to Dan's form tutorial.

Updated a little bit. I have TSaveDialof and TOpenDialog working and I experimented with them a little. If you guys have ANY design ideas whatsoever please post them. I still don't know the best way to make it simple and organized and cover all of MSI's features and setup requirements.

Ok, so I've come up with different ideas that could be done for Form 2.0:

The first idea I had is the daughter of the current form and Coda, which would really just mean a cleanup of the current form as opposed to something brand new. Picture:



#2 is a bit out there, but I think if it could be pulled off on the programming side it would be pretty awesome. Essentially, we have the user input their player data, then clicking on an icon on the world map would allow them to select which players they want to run with that script (this would also make choosing multiple scripts in the future easy to do). I borrowed Zyt3x's map for the picture idea:
http://zytex.x10hosting.com/srl/msi/Output.jpg



Lastly, I think it would be AWESOME if we had something like a Twitter feed that would open up after MSI began running. It could show whatever we wanted it to show, here's a quick concept:

Lemme hear your thoughts, the Form is probably going to be my next project for awhile.

I'm not sure what you had in mind about Coda, explain that further? About just cleaning up the current form: we could yeah, but because the form size relies on the bitmaps, it's not easily expandable. Plus the code is bad. It would just be a lot more trouble than it's worth. We may as well start from scratch.

The map thing - that was actually suggested (and almost completed) for the original form. You could probably still find the code in the old repository. I'm sure it'll still work just fine, it's just a matter of finding it. You could drag around the map and everything. It was pretty cool. I think it's a neat idea, but I don't think it's necessary. It's something that's pretty complicated that doesn't really serve much point other than it's cool.

The whole point of creating a new form was to keep it simple. The one we have now is way over-complicated with features that sounded good at the time and didn't work out as well as people thought. What we want for this form is to have the features the users want (i.e. what's in the first post).

Having a 'View Map' option under the Tools menu or something will work just fine. That way we don't have to have the giant world map bitmap in the include. I think the best idea is to keep the code/include as clean (almost no bitmaps; may need one for the background) as possible.

In your image, do the arrows represent like a "Next" button to go to the next player or page? Here's a layout that I had suggested for the original form (with a few modifications):


The arrows would go to the next player. I forgot to add the player list also, which I think should go on the left side of the Player Setup tab.

IPwnz, all of those ideas will be added to a new Player Remote system I'm making :)

E: Perhaps the player remote system could be used for setting up players..? I haven't actually though about it, but it would be possible….

From: Zyt3x
IPwnz, all of those ideas will be added to a new Player Remote system I'm making :)

E: Perhaps the player remote system could be used for setting up players..? I haven't actually though about it, but it would be possible….

Probably wouldn't be a bad idea. That way, users could completely reset their players during runtime.

From: Coh3n
I'm not sure what you had in mind about Coda, explain that further?

Coda has a fancy-schmancy content slider which is very similar to the one in the current form, but with tabs on top.

From: Zyt3x
Perhaps the player remote system could be used for setting up players..? I haven't actually though about it, but it would be possible….

That would serve the dual purpose of cleaning up the form and making it easier to manage players while MSI is running, so I would be all for that.

From: Coh3n
Probably wouldn't be a bad idea. That way, users could completely reset their players during runtime.

The idea is that the user can control everything the script is doing, and I want to make it so that the user can simply click on a mini-map and select Walk Here, and the account will walk there (and you can watch it walking in real-time), but I'm unsure how to do that with php, so the most advanced stuff will probably be on Simba unless I make a Java applet to do the same stuff Simba will do

From: Coh3n
Probably wouldn't be a bad idea. That way, users could completely reset their players during runtime.

Depends how simple it is, otherwise it's just another step in setting things up.

Zyt3x, sounds complicated. :p

From: Coh3n
Zyt3x, sounds complicated. :p

Nah, it's not really that complicated :D
It's just that I haven't got much experience with either Java or PHP :/

From: Zyt3x
Nah, it's not really that complicated :D
It's just that I haven't got much experience with either Java or PHP :/

Just make sure if you're working on something like that it'll be worth it. Something that people will actually use, y'know?

From: Coh3n
Just make sure if you're working on something like that it'll be worth it. Something that people will actually use, y'know?

I'll use it :redface:

But yeah, I'll make it really user-friendly :)

Menu
~ Walk To
- - - LB ~Lumbridge
- - - EV ~Edgeville
- - - T (Tx, Ty) ~ Tile: (x, y);
- - - R (Rx, Ry) ~ RTile: (x, y);

~ Script
— Loc
— Activity

Players
— Status
— Progs
— Reset
— Remote

I would like to see a cool menu like the one above

~RM

From: Sir R. M8gic1an
Menu
~ Walk To
- - - LB ~Lumbridge
- - - EV ~Edgeville
- - - T (Tx, Ty) ~ Tile: (x, y);
- - - R (Rx, Ry) ~ RTile: (x, y);

~ Script
— Loc
— Activity

Players
— Status
— Progs
— Reset
— Remote

I would like to see a cool menu like the one above

~RM

I'll make it graphical

Did a little more work on this last night. Not much.

1. I'm thinking that we'll have a popup window show to set all the script settings when you click Tools > Settings. Either that or we have two tabs (like I suggested earlier), one for script setup (i.e. settings), and one for the player setup. If the latter, then Tools > Settings would bring up an advanced settings window.
2. For specific script setup, I was thinking a popup would work well just like it does for the current one. However, this one would be set by a single type (TSkillForm) that will determine the components, the number of components, and the size of the form. It would probably be loaded like we do with Animations (function returning a type), or close to it.

I would like opinions for both issues above if it's not too much trouble. :)

From: Coh3n
I'm thinking that we'll have a popup window show to set all the script settings when you click Tools > Settings. Either that or we have two tabs (like I suggested earlier), one for script setup (i.e. settings), and one for the player setup. If the latter, then Tools > Settings would bring up an advanced settings window.

I'd say the less windows the better. The 5 windows/tabs we use right now is ridiculous, and fairly overwhelming to a first-time user. If we can confine everything into two tabs and still maintain functionality, we should. I also like the idea of keeping advanced options around for people who want them, whether that's through a menu or a button option.

From: Coh3n
For specific script setup, I was thinking a popup would work well just like it does for the current one. However, this one would be set by a single type (TSkillForm) that will determine the components, the number of components, and the size of the form. It would probably be loaded like we do with Animations (function returning a type), or close to it.

Also good, I know you've been complaining about having to make edits to the current form to incorporate cooking (or any new skill), so if we can make it so the form gets automatically updated with this stuff so there is less work in the future then we should do it.

Thanks. :) I'll work on having two tabs (one for script setup, and one for player setup). Here's what I have for the player setup so far. I just pushed since I have to leave for a bit.


I feel like it's getting quite large. =\

Here's what I'm thinking:

————–
Step 1: Choosing a Skill
—————

Skill List
[INDENT]+ Mining
+ Fishing
+ Cooking
+ Woodcutting[/INDENT]


——————————–
Step 2: Choosing a skill
————————-

Skill List
[INDENT]+ Mining
[INDENT]
[[ ]] Location list
[ - ] Varrock East
[ - ] Varrock West
[ - ] Lumbridge East
[ - ] Lumbridge West
[ - ] Rimmington
[ - ] Mining Guild
[ - ] Al Kharid

+++ Setup Mining Variables (Popup here?)[/INDENT]

+ Fishing
+ Cooking
+ Woodcutting

[/INDENT]
and automatically close the previous (skill) section when you open a new one, so it doesn't tke to much space?

~RM

I like that idea. Only thing is, I'm not sure if you can do tree components like that. It's something to look in to for sure.

Do you think the one I posted above is too large? I like this one better, actually, and our logo could go in the bottom right corner.


Also, I like how I have a list for all the player's scripts. If we can get the thing to work, what do you think about having it pop up after clicking an Add Script button, and then you navigate to a the script you want to add. Only thing about that is I'm not sure if you'll be able to pick multiple scripts at one time..

We could just be over complicating everything as well.

What got me wondering was your location box..

You could just have a 'Choose Scripts' button that then pops out the menu, and when you close the popup it relays the info to the list with the script names.

Then when you click a script name, the script options could show up on the right side :D

but that location box still makes me go:confused:

Other than that… :thumbsup::thumbsup:

~RM

From: Sir R. M8gic1an

You could just have a 'Choose Scripts' button that then pops out the menu, and when you close the popup it relays the info to the list with the script names.

Then when you click a script name, the script options could show up on the right side :D

That's exactly what I was going to do. :)

From: Sir R. M8gic1an

but that location box still makes me go:confused:

Confused as to why it's placed there? Yeah I don't like that at all either. I originally had it on the left side, which would imply that the user should set it up before choosing the scripts. Normally that would be fine, except I was going to only add the locations to the combo box that are a part of the player's scripts, meaning the combo box would be empty until after the script's are chosen.

Actually you know what, now that we have SPS, there's really no reason for the user to set the location at all, so I may as well get rid of it altogether. We'll just have to be sure to write a FindPlayerLocation method before implementing the form.

From: Coh3n

Actually you know what, now that we have SPS, there's really no reason for the user to set the location at all, so I may as well get rid of it altogether. We'll just have to be sure to write a FindPlayerLocation method before implementing the form.

That makes sense ^

My confusion was because a Varrock East Miner would only work in Varrock,

and so with the location box there, if you choose Location: Varrock then you would be 'forced' to choose scripts in Varrock (logically) - which could be a good thing, it would confine players per city. Although that would take away flexibility and the greatest use of SPS, world walking.

As to what you said, basically the combo box would just be there to point where the player is first starting?

Yeh, do away with it, and just let SPS walk to wherever the first script is supposed to start. Worst case scenario we always have Lumby Tele and then walk ;)

~RM

From: Sir R. M8gic1an

As to what you said, basically the combo box would just be there to point where the player is first starting?

That's all it does right now so yeah that was the idea.

From: Sir R. M8gic1an

Yeh, do away with it, and just let SPS walk to wherever the first script is supposed to start. Worst case scenario we always have Lumby Tele and then walk ;)

~RM

Exactly. That also needs to be implemented. The "Death Walk" is the easiest because a path can easily be made from lumbridge to all the banks. I want to look more into ReadSteadGo's web walker. It'd be neat if we could make a web between all the script starting locations.

Added the setup tabs. What do you guys think?


I'm actually not sure how much I like that. It would be a lot better if there's a way to draw an image on the PageControl canvas.

E: Here it is using buttons. I personally like this one a lot better.

I generally would be prone to tabs, but I like the buttons here. If we go with the buttons I would recommend getting rid of the "To" since it just seems redundant. :P

From: IPwnz
I generally would be prone to tabs, but I like the buttons here. If we go with the buttons I would recommend getting rid of the "To" since it just seems redundant. :P

Sounds good. :)

Thanks for you input.

Made some more updates.


I've created a new branch in my repository and implemented the new form. All updates will now be found here.

E: Moved to public and added my notes to the first post.

From: Coh3n

P.S. I'm going to be very strict about standards and documentation. This will keep things neat and organized and make it easier for people to learn from. Here's a guide that will probably help us out a lot during this process.

With..do statements are by no means a "standard", especially with form development…

From: Daniel
With..do statements are by no means a "standard", especially with form development…

And why do you say that?

i love the new look deff better would love to see this in MSI (hate the look now =[)

Glad you like it, although those images are very outdated. If I get time later I'll upload a few of where it's at now.