SRL Archive - Bugs

{*******************************************************************************
function IsEquippedIDEx(IDs: TIntegerArray): boolean;
By: Drags111
Description: Returns true if there is an item equipped with one of the IDs.
*******************************************************************************}
function IsEquippedIDEx(IDs: TIntegerArray): boolean;
var
  Equipment: TEquipmentSet;
  i, ii: integer;
begin
  Result := False;
  Equipment := GetEquipment;
  for i := High(IDs) downto 0 do
    for ii := 10 downto 0 do
      if (IDs[i] = Equipment.Items[i].ID) then 
      begin                                    
        Result := True;
        Exit;
      end;
end; 

Fix:

{*******************************************************************************
function IsEquippedIDEx(IDs: TIntegerArray): boolean;
By: Drags111
Description: Returns true if there is an item equipped with one of the IDs.
*******************************************************************************}
function IsEquippedIDEx(IDs: TIntegerArray): boolean;
var
  Equipment: TEquipmentSet;
  i, ii: integer;
begin
  Result := False;
  Equipment := GetEquipment;
  for i := High(IDs) downto 0 do
    for ii := 10 downto 0 do
      if (IDs[i] = Equipment.Items[ii].ID) then 
      begin                                    
        Result := True;
        Exit;
      end;
end;

Ah, I see, wrong loop variable. It would be nice to tell us the problem though.

From: Sex
Ah, I see, wrong loop variable. It would be nice to tell us the problem though.

The problem is rather obvious, no?

I know, but it's a good practice…sometimes devs don't want to look through the code they can just see what the problem was, how they fixed it, and apply the fix.

From: Sex
I know, but it's a good practice…sometimes devs don't want to look through the code they can just see what the problem was, how they fixed it, and apply the fix.

:duh: lol. I'll keep that in mind for next time.