SRL Archive - MSI Bugs

Hey everyone finally back into the botting scene. And i see lots of additions to MSI. Just kinda having trouble shifting to the new ones. Let me know if i have this right because i keep getting a mainloop error with this script, but the other ones work fine, (Woodcutting,Minning ones.)

{     Location: Karamja Fishing Spot                             }
{     Time:     00s                                              }
{     Active:   True                                             }
{                                                                }
{     Script:                                                    }
{       Time:  00s                                               }
{       Skill:                                                   }
{       Exp:   0                                                 }
{       Level: Not yet defined                                   }
{                                                                }
{----------------------------------------------------------------}
{----------------------------------------------------------------}
[0:00:21]: [ Ean ] -- Cleared file: C:\Simba\Includes\MSI\Remote.txt
[0:00:21]: [ Ean ] -- MSI_SetupPlayer
[0:00:21]: [ Ean ] ---- Player is not logged in
[0:00:22]: Welcome to Runescape.
[0:00:22]: *********
[0:00:36]: [ Ean ] ------ Current GameTab: 37
[0:00:37]: [ Ean ] ------ Scanning for randoms...
[0:00:38]: [ Ean ] ---- MSI_SetSkillLevels
[0:00:40]: ** Warning in SkillToCoords: Invalid Skill Name/Number: ''**
[0:00:40]: [ Ean ] ------  level hasn't changed
[0:00:40]: [ Ean ] ---- MSI_SetSkillLevels: Finished
Error: Out of Proc Range at line 67

This is the line in mainloops.simba

 Result := MSI_Scripts[Scripts[CurrentScript].Name].PlayerSetup();   

Here is my setup

   Active     := True;    // Use this player?
    Member     := False;   // Is this player a member?
    Location   := LOC_KJ_FISH;        // See instructions at the top
    BreakLoads := 15;
    BreakTime  := 60;         // Amount of loads before breaking/switching players
    TotalLoads := 200;        // Total loads for the player to do; leave 0 if using TotalTime or to go forever
    TotalTime  := 0;        // How long for the player to run? (in minutes); leave 0 if using TotalLoads or go forever

    with Scripts[0] do
    begin

    Name     := SCRIPT_KJ_NOTER;   // The script constant
    FishSpots := [ FISHSPOT_CAGE]; // Trees to cut
    Priority := [100]; // Priorities (same as before)
    DontDrop := []; // For powerchopping only
    end;
  end;
end;

I probably set something up wrong, and i probably missed it in globals. and latest revision is 396 correct?

It's because the karamja fisher is for SRL Member+ so it's not in your Scripts.Simba.

I don't see the point of making it only members+ because there are already karamja fishers in the public section. So why not make this one for everyone else as well?

From: kongking
I don't see the point of making it only members+ because there are already karamja fishers in the public section. So why not make this one for everyone else as well?

You've gotta have some incentive to get a hold of the best of the best.

We should add an attribute to the records / locations or something of the like so that the form wont show those as possible botting locations

From: Zyt3x
We should add an attribute to the records / locations or something of the like so that the form wont show those as possible botting locations

It doesn't show the scripts that aren't loaded. ;) And I'll be working on it showing only the valid locations when I can.

And he's not using the form so I'm assuming he just got the constants from Globals.simba.

From: Coh3n
It doesn't show the scripts that aren't loaded. ;) And I'll be working on it showing only the valid locations when I can.

And he's not using the form so I'm assuming he just got the constants from Globals.simba.

Ofc it wont show scripts that aren't loaded… What was I thinking? :p

If he's not using the form then a comment saying that the location is only for SRLMember+ scripts would be fine

From: Zyt3x
Ofc it wont show scripts that aren't loaded… What was I thinking? :p

If he's not using the form then a comment saying that the location is only for SRLMember+ scripts would be fine

Yeah not a bad idea. I'll do that now quickly. E: Done.

Is there a noticeable difference between MSI's Karamja Fisher and Garrets?

From: kitchenrange
Is there a noticeable difference between MSI's Karamja Fisher and Garrets?

Well those are two different scripts. There will always be differences between different scripts :)
MSI was made to be an all-in-one script for your accounts, while Garret's were made purely for karamja fishing. Try them both and tell us which you like more and why :)

From: Coh3n
It doesn't show the scripts that aren't loaded. ;) And I'll be working on it showing only the valid locations when I can.

And he's not using the form so I'm assuming he just got the constants from Globals.simba.

I dont use the form because it would take hours to set it up. :P

From: Zyt3x
Well those are two different scripts. There will always be differences between different scripts :)
MSI was made to be an all-in-one script for your accounts, while Garret's were made purely for karamja fishing. Try them both and tell us which you like more and why :)

Yeah, I plan on doing that, but don't wait up on my response. I'm currently working solely on combat for my entire army. I was hoping those differences may have already been documented, but I'll try myself. Thanks.

From: kitchenrange
Yeah, I plan on doing that, but don't wait up on my response. I'm currently working solely on combat for my entire army. I was hoping those differences may have already been documented, but I'll try myself. Thanks.

Hahah to try and clear it up,

MSI is used to be a super script. I've never tried their Karamja Fisher but I know that MSI has a few problems with the Fishing currently - mostly in efficiency. My script uses a lot more reflection (easy stuff ;)) where as MSI has largely coded everything in colour. Although I did the base of the Fishing.simba, a bunch of code has been optimized since then so it is better. Since my script uses reflection for waiting while fishing, it is probably a bit more accurate than MSI in that respect. On the other hand, if you want an uber stable version (most of MSI's scripts don't even need to be updated very often) you should use MSI.

Where I must make bug fixes to my script, MSI has the core extremely well laid out, which means that it is very stable. I guess you could say that I'm on both 'sides' because I like my own script, but recognize that I am not as good at scripting as the entire MSI team.

From: 3Garrett3
Hahah to try and clear it up,

MSI is used to be a super script. I've never tried their Karamja Fisher but I know that MSI has a few problems with the Fishing currently - mostly in efficiency. My script uses a lot more reflection (easy stuff ;)) where as MSI has largely coded everything in colour. Although I did the base of the Fishing.simba, a bunch of code has been optimized since then so it is better. Since my script uses reflection for waiting while fishing, it is probably a bit more accurate than MSI in that respect. On the other hand, if you want an uber stable version (most of MSI's scripts don't even need to be updated very often) you should use MSI.

Where I must make bug fixes to my script, MSI has the core extremely well laid out, which means that it is very stable. I guess you could say that I'm on both 'sides' because I like my own script, but recognize that I am not as good at scripting as the entire MSI team.

Since I fixed WaitWhileFishing I've been running the karamja fisher every night and not run into a single problem yet. :redface: Cage fishing btw.

I can see the arguments for both sides obviously. I've always wondered about how to check if I'm not fishing with color. One of my scripts from forever ago was a karamja fisher, though much simpler than both of yours I'm sure.