SRL Archive - MSI Bugs

Details: Fly fishing at edgeville

My account will be fishing at one of the fishing spots, but the script will keep clicking over and over again on the same spot about every 10 seconds. It will also move over to the other area where you can fish, while there is still a spot at the one my account is currently standing by.

If you need more of an explanation or any other details, just ask.

Thanks.

Fishing has been in general disarray for a bit now. I'll contact NCDS/other SL's and see what they're up to with working on it..

I think this may be a good time to implement a reflection/color hybrid system on the objects..

From: Coh3n
I think this may be a good time to implement a reflection/color hybrid system on the objects..

Not a bad idea.

I'm going to get back to working on this tonight as much as I can.

Okay thanks for letting me know! If you need any accounts to test on just ask.

^same problem, PM me if you have an update and want me to test it :)

many thanks,
Sgt Soul

Edit: My bad, didn't know what section this was

Are everyone's graphics settings set properly?

I have minimum graphics and fixed screen, my only problem is that my player is at a fishing spot, fishing (as it does) and then it will constantly click on that fishing spot even though the player is already fishing. Also after it has clicked probably 10 or 20 times it decides to move the player to the other fishing spot and does the same thing over and over until there is a full load.

If you would like any more detail I could draw up diagrams of what happens and post them on here for you :)

many thanks,
Sgt Soul

From: sgt soul
I have minimum graphics and fixed screen, my only problem is that my player is at a fishing spot, fishing (as it does) and then it will constantly click on that fishing spot even though the player is already fishing. Also after it has clicked probably 10 or 20 times it decides to move the player to the other fishing spot and does the same thing over and over until there is a full load.

If you would like any more detail I could draw up diagrams of what happens and post them on here for you :)

many thanks,
Sgt Soul

It's okay, I know exactly what you mean, and yes we are aware of this. We're working on a new, more accurate object finding method. :)

E: :p Sorry that may not have made much sense. I got this thread and the other fishing thread mixed up.

that is fine, I have been reading over both threads to see if there might have been a fix anyway hahaha

Talking on the other thread I don't see how their camera angle doesn't go straight to the highest point when they log on.. Mine does :/

From: sgt soul
that is fine, I have been reading over both threads to see if there might have been a fix anyway hahaha

Talking on the other thread I don't see how their camera angle doesn't go straight to the highest point when they log on.. Mine does :/

Are you using an unsigned client?

I use signed, the graphics are too detailed and lagg up heaps when I use unsigned :S

From: sgt soul
I use signed, the graphics are too detailed and lagg up heaps when I use unsigned :S

Yeah, see the people having the angle problem are using unsigned; although, I still don't understand why it wouldn't work.

From: Coh3n
although, I still don't understand why it wouldn't work.

Just because SMART lags so bad when first loading the unsigned client that sometimes your not fully logged in when it tries to set the angle, and sometimes it will move the angle up just a little because that's all that registered. Just what I've noticed in the past.

I don't think there is anything anyone can do about it, just set the angle yourself if you need to I guess.

From: NCDS
Just because SMART lags so bad when first loading the unsigned client that sometimes your not fully logged in when it tries to set the angle, and sometimes it will move the angle up just a little because that's all that registered. Just what I've noticed in the past.

I don't think there is anything anyone can do about it, just set the angle yourself if you need to I guess.

That's easy to fix, just add a while loop and a few getcolors to make sure all parts of the screen have loaded before setting the angle (after logging in).

From: lordsaturn
That's easy to fix, just add a while loop and a few getcolors to make sure all parts of the screen have loaded before setting the angle (after logging in).

Perhaps that should be done to SRL's LoggedIn function?

I can probably do it if anyone agrees, either way it would have to be done for MSI.

From: NCDS
Perhaps that should be done to SRL's LoggedIn function?

I can probably do it if anyone agrees, either way it would have to be done for MSI.

I think that should have been done a long time ago. ;)

It seems that the screen loads in sort of 4 boxes that fill the main screen. Either way, if the center of the MS is loaded, the game probably is too.

This little bit here just checks a 40x40px box around MSCx, MSCy, and checks if there are more than 20 occurrences of color '0' (The black of the unloaded RS client). If so, it continues to wait up to 5 seconds.

As you can see it still sets the final Result depending on the original color check.

Side note: I know the explanation probably wasn't necessary, but I felt like I should.

function LoggedIn: Boolean;
var
  cx, cy, t: Integer;
begin
  t := GetSystemTime + 5000;
  while (not (Result)) and (t > GetSystemTime) do
  begin
    Result := (CountColor(0, MSCx - 20, MSCy - 20, MSCx + 20, MSCy + 20) < 20);
    Wait(3);
  end;

  Result := FindColor(cx, cy, 16777215, 439, 491, 440, 492);
end;                                  

Tested and it worked perfectly fine, though I wasn't really having the problem before, only sometimes.

There may be other ways you would find to be 'better' than this, but I don't see why it wouldn't work.

anyway, let me know your thoughts.

Post in Public SVN, along with an explanation of why it was needed. I'd like to see what other people think first since it's a change to a major function.

From: 3Garrett3
Fishing has been in general disarray for a bit now. I'll contact NCDS/other SL's and see what they're up to with working on it..

whats in disarray in the include?

From: Blumblebee
whats in disarray in the include?

The IsFishing methods don't work that well, IIRC.

From: Blumblebee
whats in disarray in the include?

Most of the Fishing portions which actually do anything, tbh

This problem should now be fixed.

It was an extremely small thing causing all this trouble >.<.

I plan on doing a bit more with it tomorrow, but you should notice a significant difference already. :)

From: NCDS
This problem should now be fixed.

It was an extremely small thing causing all this trouble >.<.

I plan on doing a bit more with it tomorrow, but you should notice a significant difference already. :)

so when fishing the player wont keep clicking on the fishing spot or changing fishing spots until the spot has run out?

From: sgt soul
so when fishing the player wont keep clicking on the fishing spot or changing fishing spots until the spot has run out?

It probably won't be perfect, but it should be a lot better than it was before.

From: sgt soul
so when fishing the player wont keep clicking on the fishing spot or changing fishing spots until the spot has run out?

Correct. It is significantly better right now, and will be even better tonight. :)

From: NCDS
Correct. It is significantly better right now, and will be even better tonight. :)

okay super, thanks so much guys! great progress on the fishing section <3
I will be testing this soon for you probably to get my fishing from 71 to 80+ :)

From: NCDS
Correct. It is significantly better right now, and will be even better tonight. :)

Wanna post or PM about the changes? I find it easy to learn off mistakes, and the base code you've corrected is likely mine.

From: 3Garrett3
Wanna post or PM about the changes? I find it easy to learn off mistakes, and the base code you've corrected is likely mine.

One of the loop conditions was

until(WaitTime > GetSystemTime);

Instead of

until(WaitTime < GetSystemTime);

Very minor as you can see. :p

Great job guys, seems to work very well now :)
Running atm, will post a proggy in the progress report thread when it's done.

If anyone has any problems with this still, please post what sort of fishing you were doing. ie Lure, Harpoon, etc.

Thanks.