Coh3n
2010-12-25 01:19:04
If you haven't noticed already, there's about a thousand unused variables in MSI. I believe this just shows poor scripting, and I'm sure most of you will agree. I think most are in the Extras, but we need someone to go through and get rid of them all. Even if you only get rid of a few and commit, that's fine.
If we all do a few every couple days, they'll be gone in no time. :)
Wizzup?
2010-12-25 09:15:05
I'm unsure about this, but I think I saw a lot of upper case unused variables. Aren't those supposed to be constants?
Coh3n
2010-12-25 09:30:59
From: Wizzup?
I'm unsure about this, but I think I saw a lot of upper case unused variables. Aren't those supposed to be constants?
Depends what they're supposed to represent I guess; however, if they're unused they shouldn't even be there.
Wizzup?
2010-12-25 09:40:40
From: Coh3n
Depends what they're supposed to represent I guess; however, if they're unused they shouldn't even be there.
I thought constants were uppercase and all the others weren't? :D
Coh3n
2010-12-25 09:47:50
From: Wizzup?
I thought constants were uppercase and all the others weren't? :D
Oh I didn't realize you meant they were all uppercase. :o If there are, then yes, you're right; but still, if they're not used, they shouldn't be there. :p
Wizzup?
2010-12-25 10:02:40
From: Coh3n
Oh I didn't realize you meant they were all uppercase. :o If there are, then yes, you're right; but still, if they're not used, they shouldn't be there. :p
I agree. I was trying to say that constants will not give you a ``variable unused'' warning. ;)
Gu3st...
2010-12-25 17:48:44
But constants aren't dangerous Wizzup :)
cstrike has a lot of unused variables
Coh3n
2010-12-25 22:04:18
From: Zyt3x
But constants aren't dangerous Wizzup :)
Neither are variables. ;) Both constants and variables should be removed if they're not being used.