SRL Archive - Reflection Discussion

Better Banking function?


Daedolon

2010-12-08 21:09:21

I was talking to Cstrike about this recently, and I'm a tad irked that my script fudges up sometimes because it fails to locate the bank and open it.

I'm wondering, is there a better banking function to use? If not, is the one being made that will be better and not as buggy?

Bad Boy JH

2010-12-08 21:23:49

are you using reflection (R_OpenBankBooth) or Color (OpenBank).

I think we need to allow for mis-clicks, eg clicking the banker by accident (this is where R_ChooseOptionMulti may prove useful)

Daedolon

2010-12-08 22:43:51

I used the "R_OpenBankBooth"

Bad Boy JH

2010-12-08 22:49:23

which bank, I know al-kharid used to stuff up all the time.

Daedolon

2010-12-08 22:51:39

Funny you should say that, 'cause I use the Al Kharid bank in my script.

Bad Boy JH

2010-12-08 22:59:52

Did you see the bug? what happened?

This is what used to happen to me, It would walk into the bank, and try and click the bank-booth, and because it was moving quickly (I was running) it would miss, and hit the banker, fail and return false.

Is that basically what happened to you? A fix to this should be fairly easy

Daedolon

2010-12-08 23:02:22

Yeah, it would walk into the bank, sit there for a few seconds, put the red dot over the bank booth, and then move to the top left of the screen and right click (I'm assuimg the script thinks it's opened the bank interface because it was set to withdraw from the first bank slot).

Bad Boy JH

2010-12-08 23:07:19

heh, that doesn't make much sense,

The Only thing I could see that could cause that would be GetMousePos, which shouldn't be neccesary

Bad Boy JH

2010-12-08 23:25:30

does it move to the left, but not move up or down?

do you have MSN? can you please add me if you do [email]lilbruvver2@hotmail.com[/email]

Daedolon

2010-12-09 00:05:19

No, It moves to the left and moves up to the top left corner area.

Cstrike

2010-12-09 00:50:57

From: Daedolon
No, It moves to the left and moves up to the top left corner area.


Fixed that bug earlier today, was pissing me off too :spot:

Daedolon

2010-12-09 19:58:23

Awesome. :)

Death12652

2010-12-09 22:08:56

Thats weird, it was working for me yesterday when I was testing my script, I am really looking forward to releasing the BETA on saturday.

Rich

2010-12-17 12:36:55

If you still have problems, you can use a mix of colour and reflection:
procedure DoBank;
begin
if not R_OpenBankBooth('ak') then //Is al Kharid 'ak'?
if not OpenBank('ak', False, False) then //OpenBank tries all colour methods
begin
WriteLn('Could not open bank');
LogOut;
TerminateScript;
end;
end;

KingKong

2010-12-17 22:25:38

For me R_OpenBankBooth works perfectly at alkharid, its only the color stuffs up(Color stuffs up for me everywhere)

Bad Boy JH

2010-12-18 02:56:16

colour is imperfect, and the idea of colour ever being perfect is minimal.

KingKong

2010-12-18 03:00:44

Didn't rs color update recently? I read in some color tut and it seems to me all the values have been doubled.

lordsaturn

2010-12-22 04:52:48

From: kongking
Didn't rs color update recently? I read in some color tut and it seems to me all the values have been doubled.


how so? please be more specific.

KingKong

2010-12-22 05:29:10

From: YoHoJo
Runescape Updated, 131072 is now the black color. So make sure the color on your outline points is 131072

Before, the black color was 65536, and now its 131072(65536 x 2 = 131072 :P)
Its at this thread:
http://villavu.com/forum/showthread.php?t=564

lordsaturn

2010-12-22 06:43:59

From: kongking
Before, the black color was 65536, and now its 131072(65536 x 2 = 131072 :P)
Its at this thread:
http://villavu.com/forum/showthread.php?t=564


Yeah, but that is only one value, which doesn't support your claim of "all color values have doubled". The black color was changed to mess up color recognition bots like ours. Because it was changed, the outline color of items is now maintained through a constant srl_outline_black.

Bad Boy JH

2010-12-22 08:38:29

it did stuff us up quite well, all the DTMs and Bitmaps were broken, wasn't good