SRL Archive - MSI Suggestions

Deposit all


mat_de_b

2010-10-25 17:57:26

I saw there wasn't a deposit all function in the banking section, so i wrote something that might be able to be put in.

It need help as i dont know all of the functions used to cancel whats happening and log out.

MSI_LoadItem(whichItem);
If FindDTM(DTM, x, y, MIX1, MIY1, MIX2, MIY2)Then
begin
Mouse(x, y, 3, 3, False);
ChooseOption('All');
Wait(1500 + Random(500));
end
else
begin
MSI_AddHeader('MSI_Deposit failed');
// And other things to cancel and log
end;

Could do with some failsafes to find out if it has actually got to the depositing screen. Which again i'm not too sure of.

Sorry for not being able to do everything, its just something i noticed and tried to find what i could to do about it. But obviously i'm not the best scripter, and i can imagine many here would be able to write something better/more appropriate

thanks, Dom

NCDS

2010-10-25 18:00:29

Everything is included in MSI_Deposit ;)

mat_de_b

2010-10-25 18:26:55

Ok no, it deposited fine just then. In which case there is also an error where if it just clicks each item (doesn't select deposit all) the wait time (to let the lag settle) is too short. You get to about 2 lines of invo left and then it tries to close the bank, and the script see's that the deposit didn't work properly and logs…

Coh3n

2010-10-25 18:50:42

From: mat_de_b
Ok no, it deposited fine just then. In which case there is also an error where if it just clicks each item (doesn't select deposit all) the wait time (to let the lag settle) is too short. You get to about 2 lines of invo left and then it tries to close the bank, and the script see's that the deposit didn't work properly and logs…

Is your MSI updated? I fixed the issue with clicking individual items a while ago. If you're up to date, which item is this happening with and do you have the debug?

mat_de_b

2010-10-25 19:01:04

I'm not too sure if its 'updated' i got the repository just last night, and the exstension isnt saying it needs to be updated, like SRL and Reflection (if thats what happens when it updates)

It was happening with yews, and i will try and find the debug.

EDIT: Here it is

[ Lerf ] – MSI_OpenBank: True(Grand Exchange bank)
[ Lerf ] – MSI_Deposit
[ Lerf ] —— Exception: Dragon Hatchet - Slot 1
[ Lerf ] —— There are 1 exceptions
[ Lerf ] —— Exception: Dragon Hatchet - Slot 1
[ Lerf ] —— There are 1 exceptions
[ Lerf ] —- MSI_FindItemSlots: Found 27 Yew logs in inventory slot(s) [2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20, 21, 22, 23, 24, 25, 26, 27, 28]
[ Lerf ] —— MSI_ClickItemSlot: Failed to click item slot
[ Lerf ] – MSI_Deposit: False (Yew logs)
[ Lerf ] —- Exception: Dragon Hatchet - Slot 1
[ Lerf ] —- There are 1 exceptions
[ Lerf ] MSI_BankMaterials: False
[ Lerf ] MSI_UnsetPlayer
[ Lerf ] – Failed to bank materials
[ Lerf ] – MSI_SetSkillLevels
[ Lerf ] —- Woodcutting level hasn't changed
[ Lerf ] – MSI_SetSkillLevels: Exit
[ Lerf ] MSI_UnsetPlayer: Done
[ Lerf ] All players inactive, terminating script!

Harry

2010-10-26 01:59:35

From: mat_de_b
[ Lerf ]

Sorta offtopic, but are capital letters allowed in Nicknames now?

Bonfield

2010-10-26 04:31:33

I don't think nicknames are used anymore to detect randoms

Coh3n

2010-10-26 17:07:36

@mat_de_b: I can't seem to recreate the problem. Make sure you have the latest version. Here's by debug:

[0:00:14]: [ ] -- MSI_Deposit
[0:00:14]: [ ] ------ Exception: Adamant Hatchet - Slot 1
[0:00:14]: [ ] ------ There are 1 exceptions
[0:00:14]: [ ] ------ Exception: Adamant Hatchet - Slot 1
[0:00:14]: [ ] ------ There are 1 exceptions
[0:00:14]: [ ] ---- MSI_FindItemSlots: Found 27 Yew logs in inventory slot(s) [2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20, 21, 22, 23, 24, 25, 26, 27, 28]
[0:00:15]: [ ] ------ MSI_ClickItemSlot: Succesfully clicked item slot
[0:00:16]: [ ] -- MSI_Deposit: True