SRL Archive - MSI Bugs

This is from .txt file that i have sent to Coh3n and NCDS and I feel that maybe i should post here for everyone else to review and share thier ideas.

1. We both know that for some odd reason, MSI is not detecting randoms right. Its still bugging up, sometimes it will detect and log, sometimes it will
just sit there looking for trees/fishing spot/mining spot all day until I fix it. This has been a real pain lately and i feel that Jagex has increased
there randoms to a higher time, i donno.

2.On top of it does find a random and soves it, the damn thing still messes up on the Box.Ok for starters, sometimes it will and sometimes it wont
click the inventory tab to check for the box. It will instead for some odd reason it will continue to click on my friends list on the spot it THINKS
its at, but because its not on the inventory tab, it can't click the box. On top of this, when it does randomly click the inventory tab to click on the
box it will open up the screen but it will get stuck on the xp screen when the window pops up. Some randoms have the xp lamp skill in a different location
than others i don't know if this is the reason for it.

Post thoughts, Ideas, opinions or more bugs to be resolved.

If MSI_FindRandoms gets called, it's calling FindNormalRandoms. If the debug says "Scanning for randoms…", it's being called. MSI doesn't have anything to do with the random detection, that's all SRL. The same goes for the reward Box.

Now, if the procedure isn't getting called, than something in MSI needs to be changed, but other than that, there isn't much we can do. :(

Thats why I decided to post it here. So some more SRL dev's can take a look at it.

I really don't understand this as the majority of the time I find one of my MSI accounts stuck in a random, it's a random that I personally have tested multiple times with only success.

For example, I've tested frog random numerous times to be sure it worked, then this morning I woke up to an account stuck in the frog random.

exactly i get stuck in randoms that i know that can be solved.

i can run a non- msi script and it will solve a random

but when it comes to msi there is a 50% chance its going to solve :/

Which also doesn't make much sense as MSI_FindRandoms is called literally everywhere, and MSI_FindRandoms is just FindNormalRandoms with a couple thing's added for MSI. Nothing that should effect how it works though.

I've looked into this quite a few times but never made any kind of progress as I don't see anything that would cause a problem :/

i know i do see it call finrandoms all the time.

Even if its in a random its calling findrandoms.

I dont know what it is, but its seems to be definitely buggy. I used to work before very well. And for some reason it has gotten worse :/

It means that it's not finding the randoms… which means the InRandom function needs some changing.

~RM

From: Sir R. Magician
It means that it's not finding the randoms… which means the InRandom function needs some changing.

~RM

From: NCDS
Which also doesn't make much sense as MSI_FindRandoms is called literally everywhere, and MSI_FindRandoms is just FindNormalRandoms with a couple thing's added for MSI. Nothing that should effect how it works though.

I've looked into this quite a few times but never made any kind of progress as I don't see anything that would cause a problem :/

I've tested the InRandom functions and they worked fine, otherwise I fixed them.

[0:05:33]: [ 711 ] —— Looking for tree
[0:05:33]: [ 711 ] ——– Scanning for randoms…
[0:05:35]: [ 711 ] —— Looking for bird's nests
[0:05:35]: [ 711 ] —— Checking inventory count
[0:05:35]: [ 711 ] —- Out of loop
[0:05:35]: [ 711 ] – MSI_WaitWhileChopping: Exit
[0:05:36]: [ 711 ] – MSI_FindObjectsIn
[0:05:36]: [ 711 ] —— MSI_FindObjectsTPA: No colors found!
[0:05:36]: [ 711 ] – MSI_FindObjectsIn: False
[0:05:36]: [ 711 ] —- Scanning for randoms…
[0:05:38]: [ 711 ] —- Scanning for randoms…
[0:05:41]: [ 711 ] – MSI_Relocate
[0:05:41]: [ 711 ] —— No relocation areas for Port Sarim willows
[0:05:41]: [ 711 ] – MSI_Relocate: False
[0:05:41]: [ 711 ] – MSI_FindObjectsIn
[0:05:41]: [ 711 ] —— MSI_FindObjectsTPA: No colors found!
[0:05:41]: [ 711 ] – MSI_FindObjectsIn: False
[0:05:41]: [ 711 ] —- Scanning for randoms…
[0:05:43]: [ 711 ] —- Scanning for randoms…
[0:05:45]: [ 711 ] – MSI_Relocate
[0:05:45]: [ 711 ] —— No relocation areas for Port Sarim willows
[0:05:45]: [ 711 ] – MSI_Relocate: False
[0:05:46]: [ 711 ] – MSI_FindObjectsIn
[0:05:46]: [ 711 ] —— MSI_FindObjectsTPA: No colors found!
[0:05:46]: [ 711 ] – MSI_FindObjectsIn: False
[0:05:46]: [ 711 ] —- Scanning for randoms…
[0:05:48]: [ 711 ] —- Scanning for randoms…
[0:05:49]: [ 711 ] – MSI_Relocate
[0:05:49]: [ 711 ] —— No relocation areas for Port Sarim willows
[0:05:49]: [ 711 ] – MSI_Relocate: False
[0:05:50]: [ 711 ] – MSI_FindObjectsIn
[0:05:50]: [ 711 ] —— MSI_FindObjectsTPA: No colors found!
[0:05:50]: [ 711 ] – MSI_FindObjectsIn: False
[0:05:50]: [ 711 ] —- Scanning for randoms…
[0:05:52]: [ 711 ] —- Scanning for randoms…
[0:05:55]: [ 711 ] – MSI_Relocate
[0:05:55]: [ 711 ] —— No relocation areas for Port Sarim willows
[0:05:55]: [ 711 ] – MSI_Relocate: False
[0:05:55]: [ 711 ] – MSI_FindObjectsIn
[0:05:55]: [ 711 ] —— MSI_FindObjectsTPA: Not enough points!
[0:05:55]: [ 711 ] —- 1 objects found!
[0:05:56]: [ 711 ] —- Uptext didn't match!
[0:05:56]: [ 711 ] – MSI_FindObjectsIn: False
[0:05:56]: [ 711 ] —- Scanning for randoms…
[0:05:58]: [ 711 ] —- Scanning for randoms…
[0:05:59]: [ 711 ] – MSI_Relocate
[0:05:59]: [ 711 ] —— No relocation areas for Port Sarim willows
[0:05:59]: [ 711 ] – MSI_Relocate: False
[0:05:59]: [ 711 ] – MSI_FindObjectsIn
[0:05:59]: [ 711 ] —— MSI_FindObjectsTPA: Not enough points!
[0:06:00]: [ 711 ] —- 1 objects found!
[0:06:00]: [ 711 ] —- Uptext didn't match!
[0:06:00]: [ 711 ] – MSI_FindObjectsIn: False
[0:06:00]: [ 711 ] —- Scanning for randoms…
[0:06:01]: [ 711 ] —- Scanning for randoms…
[0:06:03]: [ 711 ] – MSI_Relocate
[0:06:03]: [ 711 ] —— No relocation areas for Port Sarim willows
[0:06:03]: [ 711 ] – MSI_Relocate: False
[0:06:04]: [ 711 ] – MSI_FindObjectsIn
[0:06:04]: [ 711 ] —— MSI_FindObjectsTPA: Not enough points!
[0:06:04]: [ 711 ] —— MSI_FindObjectsTPA: Not enough points!
[0:06:04]: [ 711 ] – MSI_FindObjectsIn: False
[0:06:04]: [ 711 ] —- Scanning for randoms…
[0:06:07]: [ 711 ] – MSI_SetSkillLevels
[0:06:07]: [ 711 ] —- Woodcutting level hasn't changed
[0:06:07]: [ 711 ] – MSI_SetSkillLevels: Exit

Will sit forever until I stop it :/ Happens to me on all randoms, Leo, Sandwich lady, etc. Chopping willows at the port, using deposit box.

I wish I knew why it's doing this.

Here's a screenshot when it's stuck in Leo, if it will help anything.

Yea all it will do is sit, but i did notice somethign really cool i dont know if they added this recently to MSI but today i saw my guy get stuck in the pinball, MSI did not detect it.

Me being lazy was like eh, ill just let that player go false i have 50+ others to go..
But it didnt log out, instead it got TIMED out and it was in the lobby screen, MSI detected that and reloged into it and it detected the pinball random and solved it after failing 2 or 3 times from hitting the wrong pins.

But it did mess up when it got back to fishing, because the ineventory was halfway full and it was looking for a bank.

It forgot that it was fishing and maybe thought it was a new player and was looking for a bank :/

I wish i could report all the bugs via MSN to Coh3n and NCDS but my MSN wont load up ever since i installed 2011 :(

EDIT: Yay i just had WIndows Live repair it self and it worked… finally.

From: Squancy
Me being lazy was like eh, ill just let that player go false i have 50+ others to go..
But it didnt log out, instead it got TIMED out and it was in the lobby screen, MSI detected that and reloged into it and it detected the pinball random and solved it after failing 2 or 3 times from hitting the wrong pins.

But it did mess up when it got back to fishing, because the ineventory was halfway full and it was looking for a bank.

Do you have the debug?

I also added the location detection earlier today, so that shouldn't happen anymore.

As for the randoms issue, that's very weird. I don't understand why it would detect it after logging back in and not as soon as it gets into the random. When it logged back in, was the screen different at all (i.e. was the NPC text different)?

From: Coh3n
I also added the location detection earlier today, so that shouldn't happen anymore.

Happened to me even with the new location detecting. :c

From: Harry
Happened to me even with the new location detecting. :c

No, I mean when it searched for the bank after finishing the random. Or is that what you were talking about?

From: Coh3n
No, I mean when it searched for the bank after finishing the random. Or is that what you were talking about?

No, I meant that it teleported me away, and it sat forever. I dunno, it should log-out and set to false if you're really far away from the $botsite and/or $bank (though I don't know if this would cause issues in long-walking scripts).

perhaps MSI_FindRandoms should be temporarily replaced with just FindNormalRandoms to see if the MSI clutter is causing this to happen?

From: Harry
No, I meant that it teleported me away, and it sat forever. I dunno, it should log-out and set to false if you're really far away from the $botsite and/or $bank (though I don't know if this would cause issues in long-walking scripts).

Don't you only get teleported if you fail the random? And doesn't SRL automatically log you out when it fails?

From: TomTuff
perhaps MSI_FindRandoms should be temporarily replaced with just FindNormalRandoms to see if the MSI clutter is causing this to happen?

I thought so too, but that doesn't explain why it detects the random after logging back in, because as soon as it logs in, we call MSI_FindRandoms.

From: Coh3n
Don't you only get teleported if you fail the random? And doesn't SRL automatically log you out when it fails?

Nah, I mean, you get teleported there and sit there forever. It even tries to find and chop trees when you've been teleported away from the botspot. It's not even thinking you are in a random, even when you are.

From: Harry
Nah, I mean, you get teleported there and sit there forever. It even tries to find and chop trees when you've been teleported away from the botspot. It's not even thinking you are in a random, even when you are.

Oh, yeah. But that's what doesn't make sense, because the function itself is being called. It confuses me.

We could call MSI_AtLocation, and if the player isn't there, it would call MSI_FindRandoms, but I don't see how that would change anything because the function was still getting called.

Did you notice if anything changed if you were to get teleported as opposed to logging into the random?

Very soon all the reflection randoms should be [flawlessly] done. Then MSI scripts can run *forever* literally if reflection randoms are used and hooks arent broken/there are no bugs [;)]. The Prison Bob random sucks to get though because it terminates in 15 minutes.

The only thing that would need to be coded in is if MSI wants to use it, how to set up what items not to deposit with a TIA.

From: Coh3n
Did you notice if anything changed if you were to get teleported as opposed to logging into the random?

Didn't try.

From: cstrike
Very soon all the reflection randoms should be [flawlessly] done. Then MSI scripts can run *forever* literally. The Prison Bob random sucks to get though because it terminates in 15 minutes.

The only thing that would need to be coded in is if MSI wants to use it, how to set up what items not to deposit with a TIA.

It would be nice if they are done, but I mean it detecting and logging out is a LOT better than sitting in the random for 7 hours D:

From: cstrike
The only thing that would need to be coded in is if MSI wants to use it, how to set up what items not to deposit with a TIA.

We have a DontDrop array. It could be added to banking so it won't bank the items in that array, but what does that have to do with randoms? :o

Also, if all the randoms in reflection are stable (except a few) then they can still be used. The reason we stopped using them was because several times it thought it was in a random and it was just walking to the bank or trees or something like that.

From: Harry

It would be nice if they are done, but I mean it detecting and logging out is a LOT better than sitting in the random for 7 hours D:

The only thing I can do is replace edit MSI_FindRandoms a bit, although I guarantee it won't make a difference.

The whole situation just doesn't make sense…

From: Coh3n

The whole situation just doesn't make sense…

It really doesn't. If you guys have looked at the code you will see that MSI_FindRandoms pretty much just calls FindNormalRandoms and checks to see you you've leveled up, and it's called in every loop really.

Following any sort of logic MSI should have just as good, if not better random detection as any other script (because it's called so much due to the problems), they just seem to go undetected quite often. It looks like it's SRL's InRandom functions, but I test every time and they work..

This whole situation leaves me clueless.

I've temporarily "fixed" this, at least until we can figure out exactly why it's happening.

From: SVN Logs

- Moved MSI_HandleBreaking to Antiban.simba
- Temporarily fixed the random issue: Each player has 3 "relocation attempts". If it fails to relocate, it will increase number of attempts and switch players (or break if single player). If attempts exceed 3, will set player to false.
- Added first AI (sort of) of MSI: Will automatically set a relocation point for power scripts based on the players location.

Basically now, if it's in a random and infinitely searching for trees, it will logout (because relocating failed) and switch players or break. When it logs back in, hopefully it will find and solve the random. It will try this 3 times before setting the player the false.