SRL Archive - MSI Bugs

Finding fishing spots


Coh3n

2010-10-08 17:38:44

I was testing out the Barbarian Village Fisher and I noticed that a lot of the time, the fishing spots weren't being found. Some information in the object's record just may be outdated. I don't have the time right now to test it out, but I was hoping someone may be bored and wouldn't mind helping out MSI just this once. :p

You can just run the script (SCRIPT_BBV_FISHER or SCRIPT_DB_FISHER) and you'll see what I mean.

Cheers,
Coh3n

NCDS

2010-10-08 17:44:04

I know exactly what your talking about. I think the color is just soewhat outdated, or perhaps the count too.

I'll be back in 2(ish) hours and I'll do it then.

Nava2

2010-10-09 00:32:52

Why not use scanning like I do in my Karamaja fisher? Sure, its a bit slower, but its accurate as hell.

Cstrike

2010-10-09 00:48:11

From: Nava2
Why not use scanning like I do in my Karamaja fisher? Sure, its a bit slower, but its accurate as hell.


What's scanning [in a nutshell]?
Would that be moving the mouse around blindly in horizontal rows? Or looking for ?

I always like learning accurate techniques ;)

Coh3n

2010-10-09 01:37:41

From: cstrike
What's scanning [in a nutshell]?

Please. :rolleyes:

Also, is your fisher for the old fishing spots? I know it's pretty old.

NCDS

2010-10-09 20:29:40


[0:41:52]: {----------------------------------------------------------------}
[0:41:52]: { MSI Phoenix Player Report }
[0:41:52]: {------------------------- Revision 333 -------------------------}
[0:41:52]: { Time Running: 41 Minutes and 52 Seconds }
[0:41:52]: {----------------------------------------------------------------}
[0:41:52]: { }
[0:41:52]: { Player 0: Dart6 }
[0:41:52]: { Location: Edgeville bank }
[0:41:52]: { Time: 26m 27s }
[0:41:52]: { Total Loads: 5 }
[0:41:52]: { Active: True }
[0:41:52]: { }
[0:41:52]: { Script: Barbarian Village Fisher }
[0:41:52]: { Time: 26m 27s }
[0:41:52]: { Skill: Fishing }
[0:41:52]: { Loads: 5 }
[0:41:52]: { Exp: 7,440 }
[0:41:52]: { Level: 49 }
[0:41:52]: { Item: Raw trout }
[0:41:52]: { Amount: 83 }
[0:41:52]: { Item: Raw salmon }
[0:41:52]: { Amount: 47 }
[0:41:52]: { }
[0:41:52]: {----------------------------------------------------------------}
[0:41:52]: {----------------------------------------------------------------}

with the new RAW_TROUT fish spot record I made. Tested both and watched pretty closely and this one certainly seems to find the spots more often.

Something needs to be changed in WaitWhileFishing, as it doesn't ever actually wait while fishing, it just exits the procedure.
I'll have a look more closely at it tonight, and I will commit the new fish spot record in just a minute.

Cstrike

2010-10-09 20:51:38

From: Coh3n
Please. :rolleyes:

:confused:
Did I do something wrong? I don't know what he means by scanning, is it something I should know?

Gotta make sure these gaps are filled in ;););)

NCDS

2010-10-09 21:20:25

From: cstrike
:confused:
Did I do something wrong? I don't know what he means by scanning, is it something I should know?

Gotta make sure these gaps are filled in ;););)


He was just telling Nava to please explain, as you said. ;)

3Garrett3

2010-10-09 21:22:43

From: NCDS

Something needs to be changed in WaitWhileFishing, as it doesn't ever actually wait while fishing, it just exits the procedure.
I'll have a look more closely at it tonight, and I will commit the new fish spot record in just a minute.


I'd been saying this since I first released it. The idea is sloppy, but nobody could think up a reliable system, or if they could, they didn't ever present me with any code. I'm really strained for time, but I can try to get on it if there ever happens to be an opening.

NCDS

2010-10-09 21:26:30

From: 3Garrett3
I'd been saying this since I first released it. The idea is sloppy, but nobody could think up a reliable system, or if they could, they didn't ever present me with any code. I'm really strained for time, but I can try to get on it if there ever happens to be an opening.


I wasn't even aware of that >.<

I'll have a go at it in a minute after I check out a couple other bugs and be sure to let you know how it goes.

Cstrike

2010-10-09 21:36:01

From: NCDS
He was just telling Nava to please explain, as you said. ;)


Ah I read his post wrong then ;) my bad + thanks for clearing it up :)

NCDS

2010-10-10 01:06:32

This should be somewhat better now. Not perfect, but better.

Nava2

2010-10-11 16:09:55

WHAT THE SHIT. I POSTED WHAT IT WAS.

Okay, scanning is basically taking multiple colour searches and combining the points, so you have a better image of what was there. You search over Y seconds in X intervals. It creates a much larger image, and you can use length/width checks as well as density checks. Its far more accurate than one search.

BUT, it is slower.

Coh3n

2010-10-15 18:14:25

From: Nava2
WHAT THE SHIT. I POSTED WHAT IT WAS.

Okay, scanning is basically taking multiple colour searches and combining the points, so you have a better image of what was there. You search over Y seconds in X intervals. It creates a much larger image, and you can use length/width checks as well as density checks. Its far more accurate than one search.

BUT, it is slower.

Knowing you, it's probably not much slower. :p

I'm actually curious. I'd like to take a look at it when I get more time. Now that my internet's back up I should be able to sometime in the next couple weeks. :)

Nava2

2010-10-15 19:00:05

From: Coh3n
Knowing you, it's probably not much slower. :p

I'm actually curious. I'd like to take a look at it when I get more time. Now that my internet's back up I should be able to sometime in the next couple weeks. :)


Takes about 0.5ms which is not a big deal IMO for finding fishing spots. They are static for long periods of time anyways.

NCDS

2010-10-15 21:08:20

From: Coh3n
Knowing you, it's probably not much slower. :p

I'm actually curious. I'd like to take a look at it when I get more time. Now that my internet's back up I should be able to sometime in the next couple weeks. :)


We'll talk about it tomorrow as I've already began working on it the other day ;)