SRL Archive - Development

Compiling the latest version of simba with the git repo up to date:

simbaunit.pas(2574,21) Error: Identifier not found "TDownloadThread"
simbaunit.pas(2574,21) Error: Error in type definition
simbaunit.pas(2576,23) Error: Identifier not found "TDownloadThread"
simbaunit.pas(2578,5) Error: Illegal qualifier
simbaunit.pas(2579,15) Error: Illegal qualifier
simbaunit.pas(2876,33) Error: Identifier not found "TDownloadThread"
simbaunit.pas(2876,33) Error: Error in type definition
simbaunit.pas(2890,36) Error: Identifier not found "TDownloadThread"
simbaunit.pas(2892,18) Error: Illegal qualifier
simbaunit.pas(2893,24) Error: Illegal qualifier
simbaunit.pas(3294) Fatal: There were 10 errors compiling module, stopping

Does another unit need included? What is TDownloadThread and was it used before?

edit:
Now that I got my automated build system set up you guys can see the full error log:
http://www.moparisthebest.com/downloads/simba/errors/make.2010-09-12_13.log

This is the last commit that compiled successfully:
https://git.villavu.com/?p=simba.git;a=commit;h=6dbf5668796cfb8bc32f17fefb12925bc6f4dd4d
(which can be found here)

Which means that this commit:
https://git.villavu.com/?p=simba.git;a=commit;h=4a357ec461bc237198801c7b7aeaa403b6ac15ba
(error log here)
Broke it somehow, which I don't understand as it doesn't modify simbaunit.pas which is the file we are erroring out on.

Any ideas you pascal gurus?

I found the problem, TDownloadThread got put in the updater unit, and 'updater' isn't in the uses section in simbaunit.pas or psextension.pas, here is a patch that fixes it (or apply it manually):

diff --git a/Projects/Simba/psextension.pas b/Projects/Simba/psextension.pas
index 768f1a4..a79734b 100644
--- a/Projects/Simba/psextension.pas
+++ b/Projects/Simba/psextension.pas
@@ -7,7 +7,7 @@ interface
 uses
   Classes, SysUtils, virtualextension, forms, client, uPSComponent,uPSCompiler,
   uPSRuntime, stdCtrls, uPSPreProcessor,MufasaTypes,MufasaBase, web,
-  bitmaps, plugins, libloader, dynlibs,internets,scriptproperties, settingssandbox;
+  bitmaps, plugins, libloader, dynlibs,internets,scriptproperties, settingssandbox, updater;
 
 
 
diff --git a/Projects/Simba/simbaunit.pas b/Projects/Simba/simbaunit.pas
index 5dab432..1ec1c7a 100644
--- a/Projects/Simba/simbaunit.pas
+++ b/Projects/Simba/simbaunit.pas
@@ -42,7 +42,7 @@ uses
   stringutil,mufasatypesutil,mufasabase,  v_ideCodeParser,
   about, framefunctionlist, ocr, updateform, Simbasettings, psextension, virtualextension,
   extensionmanager, settingssandbox, v_ideCodeInsight, CastaliaPasLexTypes,
-  CastaliaSimplePasPar, v_AutoCompleteForm, PSDump, settings;
+  CastaliaSimplePasPar, v_AutoCompleteForm, PSDump, settings, updater;
 
 const
   SimbaVersion = 715;

Think one of you guys can commit that so my auto-build script spits out binaries instead of error logs? Thanks. :)

edit: While you are messing with commiting that, mind deleting 'Units/RUTIS/RUTIS_Errors.rst' from git? It's created/changed each time you compile, so it really shouldn't be distributed.

Applied. Sorry for the delay.

From: Wizzup?
Applied. Sorry for the delay.

No problem, and my system worked automatically just like it should too:

http://www.moparisthebest.com/downloads/simba/2010-09-17_14/

:D

We should really fix all those warnings too… :p

From: Wizzup?
We should really fix all those warnings too… :p

That would really make the logs alot shorter and more readable. :garfield:

You could make it ignore hints? It would shrink the log a lot. Plus, a lot of those hints can't be "fixed" anyway.

From: nielsie95
You could make it ignore hints? It would shrink the log a lot. Plus, a lot of those hints can't be "fixed" anyway.

Pascalscript ones anyway.

From: nielsie95
You could make it ignore hints? It would shrink the log a lot. Plus, a lot of those hints can't be "fixed" anyway.

I just gave that a shot, and fpc seems to be ignoring whatever I specify. I tried '-v0' and '-vw' as an argument both in fpc.cfg and the makefile, and it shows everything it always did including hints. No idea why though, I don't suppose anyone here has an idea? :confused:

I recall an ancient discussion on FPC about warnings / hints. I think the final decision was that some warnings are always shown; because they are simply too bad now to be shown. May be the case with the PascalScript ones.

-Vewm4055,5024,4035,5036,5057

Something like that?

From: Wizzup?
I recall an ancient discussion on FPC about warnings / hints. I think the final decision was that some warnings are always shown; because they are simply too bad now to be shown. May be the case with the PascalScript ones.

But I'm trying to hide just hints and notes, not warnings.

From: nielsie95
-Vewm4055,5024,4035,5036,5057

Something like that?

Same results. :(

That's weird :\