SRL Archive - MSI Suggestions

http://villavu.com/repositories/msi/Skills/Cooking.simba

TO-DO-list:
- MSI_MainLoop; is still not yet compatible with skills that withdraw items from the bank… I'll have to take a deeper look at the problem.
- MSI_CookFood; isn't yet complete either, but it's really close! All that's needed is to select 'Cook-All' option

We should start with a working cooker that cooks anything that can be fished using our fisher, then expand from there.

E: Should also be called MSI_CookFullInv because we're cooking the full inventory, not cooking until the inventory is full (it will already be full), and MSI_CookGear may not be needed. I know for fishing it looks for the fishing gear on the main screen and IIRC cooking isn't quite the same.

Good start though, I like how you're planning it first. :)

Each time a new fish is added to the fisher, it will automatically be added to the cooker wouldn't it? With FISH_RAW and so on, I mean :p

MSI_CookFullInv it is, then.

Ah, then we'll screw MSI_CookGer.. I though it was for inventory

From: Zyt3x
Each time a new fish is added to the fisher, it will automatically be added to the cooker wouldn't it? With FISH_RAW and so on, I mean :p

MSI_CookFullInv it is, then.

Ah, then we'll screw MSI_CookGer.. I though it was for inventory

Not quite automatic, there would have to be a few changes, but the item records would work for both, yes.

From: Coh3n
Not quite automatic, there would have to be a few changes, but the item records would work for both, yes.

That's what I meant :p

You might want to keep in the back of your mind that some of the future foods might include several ingredients ;)

~RM

From: Sir R. Magician
You might want to keep in the back of your mind that some of the future foods might include several ingredients ;)

~RM

I already have :p

Idea for making baking easy:

type
  TFood = record
    Ingredients: TIntegerArray;
    XPGain, ResultItem: Integer;

And when combining ingredients, just click the items in order Ingredients[0], Ingredients[1], Ingredients[2]…

:)

From: marpis
Idea for making baking easy:

type
  TFood = record
    Ingredients: TIntegerArray;
    XPGain, ResultItem: Integer;

And when combining ingredients, just click the items in order Ingredients[0], Ingredients[1], Ingredients[2]…

:)

I like that. I think we should really take advantage of types when we start new skills. Something we haven't really been doing so far.

Yeah, that's what I have been thinking..
I have made 3 cookers (not working ones.. Only finished planning and creating an efficient system on two of them <_<)

This is the system I used on the most recent one:

type TObj = record
       Name, UpText : String;
       DTM : Integer;
     end;
     TRecipie = record
       Name : String;
       MemberOnly : Boolean;
       Level, IngredientCount, Place : Integer;
       // Place: 0 = Range/Fire. 1 = Gnome. 2 = Brewing.
       Ingredients, UseWith : array of TObj;
     end;
     TCookingBook = array of array of TRecipie;
       { Fishes, Meats, Breads, Pies, Cakes, Stews, Pizzas, Drinks, Potatoes, Miscs}

So I am basing the recipies on that, but with MSI it will be easier because all that's needed is a TIntegerArray instead of (in this example) TObj.

I'm not sure where you're going with those types, but I'm sure you've planned it out. Keep it up. :)

Alright, Just wanted to make sure that I have not forgotten about this skill. But I have paused working on it until obstacle handling is working, because all cooking ranges have a door or a gate that you have to pass in order to get access to it, making the skill kinda useless unless you manually open the door/gate each and every 5 minutes or so.

From: Zyt3x
Alright, Just wanted to make sure that I have not forgotten about this skill. But I have paused working on it until obstacle handling is working, because all cooking ranges have a door or a gate that you have to pass in order to get access to it, making the skill kinda useless unless you manually open the door/gate each and every 5 minutes or so.

not the al-kharid range, which would probably be the most used anyways

Hey..! You're correct! I though that curtain was close-able…
I guess not! :)

I'll start on this again tomorrow then :)

From: Zyt3x
Hey..! You're correct! I though that curtain was close-able…
I guess not! :)

I'll start on this again tomorrow then :)

PM Me/post here if you want help with anything, I'll check back

Updated first post :)

From: Zyt3x

The only thing holding this skill back right now is MSI_MainLoop; in MainLoop.simba, as it (right now) is made for gathering scripts that deposit items into the bank, and not scripts that might require items to be taken out of the bank.

I would say to make an array for scripts that require withrawing items from the bank, and in the mainloop just do something like:

if InIntarray(CurrentScript, ScriptsThatWithdraw) then
  WithdrawStuff
else
  DepositStuff;

Just what popped into my head quick.

I was thinking about rewriting the mainloop in such a way we didn't have to do stuff like this for other skills too

From: Zyt3x
I was thinking about rewriting the mainloop in such a way we didn't have to do stuff like this for other skills too

What other option is there besides Withdrawing, Depositing, or Power Skilling that would need to be handled?

I generally think it's best to avoid rewriting code that works.

Add an attribute to the TScript record (Withdraw: Boolean;).

AtBank:
if (not MSI_BankMaterials) then // Bank the materials
begin
  if (MSI_TimedOut) then
    Break;

  MSI_UnsetPlayer('Failed to bank materials', False);
  Break;
end;

// If the script required some withdrawing after depositing
if (MSI_Players[CurrentPlayer].Scripts[CurrentScript].Withdraw) then
  if (not MSI_WithdrawMaterials) then
  begin
  end; 

From: NCDS
What other option is there besides Withdrawing, Depositing, or Power Skilling that would need to be handled?

I generally think it's best to avoid rewriting code that works.

Yeah.. When I was lying in bed trying to sleep yesterday, I though about the problem and came to the same conclusion as you, there is no other option :redface:

A Withdraw boolean would suffice, I'd believe :)

From: Zyt3x
Yeah.. When I was lying in bed trying to sleep yesterday, I though about the problem and came to the same conclusion as you, there is no other option :redface:

A Withdraw boolean would suffice, I'd believe :)

No no no, I like what you did with the pointer. :) I didn't think of that before.

From: Coh3n
No no no, I like what you did with the pointer. :) I didn't think of that before.

If you say so… :p :)

I won't be working on this in the weekdays. I have too much homework and assignments to finish.

From: Zyt3x
If you say so… :p :)

I won't be working on this in the weekdays. I have too much homework and assignments to finish.

No big deal, this is a busy time of year. ;)