SRL Archive - Reflection Development

R_LobbyScreen bug


CX gamer

2010-08-23 14:32:33

(Note: I have posted this thread on the main reflection subforum, but I managed to make it disappear.)

In Login.simba;

function R_LobbyScreen: Boolean;
begin
Result := (GetLoginIndex = 6);
end;
6 should be 7.
function R_RSReady: Boolean;
begin
Result := (R_LoggedIn) or (GetLoginIndex = 2);
end;
2 should be 3.
And also the description of GetLoginIndex in Core.simba
{*******************************************************************
Function LoginIndex: Integer;
By:
Description: Uses the LoginIndex hook.
2 = Logged Out, 4 = Logging Into Lobby, 6 = Lobbby,
8 = logging into game, 9 = Logged In. Reaches 10 at
some points, but with no significance.
********************************************************************}
2 should be 3, 4 should be 5, 6 should be 7, 8 should be 9 and 9 should be 10.
[PHP]GetLoginIndex
————-
Lag/not ready 0
Loaded title screen 1
Loaded update list 2
Title screen ready 3
??? 4
Logging in to lobby 5
??? 6
Lobby loaded 7
??? 8
Logging in to server 9
Loading game world 11
Game ready 10[/PHP]

EDIT: It may also be interesting to note that R_IsUpTextMulti always thinks there are 2 more options than there are more options available.
Example;
Client = Reflection
Walk here = Walk here / 2 More options
Use Bank booth / 4 more options = Use Bank booth / 6 more options
Walk here Van*Felipii (level: 98) / 4 more options = Walk here Van*Felipii (level: 98) / 6 more options

lordsaturn

2010-08-23 19:56:26

Awesome job debugging this. Fixes will be applied as soon as I can. Or feel free to fix it yourself.

CX gamer

2010-08-24 08:05:53

Alright. They should be added to attachments. R_LoginPlayer and R_LoginPlayerToLob should be working once again with this fix.

Disclaimer; these files are the files from revision 49 of the public svn with only the changes applied that were discussed in the first post of this topic.

CX gamer

2010-09-04 14:35:11

I don't want to sound rude or anything, but it has been 2 weeks and this hasn't been committed.

With these fixes, R_LoginPlayer will work perfectly, I've tested.