SRL Archive - Archive

Hey guys, what now needs to be done (since most scripts already have an awful lot of feedback) is to gather it all up and make it look beautiful.

I'm in China right now, so I don't really have the time to do it, so if anyone else wants to go ahead.. feel free to.

I'd suggest the following format, but however fits you:

From: RM

This is a better example, which I just simply decided to stick here :)

Technique (**/100)
[INDENT]- MANY global variables, I am sure there is some way to shorten that list.
+ Good use of type records and With..Do statements.
+ Autocoloring
+ Failsafes
- No failsafes in walking
- Could've used TPAs instead of FindObjCustom…[/INDENT]

Individuality (**/100)
[INDENT]+ Used a lot of custom functions.
+ Nice custom AntiBan function, although you anti ban too much.
+ Shows good understanding of the SRL include and it's functions.[/INDENT]

Follow all SRL Rules (**/100)
[INDENT]+ Free's DTMs and BMPs.
+ Uses timers to break out of some loops.
- Some loops would require a few more failsafes: eg SellOres, to be sure Shop Window is open
- SellOres could become infinite if no ShopScreen
+ Good use of FindNormalRandoms[/INDENT]

Creativity (**/100)
[INDENT]+ Randomization of Right/Left click
+ Custom walking functions and Types
- Could be a bit more creative with Rock Finding
+ Locating Method is extremly creative
+ Good method of storing information.
+ Interesting method of handling fights.
- Could have made an function that checks what pickaxe is being used so that the user doesn't have to enter it himself.[/INDENT]

Efficiency (74/100)
[INDENT]+ DTMs Freed.
+ Low waiting time between each step/function, makes the script faster.
+ Alot of minor tweaks here and there
- A lot of functions could be shortened
- Could have made a better use of cases[/INDENT]

Presentation (**/100)
[INDENT]+ A nice heading! I immediately understand what the script does and it's features.
+ Very detailed progress report!
+ Introduction!
+ Standards!
- More Comments throughout the script would've been nice.
- No Function / procedure headers.[/INDENT]

Meeting all requirements (**/100)
[INDENT]+ Yes.[/INDENT]

Added extras (**/100)
[INDENT]+ Option for dropping the ores / Powermining.
+ Banking
+ Clay Mining[/INDENT]

Total Score: (… / 800) = ..%

notice the pluses '+' and the minuses '-' and the colors and so on :) We need something that is easy to read and so on.


I'd also like to take the chance to say thank you to all those who have contributed so far :)

~RM

Not a problem, easy to be done.

Entry #3

Technique: 45
Individuality: 48
Follow All SRL Rules: 48
Creativity: 78
Efficiency: 27
Presentation: 38
Meeting all Requirements: 82
Added Extras: 22

The above is an averge of all the reported scores.

Wait you want that list overall? I only modified my feedback scoring to that xD, if you want the full thing sure i guess, but it cant be only one person tallying it up =/

EDIT: August 21, 2010, 3:32 PM. Since the finishing is due in about 4 days, ill take the responsibility of tallying all 3 scripts that were given. Underneath this edit is where each Entry will go. They will each contain basically the things that RM put up as an example in the first post. I plan on finishing all 3 by today. =] Leave it all to me :D Hopefully I don't do it too bad xD.

__________________________________________________________________________

Entry Number 1

Judges : J_Pizzle, Cigue, Heavenguard, TRiLeZ

Technique (68.75/ 100)
(85 + 75 + 50 + 65 = 275 [/4] = 68.75)
+ Used if..then statements, for..to..do loops
- Not many with..do statements, while..do loops.
+ Great use of dtms/cases.
+ Good TPA Usage.
+ Good Antiban.
- Low Anti-Random Detection.
- Not many Failsafes

Individuality (64.5/ 100)
(70 + 75 + 43 + 70 = 258 [/4] = 64.5)
- Same methods were repeatedly used.
- Does not show much knowledge of the SRL Include.
+ Used Alot of custom functions/procedures.

Follow All SRL Rules (86.25/ 100)
(95 + 80 + 90 + 80 = 345 [/4] = 86.25)
+ Script disables if player is not logged in.
+ Free's DTMs/Bitmaps.

Creativity (65/ 100)
(45 + 80 + 90 + 45 = 260 [/4] = 65)
+ Abundant TPA Usage
- Most functions/procedures are narrow /w no failsafes.

Efficiency (58.3/ 100)
(? + 90 + 30 + 55 = 175 [/3] = 58.3)
- Can use alot more things to help debugging.
- Functions could have been replaced/improved by SRL functions.
+ Freed DTMs/Bitmaps to reduce lag.

Presentation (57.5/ 100)
(80 + 40 + 55 + 55 = 230 [/4] = 57.5)
+ Organazation.
+ Easy to read.
- Procedures/Functions were not commented.
+ Good heading.
- Not so detailed progress report.

Meeting All Requirements (82.5/ 100)
(100 + 75 + 80 + 75 = 330 [/4] = 82.5)
- Faulty Anti-Random.
+ Progress Report.
+ Antiban.
+ Multiplayer.

Added Extras (32.5/ 100)
(0 + 100 + 30 + 0 = 130 [/4] = 32.5)
+ Talisman checker.

Total Score (515.3/ 800) = 64.41%
(68.75 + 64.5 + 86.25 + 65 + 58.3 + 57.5 + 82.5 + 32.5 = 515.3 [/8] = 64.41)

__________________________________________________________________________

Entry Number 2

Judges : J_Pizzle, Town, Cigue, Heavenguard

Technique (58.75/ 100)
(60 + 65 + 60 + 50 = 235 [/4] = 58.75)
+ Used if..then statements, for..to..do loops.
- Not many with..do statements, while..do loops.
+ Failsafes.
+ Autocolors.
- Used DTM's/Bitmaps excessively.
- Memory was not freed.
+ Marks were used.

Individuality (68.75/ 100)
(70 + 75 + 60 + 70 = 275 [/4] = 68.75)
+ Very good use of failsafes.
+ Debugging looks useful.
- Could have used more TPA usage rather then DTMs/Bitmaps/AC.

Follow All SRL Rules (80/ 100)
(85 + 85 + 60 + 90 = 320 [/4] = 80)
- An Endless Loop.
- Did not free memory.
+ Script disables if player is not logged in.

Creativity (70.25/ 100)
(80 + 85 + 70 + 46 = 281 [/4] = 70.25)
+ Universal Walking Method.
- Could have made it check for the talisman.

Efficiency (53.75/ 100)
(40 + 40 + 55 + 80 = 215 [/4] = 53.75)
- Memory could be freed with less use of Bitmaps/DTM's.
+ Failsafes were very good.
+ Has things to help debugging the script if necessary.
- Cases could have been easily used in places throughout the script.

Presentation (78.75/ 100)
(80 + 85 + 75 + 75 = 315 [/4] = 78.75)
+ Good Heading.
- Procedures/Functions were not commented.
+ Very detailed Progress Report.
+ Standards are good.
+ Organization.

Meeting All Requirements (92.5/ 100)
(100 + 100 + 80 + 90 = 370 [/4] = 92.5)
- Faulty AntiRandom.
+ Progress Report.
+ Antiban.
+ Multiplayer.

Added Extras (18.75/ 100)
(0 + 0 + 75 + 0 = 75 [/4] = 18.75)
- There are no added extras.

Total Score (521.5/ 800) = 65.19%
(58.75 + 68.75 + 80 + 70.25 + 53.75 + 78.75 + 92.5 + 18.75 = 521.5 [/8] = 65.19%)

__________________________________________________________________________

Entry Number 3

Judges : Town, Cigue, Heavenguard

Technique (44.67/ 100)
(45 + 45 + 44 = 134 [/3] = 44.67)
+ Used if..then statements, repeat..until loops.
- Not much of any other statement or loop.
- No TPA usage.
- Lack of Failsafes.
- Many unused variables and functions.

Individuality (48.3/ 100)
(65 + 65 + 15 = 145 [/3] = 48.3)
+ Bitmaps.
- Static co-ordinate movements.
+ Custom Antiban.

Follow All SRL Rules (48.3/ 100)
(40 + 45 + 60 = 145 [/3] = 48.3)
- Several Infinite Loops.
- Did not free DTM's/Bitmaps.
- Nonfunctional Multiplayer.
- Does not disable script if player is not logged in.


Creativity (78.3/ 100)
(70 + 65 + 100 = 235 [/3] = 78.3)
+ Grid Method.

Efficiency (26.67/ 100)
(35 + 25 + 20 = 80 [/3] = 26.67)
- Unused functions and variables.
- Infinite Loops.
- Majority of code could be replaced by SRL Functions.
- Code could have easily been shortened.

Presentation (38.3/ 100)
(40 + 45 + 30 = 115 [/3] = 38.3)
- No Script Instructions.
- Inconsistent Standards.
- Could be made easier to read.
+ Progress Report.

Meeting All Requirements (81.67/ 100)
(80 + 75 + 90 = 245 [/3] = 81.67)
+ Multiplayer is there although its unsuccessful.

Added Extras (30/ 100)
(0 + 50 + 40 = 90 [/3] = 30)
+ Air Talisman Support.
+ Air Tiara Support.

Total Score (396.21/ 800) = 49.53%
(44.67 + 48.3 + 48.3 + 78.3 + 26.67 + 38.3 + 81.67 + 30 = 396.21 [/8] = 49.53)

Based on the above scores
1. Entry #2
2. Entry #1
3. Entry #3
__________________________________________________________________________

J_Pizzle, you forgot to put 1 score for Entry #1, but in my opinion I think its a bit too late to put a judgement in at this point, since it would probably declare the winner/loser =P thats just in my opinion. Please feel free to check if any of the numbers are wrong, or if anything needs to be added ^^, took my time on it and did my best. Hopefully this will ease some trouble off of RM xD

Very nice.

~RM

The last two categories probably shouldn't be averaged. They're more objective.

Also, maybe point out top scores in each category. That would be more encouraging to those who don't win overall.

From: Town
The last two categories probably shouldn't be averaged. They're more objective.

Also, maybe point out top scores in each category. That would be more encouraging to those who don't win overall.

Well w/e we show to them will include that ^^, this was just meant to really break it down for us so we can see what has been done so far. Such as the judgements for each cat.

On a quick check.. EvilChicken's judgement isn't included in entry #1 for some reason… :redface: ?

~RM

From: Rasta Magician
On a quick check.. EvilChicken's judgement isn't included in entry #1 for some reason… :redface: ?

~RM

Im so sorry D: I really did not see any actual scoring, i just saw like l33t feedback but no actual voting points. I apologize, ill fix that right this moment sir.

Edit

GUYS: I really don't feel like rating the scripts. I don't really know why, but I just don't want to. So, this post is more like a "think of this when you rate the script"-thing. I might post a rating later. Feel free to post a comment if I misunderstood or accidentally'd something.

Ahhh =/ this was from EC's post. He gave in alot of good feedback, but I don't have any points to put up here D:
–if you meant if his commentary was put up ill get right to that [although I believe the main points he put out are already included], as I didn't read the -feedback- given from the judges, i just used there scoring sheet and analyzed there respective comments[that go with each rating] as effectively as i could.

Fair enough. Shoot me a PM once you've taken a last look at thing and we'll compile up the End of Competition thread.

~RM

I'd like to a look over everything first. Seems there's a large variation in scores for some parts, eg Entry 1 Creativity, Entry 2 Added extras.

Also I thought it was either 0 or 100 for 'All the requirements'?

From: ZephyrsFury
I'd like to a look over everything first. Seems there's a large variation in scores for some parts, eg Entry 1 Creativity, Entry 2 Added extras.

Also I thought it was either 0 or 100 for 'All the requirements'?

Please go ahead :)

As for the meeting the requirements.. it seems fairer to have it as flexible;
The point of it was to ensure that those who matched all the SRL guidelines to get 100 extra points. However these guidelines have been slowly changing.

~RM

From: ZephyrsFury
I'd like to a look over everything first. Seems there's a large variation in scores for some parts, eg Entry 1 Creativity, Entry 2 Added extras.

Also I thought it was either 0 or 100 for 'All the requirements'?

Much appreciated ^^. I can say that everyone was pretty much judging based on what they thought and saw throughout the script. Points were scattered here and there :P im not going to lie [its awefully visible when you read through some scoring], but overall I think each and every score from the judges were honest [based on the general/concrete feedback before scoring] and effective to say the least :D

From: Rasta Magician
Please go ahead :)

As for the meeting the requirements.. it seems fairer to have it as flexible;
The point of it was to ensure that those who matched all the SRL guidelines to get 100 extra points. However these guidelines have been slowly changing.

~RM

It was explicitly mentioned that it would be either 0 or 100 for meeting all requirements. I think its only fair that we apply that this competition and change it for future comps.

Perhaps specify the guidelines if thats the case? When i saw the example I could only see a Yes or No [which 100% backs up what your saying], just would be good to know that if a the scripter got all of the guidelines then he/she would get the points, or else he/she would get none.

Notes on the first script:

• Limited instructions to the script user on how to set up the players, where to place items, etc
• No commenting and documentation
• Misses a lot of begins and ends where needed (as indicated by indenting)
• Indenting quite improper in some places
• Misleading function name (Load_DTM actually goes, switches tabs and finds the dtm, returning true if found)
• Load_DTM doesnt work as planned for WhichDTM = 2 due to a missing begin/end
• if then statements in Load_DTM should take advantage of "else" to prevent the function from finding the dtm twice if WhichDTM is 2 or 4
• AreWeInBank: good use of colour finding for detecting location.
• Click_Tali assumes that the talisman is in Inv slot 1 however no mention of this requirement is made to the user
• WalkToAltar: Script terminates if length of search tpa is too low.. should actually try again or as a last resort switch players.
• Click_RCAltar: always results true (if player is logged in)
• BlindClick: Mouse(582, 130, 2, 3, True); 2 and 3 are too small a randomness, could be bannable
• Find_RCAltar, Find_Portal: both return TPoints but you never check if the points are valid (ie did the functions successfully execute and the result isn't (0,0))
• Leave_Altar: MMouse(Find_Portal.x, Find_Portal.y +12, 2, 2); is inefficient. Should do one Find_portal and assign the result to a variable (eg p := Find_portal) then use that variable (MMouse(P.X, P.Y + 12, 2, 2);)
• Leave_Altar: if (TimeFromMark(time) > 20000) then TerminateScript; Again you should switchplayers if the function fails. This line looks redundant anyway since it isn't being called in a loop or anything that would cause the time to go over 20 seconds.
• WalkToBank: another terminate script
• the for i := 0 to 4 do loop has no purpose if its being broken out of by the TerminateScript
• WalkToBank will never return true because TimeFromMark(t) is never going to be greater than 30000 when it's being checked
• In_Altar doesn't break out of the for i := 0 to z loop even if the altar is found and the runes are successfully crafted.
• Main_Deposit: missing begin and end screws up the logic.
• No/limited multiplayer - Doesn't switch players if anything goes wrong, things just get stuck in an infinite loop or script terminates
• Antiban and antirandoms only called in two places, just before leaving the altar and while moving inside the altar

I'm not sure what's going to happen next, I think RM and I might adjust some marks based on our opinions but I'll keep commenting on each script individually.

Sorry guys. I haven't the time to look through the rest of the scripts yet but here are some comments that you might like to have a look at/add:


Entry Number 1

Judges : J_Pizzle, Cigue, Heavenguard, TRiLeZ

Technique (68.75/ 100)
(85 + 75 + 50 + 65 = 275 [/4] = 68.75)
+ Used if..then statements, for..to..do loops
- Not many with..do statements, while..do loops.
+ Great use of dtms/cases.
+ Good TPA Usage.
+ Good Antiban.
- Low Anti-Random Detection.
- Not many Failsafes

I don't think the choice of loops should be +ve or -ve for technque. If you prefer to use one time of loop then that should be fine. And with do statements… tidy code a bit but doesn't really affect technique.

Also see my notes above about missing begins and ends, redundant and sometimes catastrophic misuse of TimeFromMark and little to no failsafes - I think technique is quite average.

Individuality (64.5/ 100)
(70 + 75 + 43 + 70 = 258 [/4] = 64.5)
- Same methods were repeatedly used.
- Does not show much knowledge of the SRL Include.
+ Used Alot of custom functions/procedures.


Follow All SRL Rules (86.25/ 100)
(95 + 80 + 90 + 80 = 345 [/4] = 86.25)
+ Script disables if player is not logged in.
+ Free's DTMs/Bitmaps.

Yup follows all that I can think of.

Creativity (65/ 100)
(45 + 80 + 90 + 45 = 260 [/4] = 65)
+ Abundant TPA Usage
- Most functions/procedures are narrow /w no failsafes.

Eh Abundant TPA usage.. hardly creative IMO. Just more or less your typical TPA type object finders. The functions in the script are quite commonly seen with most scripts. Not much special. The AreWeInBank function checking for the colour of the bank carpet is pretty good though.

Efficiency (58.3/ 100)
(? + 90 + 30 + 55 = 175 [/3] = 58.3)
- Can use alot more things to help debugging.
- Functions could have been replaced/improved by SRL functions.
+ Freed DTMs/Bitmaps to reduce lag.

Couple of places where colour/dtm searching is done more than once unnecessarily. Doesn't break out of some loops when searching or interacting with objects. Good use of a general item finder though.. no individual functions for FindTalisman, FindTiara, FindWhatever which is good.

Presentation (57.5/ 100)
(80 + 40 + 55 + 55 = 230 [/4] = 57.5)
+ Organazation.
+ Easy to read.
- Procedures/Functions were not commented.
+ Good heading.
- Not so detailed progress report.

No commenting, very limited documentation (how am I supposed to know to put my tally in slot 1?) I wouldn't agree the script was easy to read due to lack of commenting and also due to inappropriate and insufficient indenting in some places.

Meeting All Requirements (82.5/ 100)
(100 + 75 + 80 + 75 = 330 [/4] = 82.5)
- Faulty Anti-Random.
+ Progress Report.
+ Antiban.
+ Multiplayer.

I'd say antiban, antirandoms is lacking and multiplayer is not properly implemented (doesn't switch players when something goes wrong, just terminates the script). Probably a score of 0 for this section.

Added Extras (32.5/ 100)
(0 + 100 + 30 + 0 = 130 [/4] = 32.5)
+ Talisman checker.

Ok talisman checker is a plus but not much else that I can see.

Total Score (515.3/ 800) = 64.41%
(68.75 + 64.5 + 86.25 + 65 + 58.3 + 57.5 + 82.5 + 32.5 = 515.3 [/8] = 64.41)


Anyways good job with judging guys. Thank you :)

Doesn't really matter than some judges are harsher than others as long as you were all equally harsh/lenient for all scripts. So yeah, not sure what's happening next. Ask RM :p

Thanks for that Post Zeph ^^, much appreciated. I can change the scores up a bit if you want XD, or I can add a personal score from your self to that entry. I dunno which one to do xD so confused at the moment, its August, scores are do 2 :X so ill make fast changes soon as I figure out what to change / implement.

From: Heavenguard
Thanks for that Post Zeph ^^, much appreciated. I can change the scores up a bit if you want XD, or I can add a personal score from your self to that entry. I dunno which one to do xD so confused at the moment, its August, scores are do 2 :X so ill make fast changes soon as I figure out what to change / implement.

Nah don't change any scores. RM and I will change them if necessary.

From: ZephyrsFury
Nah don't change any scores. RM and I will change them if necessary.

ok ^^ Thanks.