SRL Archive - SRL Suggestions

Convert to '..Multi'?


NCDS

2010-08-08 21:12:18

Well I have been doing it with MSI as well as my Yew Cutter and everything seems to go rather smooth.

My suggestion; do the same for SRL. To be quite honest, searching for a single uptext or option can be quite unreliable at times.

So replace the:

if ChooseOption() then
with:

if WaitOptionMulti() then

Same thing with UpTexts.

I really can't see any reason not to do this, as it really just adds two extra fail safes in the same line.

Is there a downside to this at all?

Let me read your thought's.

Coh3n

2010-08-08 22:27:41

From: NCDS

Is there a downside to this at all?.

Nope. I agree. It may take some time to replace all the instances, but it wouldn't hurt.

EvilChicken!

2010-08-08 23:40:51

Yes, absolutely.
I've actually considered to start applying this to SRL myself, in various places.

The way that makes the most sense to me, is to arrange the entries so that you first specify the option/uptext you're searching for in it's full length. The next entries are to be shortened to the minimal length you possible whilst still being accurate.
So, an example of an uptextMulti array for "Open Door" would be:
['Open door', 'pen d', 'oor'] or something like that.

Sorry if I'm stating obvious things – I'm just sharing my mind here.

NCDS

2010-08-08 23:42:08

From: EvilChicken!
Yes, absolutely.
I've actually considered to start applying this to SRL myself, in various places.

The way that makes the most sense to me, is to arrange the entries so that you first specify the option/uptext you're searching for in it's full length. The next entries are to be shortened to the minimal length you possible whilst still being accurate.
So, an example of an uptextMulti array for "Open Door" would be:
['Open door', 'pen d', 'oor'] or something like that.

Sorry if I'm stating obvious things – I'm just sharing my mind here.


That's exactly how I do it :p




I have no problem helping convert thing's, but should I just post them here?

EvilChicken!

2010-08-09 00:09:18

Hm, if you just went through the various SRL includes, posting your changes in any other form than a .PATCH would seem silly.
So, yeah, a patch would be awesome.

E: To actually answer your question; make a new thread in the /core/-fixes thread. :p