SRL Archive - First Scripts

Hey guys, I just started scripting today, wanted to show you guys this so you could tell me how this could work better, because obviously if you try running it, the color usage isn't very suitable. It has antiban, but not very good since I couldn't think of anything to do for antiban other than skills and pickupmouse. Please, give me your criticism and your recommendation. Later, once I figure out radial walking I will make it bank, but right now it only cuts one load then logs out. You can find me in IRC under Universe. Thanks R0b0t1, Blumblebee, and Ogre for giving me motivation and also helping me out :D

EDIT: Removed attachment to save my ass from h4cz0rz and to hopefully add banking.

:D Great to see you put effort into making a script. I am not going to give you any feedback on the actual script though, as it wouldn't seem right =/. You said you didn't learn radialwalk and other methods, it wouldn't be fair for me to criticize or recommend things to you. For the most, I can tell you a job well done on taking the initiative to get better and showing us something. After your finished learning the basics in beginning - advanced, you can be sure ill be ready to give you some great positive feedback, both on things you learned, things youve taught me, and things you can/should do =]. :D Keep it up bro.

-Heavenguard

Thanks to my friend Blumblebee, I'm learning how to do radial walking so hopefully I'll have a fully banking script. After that, then I'll start doing more advanced techniques to make sure it runs perfect. Thanks, but also I would enjoy for you to tell me about standards and if there is something that I can do instead that will simplify my process. I appreciate it ;)

From: Universe
Thanks to my friend Blumblebee, I'm learning how to do radial walking so hopefully I'll have a fully banking script. After that, then I'll start doing more advanced techniques to make sure it runs perfect. Thanks, but also I would enjoy for you to tell me about standards and if there is something that I can do instead that will simplify my process. I appreciate it ;)

One on one advice is always great, but don't forget to look up tutorials on the subject as well [sometimes tuts imo are more rewarding], but since you are respectably asking for some simple feedback, i would have no problem in doing so.

Procedure DeclarePlayers; Very nice, but it could be better and easier to read if you used a with..do statement instead.

Procedure DeclarePlayers;
begin
  HowManyPlayers := 1;
  NumberOfPlayers(HowManyPlayers);
  CurrentPlayer := 0;

  with Players[0] do
  begin
    Name := 'HowDoIChopTree';
    Pass := 'butHowDoIChopit';
    Nick := 'chop';
    Member := False;
    Active := True;
  end;

end; 

As for the Antiban, its fine and you seem to get the concept of it. Great work =].

Procedure MakeCameraNotTerrible; I would change the name of this procedure to something more simple, such as FixCamera, or MakeCamera. I don't know why you want it to press the key up, wait 2 seconds, then press it down =/ but regardless, i think what your doing in this procedure could be summed up with a simple MakeCompass(); and SetAngle(); function.

Procedure ChopTree; It looks alright. You forgot to set an "until" in your repeat .. until loop.

Overall: Theres nothing really to criticize [very small script so far], there are many things that can be added. Im not going to say anything that should be fixed, its extremely novice, and it should be only for you to practice with. If I were you I wouldn't concentrate on making a full script out of this, instead I would use it as a set of notes to learn from. Theres so much more that you can do, just keep learning and learning and practicing, and try not to worry about what others should expect from you, your doing great the way it is =].

From: Heavenguard
One on one advice is always great, but don't forget to look up tutorials on the subject as well [sometimes tuts imo are more rewarding], but since you are respectably asking for some simple feedback, i would have no problem in doing so.

Procedure DeclarePlayers; Very nice, but it could be better and easier to read if you used a with..do statement instead.

Procedure DeclarePlayers;
begin
  HowManyPlayers := 1;
  NumberOfPlayers(HowManyPlayers);
  CurrentPlayer := 0;

  with Players[0] do
  begin
    Name := 'HowDoIChopTree';
    Pass := 'butHowDoIChopit';
    Nick := 'chop';
    Member := False;
    Active := True;
  end;

end; 

As for the Antiban, its fine and you seem to get the concept of it. Great work =].

Procedure MakeCameraNotTerrible; I would change the name of this procedure to something more simple, such as FixCamera, or MakeCamera. I don't know why you want it to press the key up, wait 2 seconds, then press it down =/ but regardless, i think what your doing in this procedure could be summed up with a simple MakeCompass(); and SetAngle(); function.

Procedure ChopTree; It looks alright. You forgot to set an "until" in your repeat .. until loop.

Overall: Theres nothing really to criticize [very small script so far], there are many things that can be added. Im not going to say anything that should be fixed, its extremely novice, and it should be only for you to practice with. If I were you I wouldn't concentrate on making a full script out of this, instead I would use it as a set of notes to learn from. Theres so much more that you can do, just keep learning and learning and practicing, and try not to worry about what others should expect from you, your doing great the way it is =].

Okay, I used the DeclarePlayers form instead of the one I had, I agree it looks cleaner and if I support multiplayer that would be the thing I would use. I changed the name to FixCamera, but the reason why I used the arrow key was because I wished to use the highest camera settings above the character, and I couldn't figure out what the command was. If you could tell me what that is, then I'll use that instead of using the keys, because the keys could cause conflict in SMART because of minimizing. I don't understand about the until, should I use until (InvFull) or what.

From: Universe
Okay, I used the DeclarePlayers form instead of the one I had, I agree it looks cleaner and if I support multiplayer that would be the thing I would use. I changed the name to FixCamera, but the reason why I used the arrow key was because I wished to use the highest camera settings above the character, and I couldn't figure out what the command was. If you could tell me what that is, then I'll use that instead of using the keys, because the keys could cause conflict in SMART because of minimizing. I don't understand about the until, should I use until (InvFull) or what.

This is kinda why I say you should continue learning before making the script lol, it will make it much easier to read feedback and it will broaden your ability to script by 1000%.

Coh3n's All-In-One Tutorial

As for the function to raise your characters camera, I included it in the feedback I gave you ^^.