SRL Archive - MSI Suggestions

UPDATED:
Thanks to Troll, this is now in a beta stage. I've personally tested and it's worked for a few loads so far. Currently it only crafts Air runes, but all (or most) runes can be added in only a few lines of code. It doesn't work with the form yet, but if you wish to test it out, this version of MSI can be downloaded here. Be sure to set your player's Scripts[0].Name to SCRIPT_RUNECRAFTER_AIR. The Rune essence also has to be visible in the bank.

What's left to do:

• Withdraw tiara from bank if not found on player
• Fix experience calculation
• Add the rest of RCing locations (P2P I need an account)
• Air
• Earth
• Mind
• Body
• Fire
• Water

Any testing is greatly appreciated.

Oh, and the experience counting currently doesn't work properly. It counts all runes that were crafted, rather than just the essence used. It will be fixed, so don't worry.

Here is a progress report that I got last night:

{----------------------------------------------------------------}
{                    MSI Phoenix Player Report                   }
{----------------------------------------------------------------}
{     Time Running: 51 Minutes and 29 Seconds                    }
{----------------------------------------------------------------}
{                                                                }
{     Player 0:                                                  }
{     Location: Varrock West Bank                                }
{     Time:     48m 34s                                          }
{     Active:   False                                            }
{       Reason: Ran out of supplies                              }
{                                                                }
{     Script: Air Runecrafter                                    }
{       Time:  48m 34s                                           }
{       Skill: Runecrafting                                      }
{       Exp:   8,305                                             }
{       Level: 23                                                }
{       Loads: 23                                                }
{         Item:   Air rune                                       }
{         Amount: 1,661                                          }
{                                                                }
{----------------------------------------------------------------}
{----------------------------------------------------------------}

{----------------------------------------------------------------}
{                    MSI Phoenix Player Report                   }
{----------------------------------------------------------------}
{     Time Running: 8 Minutes and 18 Seconds                     }
{----------------------------------------------------------------}
{                                                                }
{     Player 0:                                                  }
{     Location: Varrock East Bank                                }
{     Time:     07m 27s                                          }
{     Active:   True                                             }
{                                                                }
{     Script: Earth Runecrafter                                  }
{       Time:  07m 27s                                           }
{       Skill: Runecrafting                                      }
{       Exp:   864                                               }
{       Level: 25                                                }
{       Loads: 3                                                 }
{         Item:   Earth rune                                     }
{         Amount: 133                                            }
{                                                                }
{----------------------------------------------------------------}
{----------------------------------------------------------------}

__________________________________________

Yes, .simba and? :D

So I have started working on runecrafting. I have been planning it more than writing so not much progress done(in code), but I am still figuring out MSI. I have to admit some over-nine-thousand-dimensional-arrays are confusing :p, but I get it mostly(like 87,31% +/- 10%).
I don't like working with something a can't fully understand.

I have tested this 2 object record at every f2p altar and they are working well:

• The outer altar(which you click to get into the temple) seems to be the same for them(not the glowing color).
• The symbols on the inner altars(which you click to craft runes) also seems to have the same color.

I will test them more of course, but my question is: if they are really the same is it okay to have only one record for the altars? (1 for outer, 1 for inner)
Portal colors are different …(maybe some of them are similar, but I have only tested the record in the air temple)

Things that I have stumbled upon:

• There's no really worst/best tool for rc you can wear tiaras for +1 inventory slot. (MSI_SetupPlayer)
• Runes are stackable and you have to count those, as far as I can see MSI_CountItems not counting stackables(correct me if I'm wrong), but a simple if/case should be enough depending if the item is stackable or not.
• Experience <> runes made. We will have to divide the runes based on the player's rc lvl then multiple by xp.(MSI_CountItems ?)No, not really, read posts below.
• You have to use the bank to withdraw your essence not only depositing. I was thinking making the essence as a tool but that's really a bad idea, imo.(MSI_BankMaterials)
• Runes should be the AssociatedItems for the inner altar object? Because then we have to have the same object record for each altar only with different AssociatedItems for each one(air rune, fire rune, etc).

That's all I can think of now.

Please note that names I use in the thread are only for this thread.(inner altar and things like that)

Experience <> runes made. We will have to divide the runes based on the player's rc lvl then multiple by xp.(MSI_CountItems ?)

I don't think you said that right. You can get the exp based on the essence, not the crafted runes (you get random amounts every time based on your level, and you get exp based on the essence you use, not how many runes you make).

Other than that (too lazy to check the colors of everything), looks good. The only thing is when you check the colors, check them once, refresh the page, then check again. And you could try using ACA to look at how accurate your color is. :)

From: i luffs yeww
You can get the exp based on the essence, not the crafted runes (you get random amounts every time based on your level, and you get exp based on the essence you use, not how many runes you make).

That's almost the same I was about to post a few mins ago but just to make things sure I looked it up in rswiki. And even with explorer ring you get more xp based on the altar's default xp gain. And I know you get xp by essence that's why you have to divide based on the skill lvl, you are not making random amounts. Let's say you are lvl 44-54, you make 5x air runes so you have to divide the rune amount by 5 and multiple by 5(xp/essence), no?

I have used aca to collect like dozens of colors already(I have refreshed page every time)(I have saved the files if you are interested). And made the object records. I sure forgot things but I have not started scripting now :p.

From: Sabzi
So I have started working on runecrafting. I have been planning it more than writing so not much progress done(in code), but I am still figuring out MSI. I have to admit some over-nine-thousand-dimensional-arrays are confusing :p, but I get it mostly(like 87,31% +/- 10%).
I don't like working with something a can't fully understand.

Made me literally laugh out loud. :p

From: Sabzi

I have tested this 2 object record at every f2p altar and they are working well:

• The outer altar(which you click to get into the temple) seems to be the same for them(not the glowing color).
• The symbols on the inner altars(which you click to craft runes) also seems to have the same color.

I will test them more of course, but my question is: if they are really the same is it okay to have only one record for the altars? (1 for outer, 1 for inner)
Portal colors are different …(maybe some of them are similar, but I have only tested the record in the air temple)

I don't see why not. I think we should use different consts because of the AssociatedItems part (as they are different for each alter). We can manipulate the case to use the same attributes for everything except AssociatedItems (check out the Fishing spot obects).

From: Sabzi

Things that I have stumbled upon:

1. There's no really worst/best tool for rc you can wear tiaras for +1 inventory slot. (MSI_SetupPlayer)
2. Runes are stackable and you have to count those, as far as I can see MSI_CountItems not counting stackables(correct me if I'm wrong), but a simple if/case should be enough depending if the item is stackable or not.
3. Experience <> runes made. We will have to divide the runes based on the player's rc lvl then multiple by xp.(MSI_CountItems ?)
4. You have to use the bank to withdraw your essence not only depositing. I was thinking making the essence as a tool but that's really a bad idea, imo.(MSI_BankMaterials)
5. Runes should be the AssociatedItems for the inner altar object? Because then we have to have the same object record for each altar only with different AssociatedItems for each one(air rune, fire rune, etc).

That's all I can think of now.

1. We don't necessarily have to use BestTool/Worst tool. Take a look at what's there for fishing, it doesn't use it.
2. No, it doesn't count stackable items, and yes, an if/then should work just fine. :)
3. I think i luffs yeww was trying to say this. You should just be able to multiply the number of essence you have by the xp per rune rather than dividing. So before crafting, just record the number of essence in the inventory. However, it may be better to calculate the essence AFTER you've crafted, to be sure that you actually did craft.
4. We could add an attribute to the TScript record (RequiresWithdrawal) then have an if/then case in MSI_BankMaterials that withdraws the required materials (this may require a WithdrawItems attribute in TScript as well).
5. Yes, runes would be the associated items.

You're wrong about dividing, again. :p Jagex "updated" it so if you're 44 rc, you can still make double nats on SOME of the essence. You can randomly get more on some based on your level. One load you may get 30 airs, another you may get 40.

As I just stated, dividing wouldn't work. Check how much essence you have (should be 28, depending on using tiara/tally, and pouches I suppose), and then check to see if you actually did craft (InvCount/DTM/bitmap/color check.. there are really tons of ways on doing this).

From: i luffs yeww
You're wrong about dividing, again. :p Jagex "updated" it so if you're 44 rc, you can still make double nats on SOME of the essence. You can randomly get more on some based on your level. One load you may get 30 airs, another you may get 40.

Oh, I haven't played rs for a few months, I didn't know that, thanks for clearing things up. Stupid Jagex what is the point of that?

From: i luffs yeww
Check how much essence you have (should be 28, depending on using tiara/tally, and pouches I suppose)

^That's what I was doing in my old rcer, but I wanted a more accurate method(because of explorer ring randomness).
Guess we should go with less accuracy.(again, stupid Jagex)

From: Sabzi
Oh, I haven't played rs for a few months, I didn't know that, thanks for clearing things up. Stupid Jagex what is the point of that?

As a legit player I would say that's awesome! Extra runes, ftw. :p

Since pouches are P2P, don't worry about them right now. Let's get the F2P side of it working first. :)

Umm.. Apparently people were complaining about runecrafting being too hard to train because you don't get anything good until 91 (double nature runes), which is too much work for all the little seven year olds playing the game, so Jagex ruined many many hundreds of hours of work that tons of other people did and made natures not as profitable. >_>

bump?

~RM

Yeah, yeah, I work on this. But university is coming, we just bought a flat for me :blink:.

Let's not forget about this guy's.

We've got quite a few unfinished skills atm.

Sabzi, if you could please post any code you've written so far that would greatly appreciated so we can continue to expand on it.

Also, maybe some of the POMS dev's would like to get involved in this? Any assistance would be appreciated.

I am not sure how to go about it but cant this be done using already made eveything now.

If we look at money making we go to a place and change something into something else, and in the miner (maybe others) we can handle obstacles. So we walk to a place use an obstacles use a material on the alter then use obstacles walk back repeat. So i hope that should not be too hard and if some one could help me though, i would say i am ok at scripting and might be able to do it if some one gave a hand in sayying what it is i have to do to work best with MSI

From: Troll
I am not sure how to go about it but cant this be done using already made eveything now.

Yes! That's what I've been trying to tell people. Almost every skill can be added within minutes because all the functions are already made. :p

From: Troll

If we look at money making we go to a place and change something into something else, and in the miner (maybe others) we can handle obstacles. So we walk to a place use an obstacles use a material on the alter then use obstacles walk back repeat. So i hope that should not be too hard and if some one could help me though, i would say i am ok at scripting and might be able to do it if some one gave a hand in sayying what it is i have to do to work best with MSI

I'm willing to help in anyway I can. :) This guide is a good place to start (I think it'll do the trick for everything you need).

Off the top of my head, a rough plan would be something like:

• TObstacle records for Alter & Portal
• TMSObject for Alter (inside and out; may be able to use the same one) & Portal
• TLocation for the locations you want to add
• TItem for talisman/tiara (probably don't need to support both; tiara may be fine) - Same DTM, but different color (see hatchets/pickaxes in Items.simba) - maybe pouches?
• TMaterial for ESSENCE_RUNE and ESSENCE_PURE.
• TScript for whichever locations you want to add
• Functions needed:
• MSI_SetupRunecrafting (pointed to TScript.PlayerSetup)
This would have to look for the tiara (MSI_FindTool would probably work) and pouches if they're included. MSI_SetupCooking will be similar, may be able to look at that.
• MSI_CraftRunes (pointed to TScript.AutoObjects)
This would probably just have to call MSI_ConvertMaterial.

I'm probably missing some stuff, but that should give you a good start. Also if you need any help with git just let me know. :)

Ok i should be able to do all of that, however i will be no use with pouches never used them and im not a member :p And yeah when im done ill need help with git as i have never used it.

From: Troll
Ok i should be able to do all of that, however i will be no use with pouches never used them and im not a member :p And yeah when im done ill need help with git as i have never used it.

You need to setup git before you start making changes. You should also disable the MSI updater if you're using it. The guide I posted above has a section on setting up git. Just message me if you get stuck. :)

From: Coh3n
You need to setup git before you start making changes. You should also disable the MSI updater if you're using it. The guide I posted above has a section on setting up git. Just message me if you get stuck. :)

Ok, thanks again and good job RS is down so i hav'nt made any changes yet :)

From: Troll
Ok, thanks again and good job RS is down so i hav'nt made any changes yet :)

No problem and good luck! :)

Glad to see this skill being worked on again :)

Thanks to Troll, this is now in a beta stage. I've personally tested and it's worked for a few loads so far. Currently it only crafts Air runes, but all (or most) runes can be added in only a few lines of code. It doesn't work with the form yet, but if you wish to test it out, this version of MSI can be downloaded here. Be sure to set your player's Scripts[0].Name to SCRIPT_RUNECRAFTER_AIR. The Rune essence also has to be visible in the bank.

Any testing is greatly appreciated.

Oh, and the experience counting currently doesn't work properly. It counts all runes that were crafted, rather than just the essence used. It will be fixed, so don't worry.

As I am not really active, nor participating in anything srl related I would suggest just to simply take over the 1st post or make a new thread for easier management.
It's more convenient to use 1st post for status, etc, no?

From: Sabzi
As I am not really active, nor participating in anything srl related I would suggest just to simply take over the 1st post or make a new thread for easier management.
It's more convenient to use 1st post for status, etc, no?

Okay will do, thanks. :)

E: Updated the first post, and here's a report from last night.

{----------------------------------------------------------------}
{                    MSI Phoenix Player Report                   }
{----------------------------------------------------------------}
{     Time Running: 51 Minutes and 29 Seconds                    }
{----------------------------------------------------------------}
{                                                                }
{     Player 0:                                                  }
{     Location: Varrock West Bank                                }
{     Time:     48m 34s                                          }
{     Active:   False                                            }
{       Reason: Ran out of supplies                              }
{                                                                }
{     Script: Air Runecrafter                                    }
{       Time:  48m 34s                                           }
{       Skill: Runecrafting                                      }
{       Exp:   8,305                                             }
{       Level: 23                                                }
{       Loads: 23                                                }
{         Item:   Air rune                                       }
{         Amount: 1,661                                          }
{                                                                }
{----------------------------------------------------------------}
{----------------------------------------------------------------}

E2: Earth crafting added (stopped manually).

{----------------------------------------------------------------}
{                    MSI Phoenix Player Report                   }
{----------------------------------------------------------------}
{     Time Running: 8 Minutes and 18 Seconds                     }
{----------------------------------------------------------------}
{                                                                }
{     Player 0:                                                  }
{     Location: Varrock East Bank                                }
{     Time:     07m 27s                                          }
{     Active:   True                                             }
{                                                                }
{     Script: Earth Runecrafter                                  }
{       Time:  07m 27s                                           }
{       Skill: Runecrafting                                      }
{       Exp:   864                                               }
{       Level: 25                                                }
{       Loads: 3                                                 }
{         Item:   Earth rune                                     }
{         Amount: 133                                            }
{                                                                }
{----------------------------------------------------------------}
{----------------------------------------------------------------}

E3: Fire runecrafting added.

{----------------------------------------------------------------}
{                    MSI Phoenix Player Report                   }
{----------------------------------------------------------------}
{     Time Running: 6 Minutes and 58 Seconds                     }
{----------------------------------------------------------------}
{                                                                }
{     Player 0:                                                  }
{     Location: Al Kharid Bank                                   }
{     Time:     06m 32s                                          }
{     Active:   True                                             }
{                                                                }
{     Script: Fire Runecrafter                                   }
{       Time:  06m 32s                                           }
{       Skill: Runecrafting                                      }
{       Exp:   798                                               }
{       Level: 26                                                }
{       Loads: 3                                                 }
{         Item:   Fire rune                                      }
{         Amount: 114                                            }
{                                                                }
{----------------------------------------------------------------}
{----------------------------------------------------------------}

Both Mind and Water Runecrafting has been added. I'll add Body soon, then release.

From: Coh3n
Both Mind and Water Runecrafting has been added. I'll add Body soon, then release.

Awesome job with this man. :)

Thanks. :) Just added Body runes. Just gonna test a bit more before releasing. E: Oh and I have to fix the experience calculations.

E: Committed! :)

so only air runecrafting works but the walking of the air runecrafting doesn't work means not working lol