SRL Archive - MSI Developer's Panel

[INDENT]These are just a few things I've noticed as activity has picked up. It just ensures everything runs smoothly.

1. ALWAYS pull from the main branch before committing to ensure you have the latest version. Git won't allow you to push without updating, but it's a good habit anyway.
2. ALWAYS test what you've changed before committing! I've seen this happen a couple times. Whether it's a really small change (maybe only a few lines) that looks right, it may not be. There are countless times where I thought something would work, then I go to test it, and I forgot to factor in that maybe this would happen or that would happen.
3. If you're making any significant changes, a thread should be made in the public/SL forums for discussion. There may be some better ideas, or maybe there's something you thought would work when it wouldn't. If you've made a commit that involves major changes to the core (changing some types, editing some variables), a thread should be made here so none of us are confused when we look at the code.
4. If a suggestion/bug has been committed or fixed, add the necessary prefix to that thread to notify people that it's been dealt with. The prefixes have been added for a reason. ;)
5. When adding code throughout the include, try to keep consistent standards (i.e. naming scheme for constants, spaces between cases, etc.). Also, comment as much as you.
6. If someone adds/removes an attribute to any record, check out the How-to Guide to MSI Scripting, and update it accordingly. The same should be done if you update RunMe.simba at all. The MSI Setup Guide should be updated when changes are made. :)
7. When we add new skills, we need something to add the stats to. Remember to login to the MSI profile at the stats site and add a custom variable for the new skill (i.e. for Cooking it would be Food Cooked or something). Username: MSI Phoenix; Passord: msiisleet.

That's it for now, I'm sure some more will come to mind. :)

Cheers,
Coh3n[/INDENT]

Okay guys, I'm not going to point anyone out, but I just spent the last half hour fixing compiling errors. I'm slightly annoyed, but I'll get over it. Anyway, this shouldn't happen. It's not too hard to run CompileMSI. It's not so much that I had to fix them, but the fact that people post about it. I mean, what if none of us look at the forums for a while, or we don't have time to look at the problem? Then MSI goes unusable for however amount of time.

This is just a reminder…

From: Coh3n
Okay guys, I'm not going to point anyone out, but I just spent the last half hour fixing compiling errors. I'm slightly annoyed, but I'll get over it. Anyway, this shouldn't happen. It's not too hard to run CompileMSI. It's not so much that I had to fix them, but the fact that people post about it. I mean, what if none of us look at the forums for a while, or we don't have time to look at the problem? Then MSI goes unusable for however amount of time.

This is just a reminder…

It's inexcusable honestly :/ There's no reason why it should happen.

From: Coh3n
Okay guys, I'm not going to point anyone out, but I just spent the last half hour fixing compiling errors. I'm slightly annoyed, but I'll get over it. Anyway, this shouldn't happen. It's not too hard to run CompileMSI. It's not so much that I had to fix them, but the fact that people post about it. I mean, what if none of us look at the forums for a while, or we don't have time to look at the problem? Then MSI goes unusable for however amount of time.

This is just a reminder…

From: NCDS
It's inexcusable honestly :/ There's no reason why it should happen.

My bad. I did compile, but obviously I had somehow failed. Sorry.

From: marpis
My bad. I did compile, but obviously I had somehow failed. Sorry.

No need to apologize, the more I thought about it I realized that sometimes when I commit thing's some part's fail to commit without notifying me for whatever reason. So, I figured that could be the case, or something else I guess.

I don't think it was a careless error of you, I think it was most likely just a mis-hap along the way somewhere.

Perhaps we should re-check our commits after were done? I don't think it would be all too bad to go to the svn and make sure everything went through properly.

From: NCDS
Perhaps we should re-check our commits after were done? I don't think it would be all too bad to go to the svn and make sure everything went through properly.

Exactly.

Marpis, you aren't the only one. We've all made the mistake at some point, it was just today I noticed a lot of errors, and I was just bringing it to everyone's attention so that now everyone will double check. :)

I'd like everyone to read this again as a reminder. :)

I also added a thing about adding to records. Zyt3x, I think you were the one who added BankMaterials to TScript? Read what I said on this post (8 on the list). :)

E: Also adding something about when adding new skills.

E2: I updated a few other things, so please take the time to reread the thread. :) Thanks.

From: Coh3n
I'd like everyone to read this again as a reminder. :)

I also added a thing about adding to records. Zyt3x, I think you were the one who added BankMaterials to TScript? Read what I said on this post (8 on the list). :)

Which one of them was it, you say? :p You added some more points, thus changing the numbers :)

Thanks for the reminder :redface:
I'll add this to my bookmarks

From: Zyt3x
Which one of them was it, you say? :p You added some more points, thus changing the numbers :)

Thanks for the reminder :redface:
I'll add this to my bookmarks

It's still number 8. ;)

I like this because it lets us all learn from other people's mistakes. The only reason 90% of those points are there are because I made that mistake, and didn't want anyone else to do the same. :p

If anyone finds something that should be added, please add it in. :)