SRL Archive - MSI Bugs

while testing out the form which i made earlier today i noticed that the activity isnt updating in the report
i think it should be changed to

procedure MSI_GetReportInfo;
var
  skill, i: Integer;
begin
  for i:=0 to (HowManyPlayers-1) do
    with ProgressReportArray[i] do
    begin
      if (i=CurrentPlayer) then
      begin
        skill := MSI_Scripts[MSI_Players[i].Scripts[CurrentScript]].SkillConstant;
        ScriptInfo[i].PlayerSkillLevel := GetSkillLevel(skill);
      end;

      PlayerLoc    := MSI_Players[i].Location;
      PlayerStatus := MSI_Players[i].Active;
    end;
end;

~shut

Waste of time:

        level := GetSkillLevel(skill);
        if (level > ScriptInfo[CurrentScript].PlayerSkillLevel) then
          ScriptInfo[i].PlayerSkillLevel := level;
      end;

//better off

ScriptInfo[i].PlayerSkillLevel := GetSkillLevel(skill);

otherwise looks good

~RM

it just if we have it the way it is at the mo then if you set a user from false to true then it wont update the activity in the report even though the user is set to true

~shut

From: Shuttleu
it just if we have it the way it is at the mo then if you set a user from false to true then it wont update the activity in the report even though the user is set to true

~shut

I know, I never 'complained' about anything like that :p

The level thing is just something that I picked up now :p

~RM

From: Rasta Magician
I know, I never 'complained' about anything like that :p

The level thing is just something that I picked up now :p

~RM

yea, i just left it like that because that is what it is like at the mo

i will update the first post with your idea

~shut

The level thing is there because sometimes GetSkillLevel doesn't work and it results in -1, causing the report to print "Not yet defined". Also, the ScriptInfo still needs to be ScriptInfo[CurrentScript].

Anyway, committed. :)

From: Coh3n
The level thing is there because sometimes GetSkillLevel doesn't work and it results in -1, causing the report to print "Not yet defined". Also, the ScriptInfo still needs to be ScriptInfo[CurrentScript].

Anyway, committed. :)

ah, didnt realise, i mistook it for CurrentPlayer :duh:

but anyway, glad i could help

~shut