SRL Archive - MSI Suggestions

i added PS Yews

here are the files that were edited

i also added world info to the declare players, because i was using a members account and a non members account which messed it up

~shut

EDIT:

All you should need to do is create the new script record with the walking points, tools to use etc, and one of us would add it to Scripts.Simba.

Nothing in MSI is hard coded really. The functions are all just generalized so that once the Script record is loaded it has a constant for everything already in the core ready to use.

I forget where Coh3n posted a guide on how to do it, but you can see how people have done it in the 'Supported locations' threads.

sooo… you are or your not going to add it?

~shut

I would be more than happy to add it once it is done correctly.

This is all you need:

SCRIPT_VE_TREES:
      with MSI_Scripts[SCRIPT_VE_TREES] do
      begin
        ScriptName  := 'Varrock east trees';
        ScriptTools := [TOOL_HATCHET];

        SkillName     := 'Woodcutting';
        SkillConstant := SKILL_WOODCUTTING;

        ObjectConstants := [TREE_NORMAL];
        ItemConstants   := [[LOGS_NORMAL]];

        DoesBank := True;
        CompassAng := 'N';

        PathRefTo   := [ Point(3265, 3428), Point(3275, 3429), Point(3280, 3439),
                         Point(3276, 3450)];

        PathRefFrom := [ Point(3280, 3439), Point(3276, 3428), Point(3260, 3428),
                         Point(3253, 3421)];

        PathColorTo   := [ WALK_WC_VE_TREE_1, WALK_WC_VE_TREE_2, WALK_WC_VE_TREE_3,
                           WALK_WC_VE_TREE_4];

        PathColorFrom := [ WALK_WC_VE_BANK_1, WALK_WC_VE_BANK_2, WALK_WC_VE_BANK_3,
                           WALK_WC_VE_BANK_4];
      end;                            

You can leave the color paths blank as I'm assuming you haven't written them, but that's alright.

Once you fill that out properly, you can just post on the Supported Locations thread if you want, or post it here, doesn't matter I guess.

if you looked in scripts in the file i attached above then you would see

    SCRIPT_PS_YEWS:
      with MSI_Scripts[SCRIPT_PS_YEWS] do
      begin
        ScriptName  := 'Port Sarim Yews';
        ScriptTools := [TOOL_HATCHET];

        SkillName     := 'Woodcutting';
        SkillConstant := SKILL_WOODCUTTING;

        ObjectConstants := [TREE_YEW];
        ItemConstants := [[LOGS_YEW]];

        BankType := DBox;
        PathRefTo   := [Point(3041, 3244), Point(3041, 3256), Point(3048, 3263),
                        Point(3052, 3270)];
        PathRefFrom := [Point(3047, 3263), Point(3041, 3254), Point(3041, 3243),
                        Point(3044, 3235)];

        pathColorTo   := [];
        pathColorFrom := [];
      end;

~shut

From: Shuttleu
if you looked in scripts in the file i attached above then you would see

    SCRIPT_PS_YEWS:
      with MSI_Scripts[SCRIPT_PS_YEWS] do
      begin
        ScriptName  := 'Port Sarim Yews';
        ScriptTools := [TOOL_HATCHET];

        SkillName     := 'Woodcutting';
        SkillConstant := SKILL_WOODCUTTING;

        ObjectConstants := [TREE_YEW];
        ItemConstants := [[LOGS_YEW]];

        BankType := DBox;
        PathRefTo   := [Point(3041, 3244), Point(3041, 3256), Point(3048, 3263),
                        Point(3052, 3270)];
        PathRefFrom := [Point(3047, 3263), Point(3041, 3254), Point(3041, 3243),
                        Point(3044, 3235)];

        pathColorTo   := [];
        pathColorFrom := [];
      end;

~shut

Ah, well that's all you need. What did you change in the rest and why?

Also, have you tested a couple loads to make sure it works?

From: NCDS
Ah, well that's all you need. What did you change in the rest and why?

Also, have you tested a couple loads to make sure it works?

debug was

    LOC_PS_YEWS:
      Result := 'Port Sarim yews'; 

walking_reflection was

    LOC_PS_YEWS:
      case endLoc of
        LOC_PS_DBOX:
          Result := MSI_Scripts[SCRIPT_PS_YEWS].PathRefFrom;
      end;

    LOC_PS_DBOX:
      case endLoc of
        LOC_PS_WILLOWS:
          Result := MSI_Scripts[SCRIPT_PS_WILLOWS].PathRefTo;
        LOC_PS_WILLOWS:
          Result := MSI_Scripts[SCRIPT_PS_YEWS].PathRefTo;
      end;

globals was

  LOC_PS_YEWS     = 13;  

and

  SCRIPT_PS_YEWS = 8; 

mainloop was

    SCRIPT_PS_WILLOWS, SCRIPT_PS_YEWS:
      playerInfo := [LOC_PS_DBOX, DBOX_PS];

scripts was what i poted above

in RunMe i added WorldInfo to the declare players because i found out that if you use a member and a non member then it screws up when trying to log into the non member. and i added the script info to the comments at the top

~shut

Well thank you, not at all necessary, but appreciated :)

You really only have to post the script record though and we will take care of the rest. Also, next time, you can just post in the 'Supported Locations" thread.

Have you tested this or no?

It shouldn't mess up with member and non member accounts, it never has for me anyways.

strange, everytime i run it i get

Error: Out Of Range at line 698

which is

script := MSI_Scripts[Scripts[j]];

in MainLoop.scar

i added everything correctly though :(

~shut

From: Shuttleu
strange, everytime i run it i get

which is

script := MSI_Scripts[Scripts[j]];

in MainLoop.scar

i added everything correctly though :(

~shut

I had that issue and it was because I hadn't saved my globals file or something. Try restarting Simba and it should maybe help..

Perhaps the Length of MSI_Scripts needs to be changed or something.

MSI is quite a pain sometimes. I can't seem to get rid of an "invalid number of parameters" error in Mining.Simba right now…I use all the right params!

fixed it
i forgot to change SCRIPT_COUNT from 8 to 9 in Globals.scar

it works but i just realised i dont have enough woodcutting to test it

~shut

From: Shuttleu
fixed it
i forgot to change SCRIPT_COUNT from 8 to 9 in Globals.scar

it works but i just realised i dont have enough woodcutting to test it

~shut

:p

If you can get someone to test it I'll commit it. Otherwise, I can probably test it today/tonight sometime. I've got quite a bit to do today already though.

Shut are you an SL? Your title is wrong if you are.. :\

And if you aren't, you shouldn't just post the files and say "HERE THIS IS RIGHT", from my point of view..

Shut, I love how you edited everything in MSI to work with the record you made! :) I'm assuming you followed my guide? NCDS is right in the sense that you only need to post the record, but I would much rather see you completely add it as it shows your interest in MSI and it familiarizes yourself with the include.

The only thing I ask is that you test at least a full load (and post the proggy) before you upload the files. :) That way we know you've tested them so there should be no problems. The SL's should still test of course, but it makes out job a lot easier. Oh and yeah, you can post it on the AIO Woodcutter thread rather than creating an new one. :)

Nice work. :)

E: Oh, you should also include information like where the trees are and where it banks. You could even make a nice picture like I have in the Supported Locations thread. ;)

E2: Is the .zip on the first post the updated one?

From: 3Garrett3
Shut are you an SL? Your title is wrong if you are.. :\

And if you aren't, you shouldn't just post the files and say "HERE THIS IS RIGHT", from my point of view..

sorry but what is a SL, also i never said that it was right, i just said that i added the info for a new script

From: Coh3n
Shut, I love how you edited everything in MSI to work with the record you made! :) I'm assuming you followed my guide?

yes i did follow your guide :)

From: Coh3n
NCDS is right in the sense that you only need to post the record, but I would much rather see you completely add it as it shows your interest in MSI and it familiarizes yourself with the include.

well in the future i shall remember to just post the record then… :/

From: Coh3n
The only thing I ask is that you test at least a full load (and post the proggy) before you upload the files.

next time i add one i will test it first:)

From: Coh3n


Nice work. :)

thanks :D

From: Coh3n

E: Oh, you should also include information like where the trees are and where it banks. You could even make a nice picture like I have in the Supported Locations thread. ;)

i will update the first post with the info

From: Coh3n

E2: Is the .zip on the first post the updated one?

it is now

~shut

Sorry, I meant MSI scripting leader, the ones who do the bulk of scripting.

I was confused, not trying to insult you. I just thought you seemed like "This is it, now use it" kinda thing, I guess I was mistaken.

From: 3Garrett3
Sorry, I meant MSI scripting leader, the ones who do the bulk of scripting.

I was confused, not trying to insult you. I just thought you seemed like "This is it, now use it" kinda thing, I guess I was mistaken.

its ok, but i never suggest anything like that, i always like to get my stuff checked to make sure it works

~shut

From: Shuttleu
well in the future i shall remember to just post the record then… :/

I said I would rather you do what you did. :p What I meant was if there's a script you want added, all you have to do is make and post the record. Of course, you're more than welcome to do what you did as it makes out job a lot easier. :)

From: Coh3n
I said I would rather you do what you did. :p What I meant was if there's a script you want added, all you have to do is make and post the record. Of course, you're more than welcome to do what you did as it makes out job a lot easier. :)

ah ok then, i will do what i done then (but i will also test it)

i should have a high enough woodcutting level soon on one of the accounts

~shut

From: Shuttleu
ah ok then, i will do what i done then (but i will also test it)

i should have a high enough woodcutting level soon on one of the accounts

~shut

I've got a lot of other things to do today, but if I have time I can test and add it. :)

Just to clear thing's up, if you got the impression I was trying to put down you or your work at any point then I apologize as that was not my intention.:redface:

Added. :)