SRL Archive - MSI Archives

power mining bug

Shuttleu

2010-07-20 07:37:10

while power mining copper at VEM it will click on a rock then a few seconds later click on the same rock again

when the ore has gone out of the rock it will click on the rock below it, then a few seconds later it will click on the rock above it before it has even finished mining the rock it is already on

i suggest checking whether the player is already mining using animations

~shut

Sir R. M8gic1an

2010-07-20 08:04:24

Debug?

~RM

Shuttleu

2010-07-20 08:05:04

unfortunatly its taking a break atm
but give it about 5 mins and i will have one for you

~shut

EDIT: maybe a bit more than 5 mins then :s

Shuttleu

2010-07-20 08:28:55

it isnt acctually debugging anything, not even when it clicks on a rock or walks to some differant rocks

~shut

Heavenguard

2010-07-20 09:12:36

Make sure the colors are good, and adjust the TPA [if your using them] size boxes. Thats what helped me when I made my function for that mine. Also the Wait times if your using them should depend on the player if its like that =/

Shuttleu

2010-07-20 09:16:33

From: Heavenguard
Make sure the colors are good, and adjust the TPA [if your using them] size boxes. Thats what helped me when I made my function for that mine. Also the Wait times if your using them should depend on the player if its like that =/


just to let you know this isnt my own script, its part of MSI. if it was my own script then i would go about looking for the problem, but as it is not mine i feel it is appropriate to tell the owner, the MSI team :)

~shut

Sir R. M8gic1an

2010-07-20 09:21:51

Feel free to look for what may be causing the issue tho ;)

We'll be debugging more, I'm currently working on that.

~RM

Shuttleu

2010-07-20 09:22:37

From: Rasta Magician
Feel free to look for what may be causing the issue tho ;)

We'll be debugging more, I'm currently working on that.

~RM


lol, well i shall do then :p

~shut

Shuttleu

2010-07-20 09:30:24

just curious
  SearchBox := IntToBox(
                       MSCx - Round(RockInfo.W * 1.50),
                       MSCy - Round(RockInfo.H * 1.50),
                       MSCx + Round(RockInfo.W * 1.50),
                       MSCy + Round(RockInfo.H * 1.50));
that would be around the center of the MS not the rock

~shut

NCDS

2010-07-20 10:52:14

From: Shuttleu
just curious
  SearchBox := IntToBox(
                       MSCx - Round(RockInfo.W * 1.50),
                       MSCy - Round(RockInfo.H * 1.50),
                       MSCx + Round(RockInfo.W * 1.50),
                       MSCy + Round(RockInfo.H * 1.50));
that would be around the center of the MS not the rock

~shut


Which is where the rock would be if you were mining it ;)

The bug is in WaitWhileMining, me and Coh3n are both aware of it. I think he fixed this yesterday? If not I'll be committing a new mining.simba today hopefully anyways.

Shuttleu

2010-07-20 11:08:30

From: NCDS
Which is where the rock would be if you were mining it ;)

The bug is in WaitWhileMining, me and Coh3n are both aware of it. I think he fixed this yesterday? If not I'll be committing a new mining.simba today hopefully anyways.

but surely it would be better to do it like the way woodcutting does it
  HalfWidth := (RockInfo.W / 2);
  HalfHeight := (RockInfo.H / 2);
  SearchBox := IntToBox(RockX - HalfWidth, RockY - HalfHeight, RockX + HalfWidth, RockY + HalfHeight);
?

~shut

NCDS

2010-07-20 12:43:31

From: Shuttleu
but surely it would be better to do it like the way woodcutting does it
  HalfWidth := (RockInfo.W / 2);
  HalfHeight := (RockInfo.H / 2);
  SearchBox := IntToBox(RockX - HalfWidth, RockY - HalfHeight, RockX + HalfWidth, RockY + HalfHeight);
?

~shut


If I thought so, I would have made it like that ;)

The mining functions, for the most part, use slightly different methods and parameters, but result the same thing's. To be honest I prefer a few thing's I did with the Mining over what was done with the Woodcutting. Different scripters, different opinions I guess.

Also, as I stated before, I'm going to be committing pretty much a whole new Mining.Simba to MSI today once I get a few kinks worked out.

Coh3n

2010-07-20 18:16:27

From: Shuttleu
but surely it would be better to do it like the way woodcutting does it
  HalfWidth := (RockInfo.W / 2);
  HalfHeight := (RockInfo.H / 2);
  SearchBox := IntToBox(RockX - HalfWidth, RockY - HalfHeight, RockX + HalfWidth, RockY + HalfHeight);
?

~shut

That wouldn't stop the double clicking, though. It would work very well if the player stayed on the same tile the whole time. We would have to test it, it may work better than what we have, idk. But what we have is still buggy and I have no doubt it will work well when we get all the kinks out.

What about an MSI_IsAnimating functions using PixelShift? Marpis did it for IsMoving, I'm sure it can be done for skill animations also.