Con's…
- Community is crap, don't expect anything from them. I don't recommend you release your scripts either, it'll be way more of a headache than it's worth.
- You're not going to learn much. The amount of Java you need to know for RSBot is extremely limited, and the community doesn't encourage learning like SRL does.
Pro's…
- [Much] easier to make flawless scripts
- Last time I was there (months ago), randoms were practically flawless (except for 1-3 randoms, perhaps only one of which consistently failed, the others were 50/50) – more flawlessness
No, the fact that RSBot injects will not get you banned on its own. People have said it's possible for Jagex to detect it,
but even if that's true, they clearly don't, otherwise thousands of RSBotters wouldn't be going strong day after day. What causes the extra bans, in my opinion, is the flawlessness of the scripts. For example, your friend was so caught up in RSBot that he loves autoing 9 hours a day - that'll bring a ban sooner or later. In addition, since scripts are easy to make flawless, as Trilez said, many scripters neglect to take proper precautions. Therefore I recommend you write your own scripts and make sure to take those precautions.
To answer your questions
"Is RSBot good for botting?" - Yes, RSBot itself is probably the best there is if you're looking to bot on RS and nothing else.
"Is RSBot better than SRL?" - Depends on what you value more; RS Botting or an environment that overall is a positive addition to your life.