SRL Archive - SRL Suggestions

Currently, different banking functions use different bank names. This should be universal (and constants rather than 'clt' or 'camelot bank' (for some color banking)?), as it is a little confusing as of now.

I'm confused. They already are universal and use constants:

const
  Bank_FE = 'feb'; // (Falador East Bank)
  Bank_FW = 'fwb'; // (Falador West Bank)
  Bank_VE = 'veb'; // (Varrock East Bank)
  Bank_VW = 'vwb'; // (Varrock West Bank)
  Bank_GE = 'geb'; // (Varrock GE Bank)
  Bank_DR = 'db' ; // (Draynor Bank)
  Bank_AK = 'akb'; // (Al-Kharid Bank)
  Bank_EV = 'eb' ; // (Edgeville Bank)
  Bank_CT = 'ctb'; // (Catherby bank)
  Bank_CM = 'clt'; // (Camelot bank)
  Bank_NA = 'nab'; // (North Ardougne bank)
  Bank_SA = 'sab'; // (South Ardougne bank)
  Bank_YN = 'ynb'; // (Yanille bank)
  Bank_NG = 'ngb'; // (North gnome bank)
  Bank_SG = 'sgb'; // (South gnome bank)
  Bank_WG = 'wgb'; // (Warrior guild bank)
  Bank_FG = 'fgb'; // (Fishing guild bank)  

function OpenBankQuiet(WhichBank: string): Boolean;
By: WT-Fakawi and modified by Ron
Description: Opens any given bank in the free world using
FindDeformedBitmapToleranceIn. Avoids strange mouse movements. Will cause
significant lag (approx. 1 second), but finds the bank with one click.

Valid arguments are:
'feb' (Falador East Bank)
'fwb' (Falador West Bank)
'veb' (Varrock East Bank)
'vwb' (Varrock West Bank)
'db'  (Draynor Bank)
'eb'  (Edgeville Bank)
'akb' (Al-Kharid Bank)

function OpenBankGlass(WhichBank: String; ChangeCompass, ChangeAngle: Boolean): Boolean;
By: Wizzup? and modified by Ron updated to P2p banks by N1ke!
Description: Opens the bank.
Valid arguments are:
'feb' (Falador East Bank)
'fwb' (Falador West Bank)
'veb' (Varrock East Bank)
'vwb' (Varrock West Bank)
'db'  (Draynor Bank)
'akb' (Al-Kharid Bank)
'eb'  (Edgeville Bank)
'ctb' (Catherby bank)
'clt' (Camelot bank)
'nab' (North Ardougne bank)
'sab' (South Ardougne bank)
'ynb' (Yanille bank)
'ngb' (North gnome bank)
'sgb' (South gnome bank)
'wgb' (Warrior guild bank)
'fgb' (Fishing guild bank)

function OpenBankFast(Location: String): Boolean;
By: Wizzup? and Nielsie95 updated by N1ke! updated again by marpis
Last update: 7th December 2009
Description: Opens the bank.
Valid arguments are:
'feb', 'falador east bank'
'fwb', 'falador west bank'
'veb', 'varrock east bank'
'vwb', 'varrock west bank'
'db' , 'draynor bank'
'akb', 'al-kharid bank'
'eb'  (Edgeville Bank)
'ctb', 'catherby bank'
'clt', 'camelot bank'
'nab', 'north ardougne bank'
'sab', 'south ardougne bank'
'ynb', 'yanille bank'
'ngb', 'north gnome bank'
'sgb', 'south gnome bank'
'wgb', 'warrior guild bank'
'fgb', 'fishing guild bank' 

function OpenBank(WhichBank: String, ChangeCompass, ChangeAngle: Boolean): Boolean;
by: SRL Development Team
Description: Opens the bank if possible.
Valid arguments are:
'feb' (Falador East Bank)
'fwb' (Falador West Bank)
'veb' (Varrock East Bank)
'vwb' (Varrock West Bank)
'db'  (Draynor Bank)
'akb' (Al-Kharid Bank)
'eb'  (Edgeville Bank)
'lb'  (Lumbridge Bank)
'ctb' (Catherby bank)
'clt' (Camelot bank)
'nab' (North Ardougne bank)
'sab' (South Ardougne bank)
'ynb' (Yanille bank)
'ngb' (North gnome bank)
'sgb' (South gnome bank)
'wgb' (Warrior guild bank)
'fgb' (Fishing guild bank)  

function FindBank(TheBank: String): Boolean;
By: WT-Fakawi and modified by Ron Updated to P2p by N1ke! Eb added by R1ch
Description: Finds and opens any given bank in the free world.
If the MM DTM is found it will find and open the bank.
Valid arguments are:
'feb' (Falador East Bank)
'fwb' (Falador West Bank)
'veb' (Varrock East Bank)
'vwb' (Varrock West Bank)
'db'  (Draynor Bank)
'akb' (Al-Kharid Bank)
'ctb' (Catherby bank)
'clt' (Camelot bank)
'nab' (North Ardougne bank)
'sab' (South Ardougne bank)
'ynb' (Yanille bank)
'ngb' (North gnome bank)
'sgb' (South gnome bank)
'fgb' (Fishing guild bank)

So the last few are the same, but not the first.

And R_OpenBankBooth has..

'veb', 'varrock east':
        Tiles := [Point(3251,3419), Point(3252,3419), Point(3253,3419),
                  Point(3254,3419), Point(3255,3419), Point(3256,3419)];
    'vwb', 'varrock west':
        Tiles := [Point(3190,3435), Point(3190,3437), Point(3190,3439),
                  Point(3190,3441), Point(3190,3443), Point(3181,3444),
                  Point(3181,3442), Point(3181,3440), Point(3181,3438),
                  Point(3181,3436)];
    'falador west', 'fwb':
        Tiles := [Point(2945,3367), Point(2946,3367), Point(2947,3367),
                  Point(2948,3367)];
    'falador east', 'feb':
        Tiles := [Point(3010,3354), Point(3011,3354), Point(3012,3354),
                  Point(3013,3354), Point(3014,3354), Point(3015,3354)];
    'lumbridge', 'lb':
        Tiles := [Point(3208,3221)];
    'draynor', 'db':
        Tiles := [Point(3091,3419), Point(3091,3245), Point(3091,3244),
                  Point(3091,3243), Point(3091,3242)];
    'al kharid', 'akb':
        Tiles := [Point(3268,3168), Point(3268,3167), Point(3268,3166),
                  Point(3268,3165), Point(3268,3164)];
    'seb', 'seers':
        Tiles := [Point(2729,3494), Point(2728,3494), Point(2727,3494),
                  Point(2724,3494), Point(2722,3494)];
    'eb', 'edgeville':
        Tiles := [Point(3095,3489), Point(3095,3491), Point(3095,3493),
                  Point(3097,3495)];
    'cb', 'catherby':
        Tiles := [Point(2807, 3442), Point(2809, 3442), Point(2810, 3442), Point(2811, 3442)];
    'fgb', 'fishing guild':
        Tiles := [Point(2585, 3422), Point(2585, 3421), Point(2585, 3419), Point(2585, 3418)];
    'mc', 'moonclan':
        Tiles := [Point(2098, 3920), Point(2097, 3920), Point(2098, 3920)];
    'yb', 'yanille':
        Tiles := [Point(2614, 3094), Point(2614, 3092), Point(2614, 3091)];
    'da', 'duel arena': Tiles := [Point(3381, 3269), Point(3382, 3270)];
    'asb', 'ardougne south': Tiles := [Point(2656, 3286), Point(2656, 3283)];
    'pc', 'pest control':
        Tiles := [Point(2667, 2652), Point(2666, 2652), Point(2665, 2652),
                  Point(2668, 2652)];

(I realize that R_OpenBankBooth has nothing to do with this thread, but I figured there was no point in making a new thread in the reflection section; I'm sure someone will see it here.)

imo R_OpenBankBooth doesn't really need to have its location declared. I thought about this awhile ago but all you really have to do is do a distance check with the bank booth coords and you'd find the correct coord fairly fast. Also we know there are discrepancies in the code, we are trying to avoid this with SRL 5 etc. There is still more to do with regards to reflection as well.

^ I agree. :p I never really understood that.

Anyway, as long as someone knows, that's fine. :) I just thought I'd bring it up in case.

Well you go and make all P2P banks openable with OpenBankFast, OpenBankQuiet and FindBank :rolleyes:
Not too many developers are even members.

^ wat

That's not what I'm talking about. I'm just saying that when I had 'clt' for OpenBank, OpenBankQuiet didn't know what 'clt' was.

OpenBankQuiet doesn't support many banks. The ones that it does support probably don't even work anyway.