SRL Archive - General

Deleting Bitmaps from the TItem record


Coh3n

2010-06-24 22:13:23

Does anyone else agree? I honestly don't see the point. If the item is there, the DTM will work 99.9% of the time, and if it doesn't, colour recognition will find it.

I just seems to me that there's no need for them as they will never get used. Not to mention it's a pain to update them all since we can't use a system like we have for DTMs.

I'm doing a lot of maintenance on MSI while I switch to script based, and this came up.

Thoughts?

Coh3n

2010-06-24 22:18:42

Oh, and another thing: I think it would be better if we changed the way we load items. Right now it's all stored in a global array, but I think it should just be loaded/freed locally. So MSI_GetItem would return a TItem instead of a boolean. It would make things easier and more understandable for everyone. I'm not sure exactly why Naum decided to do it this way, but there may be a good reason, I don't know.

NCDS

2010-06-24 22:49:59

From: Coh3n
Does anyone else agree? I honestly don't see the point. If the item is there, the DTM will work 99.9% of the time, and if it doesn't, colour recognition will find it.

I just seems to me that there's no need for them as they will never get used. Not to mention it's a pain to update them all since we can't use a system like we have for DTMs.

I'm doing a lot of maintenance on MSI while I switch to script based, and this came up.

Thoughts?

I 100% percent agree with this. I thought about this a while ago actually, just never thought to mention anything.
From: Coh3n
Oh, and another thing: I think it would be better if we changed the way we load items. Right now it's all stored in a global array, but I think it should just be loaded/freed locally. So MSI_GetItem would return a TItem instead of a boolean. It would make things easier and more understandable for everyone. I'm not sure exactly why Naum decided to do it this way, but there may be a good reason, I don't know.

Not sure about this. I'm going to have to look into it tomorrow as I have work tomorrow and need to get to sleep.

Have you asked Naum if there is a reason for the Boolean?

Coh3n

2010-06-24 22:51:21

From: NCDS
I 100% percent agree with this. I thought about this a while ago actually, just never thought to mention anything.

Always mention things that are on your mind! :D

From: NCDS

Not sure about this. I'm going to have to look into it tomorrow as I have work tomorrow and need to get to sleep.

Have you asked Naum if there is a reason for the Boolean?

No, I haven't. I haven't talked to him in a while actually, I'm not sure what he's been up to.

NCDS

2010-06-24 22:56:50

From: Coh3n

No, I haven't. I haven't talked to him in a while actually, I'm not sure what he's been up to.


Finishing up some exams. He should be active again soon though. I think his last one was this week.

Coh3n

2010-06-24 22:57:46

Sounds good. :)

marpis

2010-06-25 08:09:01

Yes for both. I never liked the idea of loading the items into global array. That's why I didn't do that on TMSObjects.

Naum

2010-06-25 12:11:08

From: Coh3n
I'm not sure exactly why Naum decided to do it this way, but there may be a good reason, I don't know.


Change it, bro

Coh3n

2010-06-25 12:16:27

From: Naum
Change it, bro

Alrighty. :) I've been working on this thing for hours lol. It was a lot more work than I thought.