SRL Archive - SRL Archives

[Runtime Error] : Exception: Access violation at address 041AAE36 in module 'WizzyPlugin.dll'. Read of address 00000000 in line 558 in script C:\Program Files\SCAR 3.23 Beta\includes\SRL\SRL\Core\Text.scar

{*******************************************************************************
function ChooseOptionMultiEx(Texts: TStringArray; TextType: String; Action: fnct_ActionOptions): Boolean;
By: Wizzup?, Nava2, and N1ke!
Description: Finds Popup menu, then clicks on it.
             Will look for the first string first and so on.
             It will search for the Text Type you input valid arguments are
             'action', 'player': The white text
             'npc': The yellow text
             'object': The cyan text
             'all': Searches for all colors of text.
             Will default to 'all'.
*******************************************************************************}
function ChooseOptionMultiEx(Texts: TStringArray; TextType: String; Action: fnct_ActionOptions): Boolean;
var
   B,OptionBox: TBox;
   TPA, TextTPA: TPointArray;
   aTPA: T2DPointArray;
   I, H, HH, ii, L: Integer;
   Colors,SearchCols: TIntegerArray;
begin
  Result := False;
  GetClientDimensions(B.X2, B.Y2);
  B.X1 := 0;
  B.Y1 := 0;
  Dec(B.X2);
  Dec(B.Y2);
  FindColorsTolerance(TPA, 4016722, B.X1, B.Y1, B.X2, B.Y2, 0);
  If Length(TPA) < 10 Then
    Exit;
  B.X2 := 0;
  B.Y2 := 0;
  aTPA := SplitTPAEx(TPA, 20, 20);
  SortATPASize(aTPA, True);
  B := GetTPABounds(aTPA[0]);
  Colors := [13034990, 4231423, 2070783, 65535, 16776960, 9812166];
  TextType := LowerCase(TextType);
  case TextType of
    'action', 'player': SearchCols := [0,5];
    'item'  : SearchCols := [1,2];
    'npc'   : SearchCols := [3];
    'object': SearchCols := [4];
    else
      SearchCols := [0,1,2,3,4,5];
  end;
  L := High(SearchCols);
  SetLength(aTPA,l+1);
  for i := 0 to l do
    FindColorsTolerance(aTPA[I], Colors[SearchCols[I]], B.X1, B.Y1, B.X2, B.Y2, 3);
  TPA := MergeATPA(aTPA);
  aTPA := SplitTPAEx(TPA, 7, 1);
  L := High(aTPA);
  H := High(Texts);
  SortATPAFromFirstPoint(ATPA, Point(OptionBox.X1, optionbox.y1));
  for I :=0 To H do
  begin
    TextTPA := LoadTextTPA(Texts[i], UpChars, HH);
    for ii := 0 to L do
      If FindTextTPAInTPA(HH, TextTPA, aTPA[ii], TPA) Then
      begin
        Result := True;
        case Action of
          ClickLeft: MouseBoxEx(B.x1 + 5, TPA[0].Y, B.x2 - 5, TPA[0].Y + 5,5, 1);
          Move:      MouseBoxEx(B.x1 + 5, TPA[0].Y, B.x2 - 5, TPA[0].Y + 5,5, 3);
          Nothing:   begin end;
          else
            srl_warn('ChooseOptionMultiEx', 'ClickRight not a valid click for RS menus!', warn_AllVersions);
        end;
        Exit;
      end;
  end;
  MMouse(B.X1 - 50, B.Y1 - 50, 40, B.Y2 - B.Y1);
  Wait(200 + Random(100));
end;

aTPA := SplitTPAEx(TPA, 20, 20);
  SortATPASize(aTPA, True);
  B := GetTPABounds(aTPA[0]);

  FindColorsTolerance(TPA, 4016722, B.X1, B.Y1, B.X2, B.Y2, 0);
  If Length(TPA) < 10 Then
    Exit;
  B.X2 := 0;
  B.Y2 := 0;
  B := GetTPABounds(TPA);
  //aTPA := SplitTPAEx(TPA, 20, 20);
  //SortATPASize(aTPA, True);
  //B := GetTPABounds(aTPA[0]);

From: Narcle
I believe the only reason they split that TPA is to make sure its getting the right box. In case there are other colors on the screen, since ChooseOption looks at the whole screen.

I've had similar problems running in Simba with the box being to big… I've actually already reported this but I think it was in Dev section. It doesn't crash it in Simba just makes the mouse go weird.

{*******************************************************************************
function ChooseOptionMultiEx(Texts: TStringArray; TextType: String; Action: fnct_ActionOptions): Boolean;
By: Wizzup?, Nava2, and N1ke!
Description: Finds Popup menu, then clicks on it.
             Will look for the first string first and so on.
             It will search for the Text Type you input valid arguments are
             'action', 'player': The white text
             'npc': The yellow text
             'object': The cyan text
             'all': Searches for all colors of text.
             Will default to 'all'.
*******************************************************************************}
function ChooseOptionMultiEx(Texts: TStringArray; TextType: String; Action: fnct_ActionOptions): Boolean;
var
   B,OptionBox: TBox;
   TPA, TPA1, TPA2, TextTPA: TPointArray;
   aTPA: T2DPointArray;
   I, H, HH, ii, L: Integer;
   Colors,SearchCols: TIntegerArray;
begin
  Result := False;
  GetClientDimensions(B.X2, B.Y2);
  B.X1 := 0;
  B.Y1 := 0;
  Dec(B.X2);
  Dec(B.Y2);
  FindColorsTolerance(TPA1, 4016722, B.X1, B.Y1, B.X2, B.Y2, 0);
  FindColorsTolerance(TPA2, 4409686, B.X1, B.Y1, B.X2, B.Y2, 0);
  TPA := CombineTPA(TPA1, TPA2);
  If Length(TPA) < 10 Then
    Exit;
  B.X2 := 0;
  B.Y2 := 0;
  aTPA := SplitTPAEx(TPA, 20, 20);
  SortATPASize(aTPA, True);
  B := GetTPABounds(aTPA[0]);
  Colors := [13034990, 4231423, 2070783, 65535, 16776960, 9812166];
  TextType := LowerCase(TextType);
  case TextType of
    'action', 'player': SearchCols := [0,5];
    'item'  : SearchCols := [1,2];
    'npc'   : SearchCols := [3];
    'object': SearchCols := [4];
    else
      SearchCols := [0,1,2,3,4,5];
  end;
  L := High(SearchCols);
  SetLength(aTPA,l+1);
  for i := 0 to l do
    FindColorsTolerance(aTPA[I], Colors[SearchCols[I]], B.X1, B.Y1, B.X2, B.Y2, 3);
  TPA := MergeATPA(aTPA);
  aTPA := SplitTPAEx(TPA, 7, 1);
  L := High(aTPA);
  H := High(Texts);
  SortATPAFromFirstPoint(ATPA, Point(OptionBox.X1, optionbox.y1));
  for I :=0 To H do
  begin
    TextTPA := LoadTextTPA(Texts[i], UpChars, HH);
    for ii := 0 to L do
      If FindTextTPAInTPA(HH, TextTPA, aTPA[ii], TPA) Then
      begin
        Result := True;
        case Action of
          ClickLeft: MouseBoxEx(B.x1 + 5, TPA[0].Y, B.x2 - 5, TPA[0].Y + 5,5, 1);
          Move:      MouseBoxEx(B.x1 + 5, TPA[0].Y, B.x2 - 5, TPA[0].Y + 5,5, 3);
          Nothing:   begin end;
          else
            srl_warn('ChooseOptionMultiEx', 'ClickRight not a valid click for RS menus!', warn_AllVersions);
        end;
        Exit;
      end;
  end;
  MMouse(B.X1 - 50, B.Y1 - 50, 40, B.Y2 - B.Y1);
  Wait(200 + Random(100));
end;

From: IceFire908
I've been debating over the best solution to this problem, apparently when the options box becomes large enough the color 4016722 does not go around the entire border, some times only the left side in fact, I believe by adding another color search (4409686 the color of the horizontal outline bar that divides the words choose option and walk here) and then merging it with the other TPA it should always yield at least an upside down L shaped TPA which you can grab accurate bounds with and not cause the other error.

I want you to replace your ChooseOptionMultiEx function with this and tell me if it works

Edit: I had to fix something urgent in Login.scar, just update your SRL to the latest and tell me if it works the function seen below is already in there.

From: Tim0suprem0
The appearance of the edgecolor on only one side was really weird. As I was testing this out today and debugging I noticed that with DebugTPA of 4016722 it found the color on both sides every time, whereas there were some times that after doing SplitTPAEx(tpa, 20, 20) where DebugATPA highlighted only the left side. This happened only when the optionbox was as big from the client top to bottom (and 4016722 wasn't there on the bottom of the optionbox).

Anyways your fix worked perfectly for me, and I believe it is a good complete solution to both problems. So thanks! :D

From: IceFire908
Just to clear things up, it's to my understanding that SplitTPA works by removing points that are not within a certain distance of eachother, so when two different halfs of a TPA are too far away from eachother it splits them (depending on your w/h ect..) thats why adding the horizontal color brings the two together and gives an accurate bounds that won't throw an access violation of somesort.

Glad to hear it worked :)

From: Tim0suprem0
Ahhh ok, the description says "Splits the points with max X and Y distances W and H to their own TPointArrays." so I assumed it would keep all the points and just divide them up,

  Colors := [13034990, 4231423, 2070783, 65535, 16776960, 9812166, 16777215];
  TextType := LowerCase(TextType);
  case TextType of
    'action', 'player': SearchCols := [0,5,6];
    'item'  : SearchCols := [1,2];
    'npc'   : SearchCols := [3];
    'object': SearchCols := [4];
    else
      SearchCols := [0,1,2,3,4,5,6];
  end;

From: Narcle
Didn't feel like making a new post, and I believe its associated with this fix.

1. It no longer searches top to bottom from text all the time, its sometimes selects the bottom most option. Say you give it a item name like "rune" instead of say picking it up (Take), instead it'll just examine it.

2. The variable "OptionBox" has nothing declared to it and is used for the splittpa sorting. I've tried a couple different ways and I have not been able to fix problem 1.

Any ideas?

From: NCDS
1. Could just be misreading the text? That happens for me quite often.

2. :cartman: 1:14 a.m.