SRL Archive - Judges' Spot

What I have Marked you on

All the scripts were marked using the same criteria, and I marked them at the level that I would have expected from someone with a Scriter's Cup. Below is a short summary of how you were marked.

1. Technique (/100)

This relates to what type of loops you have used where, how you decided to load all of those variables, if you used types correctly etc.

2. Individuality (/100)

This refers to whether your scripting style is your own or not. The more individual your script is, the better it is for you, because this means you really understand what all of the different procedures / functions / types / methods should be used for. it means you are relying less on other people, and are developing your own style.

3. Follow all SRL rules (/100)
This reffers to breaking out of infinite loops, breaking out of loops/procedures if your character is not logged in, the script being multiplayer, etc.

4. Creativity (/100)

How creative was the script, how different was it to everyone else's, was it what I was expecting the mass to do, or did yours stand out of the crowd?

5. Efficiency (/100)

This is the thing I am most strict about. The more efficient the script is, the better it is. Why constantly write out procedures when you can use a simple repeat instead? Are you using "end else" when needed? Do you have duplicate functions? Are you freeing DTMs / bitmaps after finishing with them? The more efficient your script is, the better it will run, and the easier errors will be to fix when they arise.

6. Presentation (/100)

Presentation of a script is always important! And this should be easy marks. There are only 4 categories. Do you have a respectable title page? A decent progress report? Good scripting standards? Commented procedures and functions? (which is the one everyone always forgets!)

7. Meeting all Requirements (/100)
Does your Script sell in Rimmington? Does it have Multiplayer? Does it mine tin, copper, iron and gold? Is it able to run with the pickaxe in the inventory or equipped? Does it have antirandoms, antiban and a progress report? If so you just earnt yourself 100 points free of charge.


8. Added Extras (/100)

What extra features did you include in your script? The more that are in there, the better it is. Be careful though, because including extra features which don't work / aren't efficient could get you marked down in other categories!

This was the grading scheme for the last JM competition.
Do we want to be more specific? I'm not sure whether it would be beneficial or not, fairer or not, a pain in the ass or not, etc. What are everyone's thoughts?

~RM

Here's a good example of something we'd like

From: masterBB
Here is my review. Please take it lightly, it seems you put a lot of effort in this script. It looks great and you aren't far from being a member by my standards imo.

      7: MissMouse(100,100);
      9: ExamineInv;
      10:
    end;

Why you kept the 10: there? Looks a bit like you didn't cared.

 1: begin BreakText; Wait(15000 + random(7900)); end;

Way too many semicolons on one line.

//--Bank, Ruins, Altar and Portal Locations--\\

function IsAtBank: Boolean;

function IsAtRuins: Boolean;

function IsAtAltar: Boolean;

function IsAtPortal: Boolean;

They all do the same, just with a different ObjectDTM. Could be one function.

function WaitTill70: Boolean;
begin
  Result := RunEnergy(70);
end;

Not a really meaning full name. It doesn't wait. Seventy what? IsEnergie70 or Got70Energie would be better.

procedure WalkToRuins;

procedure WalkToBank;

These procedures look really repetive. It would be better to use an array of ObjectDtms or add more non objectsDtms method as back up. These procedures look a bit ugly.

procedure Arrays;

Not a real meaning full procedure name. SetArraysLength or SetupGlobalArrays would be better.

procedure ScriptTerminate;
begin
  ProggyTest;
end;

One line procedure.

The end loop contains too much begin and end statements. You used x and y as global vars. Note that all thick black words don't start with a capital letter. I also find the script a bit too simple.

Looks great thanks for the examples

It would be convenient to provide a copy/pasteable template in the original post for us to use. It was a pain for me (and I'm sure the other judges) to make our own because there's no way (or at least not for us non-admins) to view the quoted text in the original post. Something like this:

[B][SIZE="3"]Technique ( /100)[/SIZE][/B]

[B][SIZE="3"]Individuality ( /100)[/SIZE][/B]

[B][SIZE="3"]Follow all SRL rules ( /100)[/SIZE][/B]

[B][SIZE="3"]Creativity ( /100)[/SIZE][/B]

[B][SIZE="3"]Efficiency ( /100)[/SIZE][/B]

[B][SIZE="3"]Presentation ( /100)[/SIZE][/B]

[B][SIZE="3"]Meeting all Requirements ( /100)[/SIZE][/B]

[B][SIZE="3"]Added Extras ( /100)[/SIZE][/B]

[B][SIZE="3"]Average ( /100)[/SIZE][/B]

Now we can copy yours :) Thanks neb!

Thanks neb, great skeleton