SRL Archive - OSR Help

Someone to look over my code


3Garrett3

2010-06-11 20:13:29

Hey guys,

I've been working on a Karamja fisher and seller/noter, as some of you may know. The script should be working as planned, and whenever I watch it, nothing seems to go wrong. I never watch for long periods of time, but when I find myself navigating to other windows while SMART is running, I will come back and my script has logged out in the middle of working.

The code looks sound in my eyes, but I'm never good at making efficient code, or noticing my own mistakes in code. So I'm looking for someone who knows enough scripting to help me, first of all, and someone who has time to look through 600-700 lines of script.

Any help is welcome :)

Thanks,
Garrett

Tim0suprem0

2010-06-12 00:12:51

I'm not the greatest scripter in the world, but if you want to send it to me, I'd be happy to take a look at it, and let you know anything that catches my eye.

And certainly no hurt feelings if you say no thanks :p

YoHoJo

2010-06-12 00:31:28

Just post the thing dude.

Also, when minimizing/un-minimizing SMART the screen flashes white/black for a second which often times screws scripts up and makes players go false etc, so that may be the reason since you said you 'navigating to other windows while SMART is running, I will come back', so I'm guessing that's the problem.

3Garrett3

2010-06-12 08:54:39

From: YoHoJo
Just post the thing dude.

Also, when minimizing/un-minimizing SMART the screen flashes white/black for a second which often times screws scripts up and makes players go false etc, so that may be the reason since you said you 'navigating to other windows while SMART is running, I will come back', so I'm guessing that's the problem.


Well I didn't want to release crappy looking code. It's a pride thing ;)

I think the problem lies in the path, and some kind of error that Tad told me about last night that has to do with reflection thinking it walked a path for some reason when it hasn't. I'll try a really ugly looking fix, and then post it in the scripts section for all to see :)

Rich

2010-06-13 04:58:58

If you don't feel like posting it in the public forum, post it in the Members section. :)

i luffs yeww

2010-06-13 05:05:40

^ He already released it. :p

Rich

2010-06-13 05:11:55

From: i luffs yeww
^ He already released it. :p

:redface: