SRL Archive - SRL Bugs

Not sure where to post this, but the developement area seems the most logical place, (perhaps a bugs forum is needed (hopefully not))

When I tried Running R_ItemIDExists(Item, 1925)
(1925 is an empty bucket) but when it crashes, I have done a quick check to see when error occours….

I edited the function (added some Writeln and Waits) so I could see what happened before simba completly crashed.

function R_ItemIDExists(var Item: TInvItem; ID: Integer): boolean;
var
  i: integer;
  Temp: TInvItem;
begin
  Result := true;
  for i := 1 to 28 do
  begin
    Writeln('I := ' + IntToStr(I));
    Temp := GetInvItemAt(i);
    Writeln('Step 1 completed');
    Wait(1500);
    Item := Temp;
    Writeln('Step 2 completed');
    Wait(1500);
    if(Temp.ID = ID)then
      exit;
    Writeln('Step 3 completed');
    Wait(1500);
  end;
  Temp := NullInvItem;
  Result := false;
end;

Which outputs (in debug)

[BANANA]
I := 1
Step 1 completed
Step 2 completed
Step 3 completed
I := 2[/BANANA]

Does it say anything when it crashes? Can I see the function you are using it in?

It's the "GetInvItemAt(i);" that makes it crash, so so the bug is probably in there

From: Zyt3x
It's the "GetInvItemAt(i);" that makes it crash, so so the bug is probably in there

I had this problem yesterday but it wasnt in that function. It was outside of it.

From: drags111
I had this problem yesterday but it wasnt in that function. It was outside of it.

That… Doesn't make sense o_o

What's up with this:

SmartFreeObject(Inv);
SmartFreeObject(Itm);
SmartFreeObject(Name);
SmartFreeObject(Acts);

???

Does "SmartGetFieldObject()" create an object when called?

From: Zyt3x
That… Doesn't make sense o_o

What's up with this:

SmartFreeObject(Inv);
SmartFreeObject(Itm);
SmartFreeObject(Name);
SmartFreeObject(Acts);

???

Does "SmartGetFieldObject()" create an object when called?

Its like FreeDTM. You have to call it or you get memory leaks.

I have fixed the bug, permanently, and fixed inventory.simba to be a lot more standard orientated, cleaner, and to prevent that bug from ever happening again. Solved =]

sweet thanks

What was the bug? How did you fix it?

Just Confirming the fix DOES work.