SRL Archive - SRL Archives

Little diff patch for a bug in PS (I Think =/) just adds Result := ''; to the begining of a few functions that need it =) more details here patch attached and posted!

- Patch -

Index: SRL/core/Chat.scar
===================================================================
--- SRL/core/Chat.scar	(revision 468)
+++ SRL/core/Chat.scar	(working copy)
@@ -426,6 +426,7 @@
   Str : TStringArray;
 
 begin
+  Result := '';
   Str := ['flash1:', 'flash2:', 'flash3:', 'glow1:', 'glow2:', 'glow3:', 'red:',
     'green:', 'cyan:', 'purple:', 'white:', 'scroll:', 'shake:', 'slide:',
     'wave:', 'wave2:'];
Index: SRL/core/Text.scar
===================================================================
--- SRL/core/Text.scar	(revision 468)
+++ SRL/core/Text.scar	(working copy)
@@ -179,6 +179,7 @@
   i, j, TPos, Prob, Mist, L: Integer;
   Norm, Caps, Excp, TLine, NewKey: string;
 begin
+  Result := '';
   Norm := '`1234567890-=qwertyuiop[]\asdfghjkl;''zxcvbnm,./';
   Caps := '~!@#$%^&*()_+QWERTYUIOP{}|ASDFGHJKL:"ZXCVBNM<>?';
   Excp := '`1234567890-=[]\;'',./~!@#$%^&*()_+{}|:"<>?';
Index: SRL/misc/Friends.scar
===================================================================
--- SRL/misc/Friends.scar	(revision 468)
+++ SRL/misc/Friends.scar	(working copy)
@@ -138,6 +138,7 @@
 var
    I: Integer;
 begin
+  Result := 0;
   GetFriends;
   for I := 1 to 13 do
     if Friends[I].IsOnline then
Index: SRL/misc/Reports.scar
===================================================================
--- SRL/misc/Reports.scar	(revision 468)
+++ SRL/misc/Reports.scar	(working copy)
@@ -108,6 +108,9 @@
   s          : string;
   i, i2, L   : integer;
 begin
+  if (ResultType = ResultString) then
+    Result := '';
+
   if length(VarNames) <> Length(VarValues) then
   begin
     SRL_Warn('SRLProgressReport', 'VarNames and VarValues must be the same length', warn_AllVersions);
@@ -209,6 +212,9 @@
   i, i2, i3, L, PN, c, d : integer;
   T2DVA                  : Array of TVariantArray;
 begin
+  if (ResultType = ResultString) then
+    Result := '';
+
   if Length(DefaultSettings) <> 6 then
   begin
     SRL_Warn('SRLPlayerReport', 'DefaultSettings must be exactly 6 settings!', warn_AllVersions);
@@ -476,4 +482,4 @@
             end;
     end;
   end;
-end;
\ No newline at end of file
+end;
Index: SRL/misc/trade.scar
===================================================================
--- SRL/misc/trade.scar	(revision 468)
+++ SRL/misc/trade.scar	(working copy)
@@ -197,6 +197,7 @@
   x, y: Integer;
   x1, y1, x2, y2: Integer;
 begin
+  Result := 0;
   if (TradeScreen <> 2) then Exit;
   if (them) then
   begin
@@ -411,4 +412,4 @@
     if (SRL_Procs[srl_OnFindTrade] <> nil) then
       SRL_Procs[srl_OnFindTrade]();
   end;
-end;
\ No newline at end of file
+end;
Index: SRL/misc/arrayLoader.scar
===================================================================
--- SRL/misc/arrayLoader.scar	(revision 468)
+++ SRL/misc/arrayLoader.scar	(working copy)
@@ -68,6 +68,7 @@
 var
   i, tPtLength: Integer;
 begin
+  Result := '';
   tPtLength := GetArrayLength(newTPoint);
   repeat
     Result := Result + IntToStr(newTPoint[i].x) + ',' +
@@ -131,6 +132,7 @@
 var
   i, arrayLength: Integer;
 begin
+  Result := '';
   arrayLength := Length(intArray);
   repeat
     Result := Result + IntToStr(intArray[i]);
@@ -193,6 +195,7 @@
 var
   i, arrayLength: Integer;
 begin
+  Result := '';
   arrayLength := Length(floatArray);
   repeat
     Result := Result + FloatToStr(floatArray[i]);
@@ -257,6 +260,7 @@
 var
   i, arrayLength: Integer;
 begin
+  Result := '';
   arrayLength := GetArrayLength(strArray);
   repeat
     Result := Result + (strArray[i]);
@@ -319,6 +323,7 @@
 var
   i, arrayLength: Integer;
 begin
+  Result := '';
   arrayLength := GetArrayLength(boolArray);
   repeat
     Result := Result + BoolToStr(boolArray[i]);

Committed.

I apologize for the unbelievable offtopicness of this question, but who changed Dgby's title to "STD Fuzz"? And why?

He either wanted it, or they changed it and he doesn't care.
Also, I believe some Dev practiced this; initializing the result at the beginning of the function because of this.

From: Sex
He either wanted it, or they changed it and he doesn't care.
Also, I believe some Dev practiced this; initializing the result at the beginning of the function because of this.

me brah.

From: Nava2
me brah.

It was before your time :D.

Erik does it.

From: Tim0suprem0
I apologize for the unbelievable offtopicness of this question, but who changed Dgby's title to "STD Fuzz"? And why?

I asked someone to change it then me and him discussed it and it ended up being "STD Fuzz"… (Not what i originally wanted but still ok =))