[QUOTE=Camaro';695229]I don't know, besides that how does the script look?
In your NextPlayer_A procedure, why do you do
if PlayersActive = 1 then
begin
if DebugScript then Writeln('Exiting Next player');
if DebugScript then Writeln('Only one character left');
exit;
end;
//instead of
if (PlayersActive = 1) then
begin
if (DebugScript) then
begin
Writeln();
Writeln();
end;
Exit;
end;
You do that more than once, any particular reason for it? Also, you look like you copied/pasted SRL's NextPlayer, and just added a couple things in. I may be wrong, but couldn't you just do
procedure NextPlayer_A(Active: Boolean);
var
srl_PlayerIndexFunc: function: Integer;
I:Integer;
cP: Integer;
begin
if PlayersActive = 1 then
begin
if DebugScript then Writeln('Exiting Next player');
if DebugScript then Writeln('Only one character left');
exit;
end;
if DebugScript then Writeln('Switching Players: Waiting');
I := (39999) + random(59999);
if DebugScript then Writeln(''+inttostr(Round(i/1000))+' seconds before logging back in');
NextPlayer(Active);
SetupCharacter;
Inc(Switched);
end;
There's no need for all the if statements in your Antiban. You can still use a case
case Random(50) of
0..6:
27..43:
45..49:
end;
Also, why do you have the exact same if statements twice?
When you walk to the fish, you could/should use coord clicking as a last resort. In my Draynor script, I use MouseBox to get to and from the bank, and it never gets lost. Since it's only one point to and from the bank, there's not reason why it wouldn't work.
How do the SRL banking functions work? In my experience, they don't work the best.
Some of your standards seem to be a little weird, but that could just be me, everyone has their own style. ;)